From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: encapsulate forcewake in dev_priv
Date: Tue, 13 Sep 2011 23:25:46 +0100 [thread overview]
Message-ID: <e39f63$1i9epd@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1315951648-5380-1-git-send-email-ben@bwidawsk.net>
On Tue, 13 Sep 2011 15:07:28 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> I had this lying around and forgot to submit it. I feel it makes the
> forcewake stuff slightly cleaner, but this is only cosmetic.
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
I like it as it makes it clearer the capability we are testing for. But
when to use INTEL_INFO and when to set derived bits on dev_priv? That is
the question.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-09-13 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 22:07 [PATCH] drm/i915: encapsulate forcewake in dev_priv Ben Widawsky
2011-09-13 22:25 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$1i9epd@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.