From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/2] drm/i915: collect per ring page fault info on error
Date: Tue, 20 Sep 2011 10:42:52 +0100 [thread overview]
Message-ID: <e39f63$1l1psb@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1316459275-6292-1-git-send-email-ben@bwidawsk.net>
On Mon, 19 Sep 2011 12:07:54 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
These are a nice set of cleanups and the extra fault reporting may come
in handy. (I thought that fault register was to be used in conjunction
with ppgtt in order for the gpu to fault in pages...)
As Daniel mentioned we need to include the VCS for the acthd_stuck()
check. I mentioned that I thought the general ERROR register was
actually per-ring, but checking the specs I don't see it replicated. The
only silly thing is that this introduces an array of register values for
only some of the per-ring registers, hence a bit of inconsistency and
just calling out for a complete overhaul of those per-ring structures
and hopefully code reduction ;-)
Per-ring per-gen hangcheck/error recording/error reporting may be
useful. More likely overkill. ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-09-20 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 19:07 [PATCH 1/2] drm/i915: collect per ring page fault info on error Ben Widawsky
2011-09-19 19:07 ` [PATCH 2/2] drm/i915: check acthd for all rings Ben Widawsky
2011-09-19 20:36 ` Ben Widawsky
2011-09-20 9:42 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$1l1psb@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.