From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 3/5] drm/i915: implement SNB workaround for lazy global gtt
Date: Wed, 15 Feb 2012 23:10:08 +0000 [thread overview]
Message-ID: <e39f63$3o5bcf@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1329346225-14795-4-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 15 Feb 2012 23:50:23 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> + /* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
> + * pipe_control writes because the gpu doesn't properly redirect them
> + * through the ppgtt for non_secure batchbuffers. */
> + if (unlikely(IS_GEN6(dev) &&
> + reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION &&
> + !target_i915_obj->has_global_gtt_mapping)) {
> + i915_gem_gtt_bind_object(target_i915_obj,
> + target_i915_obj->cache_level);
> + target_i915_obj->has_global_gtt_mapping = 1;
i915_gem_gtt_bind_object() sets has_global_gtt_mapping, so no need to
repeat ourselves here.
I guess that was the easy one you throw in to make sure people are
reading your patches?
A little uneasy still with that heuristic, but I have to agree that it
is the lesser of the evils, meh.
I'm pretty happy now with this series as I've been beating upon it ever
since it landed in danvet/my-next, so
Reviewed-and-tested-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-15 23:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 22:50 [PATCH 0/5] aliasing ppgtt, advanced things Daniel Vetter
2012-02-15 22:50 ` [PATCH 1/5] drm/i915: split out dma mapping from global gtt bind/unbind functions Daniel Vetter
2012-02-15 22:50 ` [PATCH 2/5] drm/i915: bind objects to the global gtt only when needed Daniel Vetter
2012-02-15 22:50 ` [PATCH 3/5] drm/i915: implement SNB workaround for lazy global gtt Daniel Vetter
2012-02-15 23:10 ` Chris Wilson [this message]
2012-02-15 23:25 ` Daniel Vetter
2012-03-20 20:57 ` Daniel Vetter
2012-02-15 22:50 ` [PATCH 4/5] drm/i915: enable lazy global-gtt binding Daniel Vetter
2012-02-15 22:50 ` [PATCH 5/5] drm/i915: add HAS_ALIASING_PPGTT parameter for userspace Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$3o5bcf@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.