[PATCH] drm/i915: fix mode set on load pipe. (v2)

[PATCH] drm/i915: fix mode set on load pipe. (v2)

[Dave Airlie]

From: Dave Airlie <airlied@redhat.com>

Booted my i965 machine and it started printing the unsupported pixel
format of 0 message (once I added content to it).

Oh looksie here, we pass 0. fix.

v2: compile it.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1efb5fc..c255ff7 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6561,7 +6561,7 @@ intel_framebuffer_create_for_mode(struct drm_device *dev,
 	mode_cmd.height = mode->vdisplay;
 	mode_cmd.pitches[0] = intel_framebuffer_pitch_for_width(mode_cmd.width,
 								bpp);
-	mode_cmd.pixel_format = 0;
+	mode_cmd.pixel_format = drm_mode_legacy_fb_format(bpp, depth);
 
 	return intel_framebuffer_create(dev, &mode_cmd, obj);
 }
-- 
1.7.7.6

Re: [PATCH] drm/i915: fix mode set on load pipe. (v2)

[Eugeni Dodonov]

[-- Attachment #1.1: Type: text/plain, Size: 471 bytes --]

On Thu, Feb 23, 2012 at 13:33, Dave Airlie <airlied@gmail.com> wrote:

> From: Dave Airlie <airlied@redhat.com>
>
> Booted my i965 machine and it started printing the unsupported pixel
> format of 0 message (once I added content to it).
>
> Oh looksie here, we pass 0. fix.
>

We already have patch1 in drm-intel-fixes I think.

And as for Patch2, I guess it should fix
https://bugs.freedesktop.org/show_bug.cgi?id=46043.

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>

[-- Attachment #1.2: Type: text/html, Size: 888 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix mode set on load pipe. (v2)

[Daniel Vetter]

On Thu, Feb 23, 2012 at 01:54:04PM -0200, Eugeni Dodonov wrote:
> On Thu, Feb 23, 2012 at 13:33, Dave Airlie <airlied@gmail.com> wrote:
> 
> > From: Dave Airlie <airlied@redhat.com>
> >
> > Booted my i965 machine and it started printing the unsupported pixel
> > format of 0 message (once I added content to it).
> >
> > Oh looksie here, we pass 0. fix.
> >
> 
> We already have patch1 in drm-intel-fixes I think.
> 
> And as for Patch2, I guess it should fix
> https://bugs.freedesktop.org/show_bug.cgi?id=46043.

You're missing the real bug reported agains a i965gm here:

https://bugs.freedesktop.org/show_bug.cgi?id=45966

Patch itself is Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

Re: [PATCH] drm/i915: fix mode set on load pipe. (v2)

[Chris Wilson]

On Thu, 23 Feb 2012 15:33:40 +0000, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> Booted my i965 machine and it started printing the unsupported pixel
> format of 0 message (once I added content to it).
> 
> Oh looksie here, we pass 0. fix.
> 
> v2: compile it.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45966
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] drm/i915: fix mode set on load pipe. (v2)

[Jesse Barnes]

[-- Attachment #1.1: Type: text/plain, Size: 760 bytes --]

On Thu, 23 Feb 2012 15:56:52 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Thu, 23 Feb 2012 15:33:40 +0000, Dave Airlie <airlied@gmail.com> wrote:
> > From: Dave Airlie <airlied@redhat.com>
> > 
> > Booted my i965 machine and it started printing the unsupported pixel
> > format of 0 message (once I added content to it).
> > 
> > Oh looksie here, we pass 0. fix.
> > 
> > v2: compile it.
> > 
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45966
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed to drm-intel-fixes, thanks.  We actually caught this bug last
week, but I never merged the fix...

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx