* [KJ] [PATCH 2.6.12-rc3] Supress warning caused by label being
@ 2005-05-19 5:56 Travis Spencer
2005-05-19 15:01 ` Travis Spencer
0 siblings, 1 reply; 2+ messages in thread
From: Travis Spencer @ 2005-05-19 5:56 UTC (permalink / raw)
To: kernel-janitors
When the macro `__ISAPNP__' is undefined, the label `ready' is defined
but the only corresponding goto statement isn't . This results in a
warning from the compiler. To avoid this message, a `goto ready'
statement is added _just_ above the label. Thus, when `__ISAPNP__'
isn't defined, the newly added `goto ready' is a noop and the compiler
is quiet.
Signed-off-by: Travis L. Spencer <tspencer@cs.pdx.edu>
--- drivers/isdn/hisax/diva.c~ 2005-05-18 22:34:44.074178000 -0700
+++ drivers/isdn/hisax/diva.c 2005-05-18 22:33:26.745944000 -0700
@@ -1101,6 +1101,7 @@ setup_diva(struct IsdnCard *card)
bytecnt = 32;
}
}
+ goto ready; /* Assure that `ready' is used even if `__ISAPNP__' isn't. */
ready:
printk(KERN_INFO
"Diva: %s card configured at %#lx IRQ %d\n",
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* [KJ] [PATCH 2.6.12-rc3] Supress warning caused by label being
2005-05-19 5:56 [KJ] [PATCH 2.6.12-rc3] Supress warning caused by label being Travis Spencer
@ 2005-05-19 15:01 ` Travis Spencer
0 siblings, 0 replies; 2+ messages in thread
From: Travis Spencer @ 2005-05-19 15:01 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
When the macro `__ISAPNP__' is undefined, the label `ready' is defined
but the only corresponding goto statement isn't . This results in a
warning from the compiler. To avoid this message, a `goto ready'
statement is added _just_ above the label. Thus, when `__ISAPNP__'
isn't defined, the newly added `goto ready' is a noop and the compiler
is quiet.
Signed-off-by: Travis L. Spencer <tspencer@cs.pdx.edu>
--- a/drivers/isdn/hisax/diva.c~ 2005-05-18 22:34:44.074178000 -0700
+++ b/drivers/isdn/hisax/diva.c 2005-05-18 22:33:26.745944000 -0700
@@ -1101,6 +1101,7 @@ setup_diva(struct IsdnCard *card)
bytecnt = 32;
}
}
+ goto ready; /* Assure that `ready' is used even if `__ISAPNP__' isn't. */
ready:
printk(KERN_INFO
"Diva: %s card configured at %#lx IRQ %d\n",
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-19 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-19 5:56 [KJ] [PATCH 2.6.12-rc3] Supress warning caused by label being Travis Spencer
2005-05-19 15:01 ` Travis Spencer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.