From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Clayton <stillcompiling@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Russell King <linux@armlinux.org.uk>,
Jean Delvare <jdelvare@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [RCF 1/3] hwmon: Add ads1118 driver
Date: Sat, 23 Jul 2016 08:02:01 +0200 [thread overview]
Message-ID: <e3e67d8f-9a48-e1ed-c26f-554cb190a0ae@kernel.org> (raw)
In-Reply-To: <5792301A.6030206@gmail.com>
On 22/07/16 16:39, Joshua Clayton wrote:
> Greetings Guenter,
>
> Thank you for reviewing my submission.
>
> On 07/15/2016 06:40 PM, Guenter Roeck wrote:
>> On 07/15/2016 05:18 PM, Joshua Clayton wrote:
>>> Add new driver for Texas Instruments ADS1118 and and ADS1018.
>>> This driver works with ADS1018, because of code borrowed
>>> from asd1015, which is similar, but I can only test ADS1118
>>>
>>
>> Browsing through the datasheet, I think this should probably be implemented
>> as iio driver (and iio already has a driver for ads1015).
>>
>> Jonathan, what do you think ?
>>
>> Thanks,
>> Guenter
>>
> No response from Jonathan as yet, but I am willing to rework the driver when I
> have some time. It might be weeks before I can start, though.
Sorry, made week and I thought I'd have time to get reviews done in evenings
so didn't look at anything last weekend. Catching up on train home this morning.
>
> I am not very familiar with the iio subsystem, (actually had never heard of it before
> receiving your response). Learning it might be beneficial, as it looks like a good fit
> for an in house driver, which I'd like to eventually upstream.
Cool
>
> If an hwmon driver is adequate, I have new patches that address kbuild and endianness
> issues in the first version.
I'd flip it over to IIO. If you keep to just the simple bits it'll end up pretty
simple to do.
>
>
> ~Joshua Clayton
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [RCF 1/3] hwmon: Add ads1118 driver
Date: Sat, 23 Jul 2016 08:02:01 +0200 [thread overview]
Message-ID: <e3e67d8f-9a48-e1ed-c26f-554cb190a0ae@kernel.org> (raw)
In-Reply-To: <5792301A.6030206@gmail.com>
On 22/07/16 16:39, Joshua Clayton wrote:
> Greetings Guenter,
>
> Thank you for reviewing my submission.
>
> On 07/15/2016 06:40 PM, Guenter Roeck wrote:
>> On 07/15/2016 05:18 PM, Joshua Clayton wrote:
>>> Add new driver for Texas Instruments ADS1118 and and ADS1018.
>>> This driver works with ADS1018, because of code borrowed
>>> from asd1015, which is similar, but I can only test ADS1118
>>>
>>
>> Browsing through the datasheet, I think this should probably be implemented
>> as iio driver (and iio already has a driver for ads1015).
>>
>> Jonathan, what do you think ?
>>
>> Thanks,
>> Guenter
>>
> No response from Jonathan as yet, but I am willing to rework the driver when I
> have some time. It might be weeks before I can start, though.
Sorry, made week and I thought I'd have time to get reviews done in evenings
so didn't look at anything last weekend. Catching up on train home this morning.
>
> I am not very familiar with the iio subsystem, (actually had never heard of it before
> receiving your response). Learning it might be beneficial, as it looks like a good fit
> for an in house driver, which I'd like to eventually upstream.
Cool
>
> If an hwmon driver is adequate, I have new patches that address kbuild and endianness
> issues in the first version.
I'd flip it over to IIO. If you keep to just the simple bits it'll end up pretty
simple to do.
>
>
> ~Joshua Clayton
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-07-23 10:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 0:18 [RCF 0/3] hwmon: add driver for TI ADS1118 Joshua Clayton
2016-07-16 0:18 ` Joshua Clayton
2016-07-16 0:18 ` [RCF 1/3] hwmon: Add ads1118 driver Joshua Clayton
2016-07-16 0:18 ` Joshua Clayton
2016-07-16 1:40 ` Guenter Roeck
2016-07-16 1:40 ` Guenter Roeck
2016-07-22 14:39 ` Joshua Clayton
2016-07-22 14:39 ` Joshua Clayton
2016-07-23 1:20 ` ADS1118: hwmon or iio ? [was: Re: [RCF 1/3] hwmon: Add ads1118 driver] Guenter Roeck
2016-07-23 1:20 ` Guenter Roeck
2016-07-23 5:43 ` Jonathan Cameron
2016-07-23 5:43 ` Jonathan Cameron
2016-07-23 6:02 ` Jonathan Cameron [this message]
2016-07-23 6:02 ` [RCF 1/3] hwmon: Add ads1118 driver Jonathan Cameron
2016-07-16 17:22 ` kbuild test robot
2016-07-16 17:22 ` kbuild test robot
2016-07-16 17:22 ` kbuild test robot
2016-07-16 0:18 ` [RCF 2/3] hwmon: Document bindings for ads1118 adc driver Joshua Clayton
2016-07-16 0:18 ` Joshua Clayton
2016-07-17 20:34 ` Rob Herring
2016-07-17 20:34 ` Rob Herring
2016-07-18 12:51 ` Joshua Clayton
2016-07-18 12:51 ` Joshua Clayton
2016-07-16 0:18 ` [RCF 3/3] ARM: imx6q-evi: ads ads1118 support Joshua Clayton
2016-07-16 0:18 ` Joshua Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e67d8f-9a48-e1ed-c26f-554cb190a0ae@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=jdelvare@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.