From: Johannes Berg <johannes@sipsolutions.net>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH v2 1/2] wifi: rtw88: 8822c: Fix reported RX band width
Date: Mon, 22 Jul 2024 12:58:00 +0200 [thread overview]
Message-ID: <e4ff967f72cc2138b9171e81ccadc35488c45559.camel@sipsolutions.net> (raw)
In-Reply-To: <d3267712-e458-4a02-9408-f3d443185207@gmail.com>
On Mon, 2024-07-22 at 13:50 +0300, Bitterblue Smith wrote:
> "iw dev wlp2s0 station dump" shows incorrect rx bitrate:
>
> tx bitrate: 866.7 MBit/s VHT-MCS 9 80MHz short GI VHT-NSS 2
> rx bitrate: 86.7 MBit/s VHT-MCS 9 VHT-NSS 1
>
> This is because the RX band width is calculated incorrectly. Fix the
> calculation according to the phydm_rxsc_2_bw() function from the
> official drivers.
>
> After:
>
> tx bitrate: 866.7 MBit/s VHT-MCS 9 80MHz short GI VHT-NSS 2
> rx bitrate: 390.0 MBit/s VHT-MCS 9 80MHz VHT-NSS 1
>
> It also works correctly with the AP configured for 20 MHz and 40 MHz.
>
> Tested with RTL8822CE.
>
> Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> v2:
> - Use Fixes instead of Cc: stable.
>
For the record, if you want it backported, you really should have
_both_. Having the Fixes: is good, but will not necessarily lead to it
being backported when/where you want it.
johannes
next prev parent reply other threads:[~2024-07-22 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 10:50 [PATCH v2 1/2] wifi: rtw88: 8822c: Fix reported RX band width Bitterblue Smith
2024-07-22 10:58 ` Johannes Berg [this message]
2024-07-22 11:43 ` Bitterblue Smith
2024-07-22 11:46 ` Johannes Berg
2024-07-22 11:01 ` [PATCH v2 2/2] wifi: rtw88: 8703b: " Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4ff967f72cc2138b9171e81ccadc35488c45559.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.