Re: [PATCH] Add Fedora location of DejaVu SANS font

[Nicholas Vinson <nvinson234@gmail.com>]

On 12/6/21 17:25, Robbie Harwood wrote:
> From: fluteze <fluteze@gmail.com>
> 
> In Fedora 35, and possibly earlier, grub would fail to configure with a
> complaint about DejaVu being "not found" even though it was installed.
> The DejaVu sans font search path is updated to reflect the
> distribution's current install path.
> 
> Signed-off-by: Erik Edwards <fluteze@gmail.com>
> [rharwood@redhat.com: slight commit message edits]
> Signed-off-by: Robbie Harwood <rharwood@redhat.com>
> ---
>   configure.ac | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 8d1c81a73..5186eab2c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1725,7 +1725,7 @@ fi
>   
>   if test x"$starfield_excuse" = x; then
>      for ext in pcf pcf.gz bdf bdf.gz ttf ttf.gz; do
> -     for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/truetype/ttf-dejavu /usr/share/fonts/dejavu /usr/share/fonts/truetype; do
> +     for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/truetype/ttf-dejavu /usr/share/fonts/dejavu /usr/share/fonts/truetype /usr/share/fonts/dejavu-sans-fonts; do

Wouldn't it be better to modify configure.ac so the location could be 
passed in instead of having one-off patches for alternate locations? 
Something like --with-dejavu-font=/usr/share/fonts/dejavu-sans-fonts?

>           if test -f "$dir/DejaVuSans.$ext"; then
>             DJVU_FONT_SOURCE="$dir/DejaVuSans.$ext"
>             break 2
>