All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-kernel@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Tejun Heo <tj@kernel.org>,
	Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
	<linux-ide@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: ata: sata-brcm: Describe the NSP IDM registers
Date: Thu, 29 Oct 2026 09:10:17 +0100	[thread overview]
Message-ID: <e5c4ac0a-f5de-42e7-910a-cf2c9c4cabbc@kernel.org> (raw)
In-Reply-To: <20261029-versed-automatic-orangutan-43cfde@quoll>

On 29/10/2026 09:09, Krzysztof Kozlowski wrote:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: brcm,bcm-nsp-ahci
>> +    then:
>> +      properties:
>> +        reg:
>> +          description: AHCI, top control and optional IDM register regions
>> +    else:
>> +      properties:
>> +        reg:
>> +          maxItems: 2
>> +        reg-names:
>> +          maxItems: 2
> 
> Please move entire allOf to the bottom, before "unevaluatedProperties"
> line.

And you already have an if:then: block, so this should be together.

Best regards,
Krzysztof

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-kernel@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
	Niklas Cassel <cassel@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Tejun Heo <tj@kernel.org>,
	Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
	<linux-ide@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: ata: sata-brcm: Describe the NSP IDM registers
Date: Thu, 29 Oct 2026 09:10:17 +0100	[thread overview]
Message-ID: <e5c4ac0a-f5de-42e7-910a-cf2c9c4cabbc@kernel.org> (raw)
In-Reply-To: <20261029-versed-automatic-orangutan-43cfde@quoll>

On 29/10/2026 09:09, Krzysztof Kozlowski wrote:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: brcm,bcm-nsp-ahci
>> +    then:
>> +      properties:
>> +        reg:
>> +          description: AHCI, top control and optional IDM register regions
>> +    else:
>> +      properties:
>> +        reg:
>> +          maxItems: 2
>> +        reg-names:
>> +          maxItems: 2
> 
> Please move entire allOf to the bottom, before "unevaluatedProperties"
> line.

And you already have an if:then: block, so this should be together.

Best regards,
Krzysztof

  reply	other threads:[~2026-10-29  8:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 19:16 [PATCH v3 0/6] Fix SATA support for NSP SoCs Florian Fainelli
2026-10-26 19:16 ` Florian Fainelli
2026-10-26 19:16 ` [PATCH v3 1/6] phy: broadcom: brcm-sata: Keep NSP ports in the shared PCB window Florian Fainelli
2026-10-26 19:16   ` Florian Fainelli
2026-10-26 19:16 ` [PATCH v3 2/6] dt-bindings: ata: sata-brcm: Describe the NSP IDM registers Florian Fainelli
2026-10-26 19:16   ` Florian Fainelli
2026-10-29  8:09   ` Krzysztof Kozlowski
2026-10-29  8:09     ` Krzysztof Kozlowski
2026-10-29  8:10     ` Krzysztof Kozlowski [this message]
2026-10-29  8:10       ` Krzysztof Kozlowski
2026-10-29 17:16       ` Florian Fainelli
2026-10-29 17:16         ` Florian Fainelli
2026-10-29 16:35     ` Florian Fainelli
2026-10-29 16:35       ` Florian Fainelli
2026-10-26 19:16 ` [PATCH v3 3/6] ata: ahci_brcm: Initialize the NSP interface clock and reset Florian Fainelli
2026-10-26 19:16   ` Florian Fainelli
2026-10-26 19:16 ` [PATCH v3 4/6] ARM: dts: broadcom: Add the NSP SATA IDM registers Florian Fainelli
2026-10-26 19:16   ` Florian Fainelli
2026-10-26 19:16 ` [PATCH v3 5/6] ARM: dts: broadcom: Use noncoherent SATA DMA on BCM958625HR Florian Fainelli
2026-10-26 19:16   ` Florian Fainelli
2026-10-26 19:16 ` [PATCH v3 6/6] ARM: dts: broadcom: Enable SATA " Florian Fainelli
2026-10-26 19:16   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5c4ac0a-f5de-42e7-910a-cf2c9c4cabbc@kernel.org \
    --to=krzk@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=cassel@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=tj@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yendapally.reddy@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.