All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@denx.de>
To: Conor Dooley <conor@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	shawnguo@kernel.org, marex@denx.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
Date: Mon, 22 May 2023 08:49:35 -0300	[thread overview]
Message-ID: <e5ec645a717b13cf9b0e11aa59ea5a81@denx.de> (raw)
In-Reply-To: <20230519-floral-diagram-894858b940c1@spud>

Hi Conor,

On 19/05/2023 16:23, Conor Dooley wrote:

>> +  bridge@18:
>> +    type: object
>> +    $ref: /schemas/display/bridge/fsl,ldb.yaml#
>> +    unevaluatedProperties: false
> 
> How come you need to upgrade the additionaProperties: false, and the
> "plain old" $ref is not sufficient?

I am passing unevaluatedProperties: false, not additionaProperties: 
false here,
so I am not sure I understood your comment.

If additionaProperties: false is not present:

$ make dt_binding_check DT_SCHEMA_FILES=fsl,imx6sx-gpr.yaml
   LINT    Documentation/devicetree/bindings
   CHKDT   Documentation/devicetree/bindings/processed-schema.json
/home/fabio/linux-next/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml: 
'oneOf' conditional failed, one must be fixed:
	'unevaluatedProperties' is a required property
	'additionalProperties' is a required property
	hint: Either unevaluatedProperties or additionalProperties must be 
present
	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
   DTEX    
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dts
   DTC_CHK 
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb

So I will keep it like this.

I have taken all of your other feedback into account and will submit a 
v5.

Thanks,

Fabio Estevam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@denx.de>
To: Conor Dooley <conor@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	shawnguo@kernel.org, marex@denx.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
Date: Mon, 22 May 2023 08:49:35 -0300	[thread overview]
Message-ID: <e5ec645a717b13cf9b0e11aa59ea5a81@denx.de> (raw)
In-Reply-To: <20230519-floral-diagram-894858b940c1@spud>

Hi Conor,

On 19/05/2023 16:23, Conor Dooley wrote:

>> +  bridge@18:
>> +    type: object
>> +    $ref: /schemas/display/bridge/fsl,ldb.yaml#
>> +    unevaluatedProperties: false
> 
> How come you need to upgrade the additionaProperties: false, and the
> "plain old" $ref is not sufficient?

I am passing unevaluatedProperties: false, not additionaProperties: 
false here,
so I am not sure I understood your comment.

If additionaProperties: false is not present:

$ make dt_binding_check DT_SCHEMA_FILES=fsl,imx6sx-gpr.yaml
   LINT    Documentation/devicetree/bindings
   CHKDT   Documentation/devicetree/bindings/processed-schema.json
/home/fabio/linux-next/Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.yaml: 
'oneOf' conditional failed, one must be fixed:
	'unevaluatedProperties' is a required property
	'additionalProperties' is a required property
	hint: Either unevaluatedProperties or additionalProperties must be 
present
	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
   DTEX    
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dts
   DTC_CHK 
Documentation/devicetree/bindings/soc/imx/fsl,imx6sx-gpr.example.dtb

So I will keep it like this.

I have taken all of your other feedback into account and will submit a 
v5.

Thanks,

Fabio Estevam

  reply	other threads:[~2023-05-22 11:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 12:52 [PATCH v4 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Fabio Estevam
2023-05-19 12:52 ` Fabio Estevam
2023-05-19 12:52 ` [PATCH v4 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register Fabio Estevam
2023-05-19 12:52   ` Fabio Estevam
2023-05-19 13:24   ` Rob Herring
2023-05-19 13:24     ` Rob Herring
2023-05-19 15:45     ` Fabio Estevam
2023-05-19 15:45       ` Fabio Estevam
2023-05-19 19:23   ` Conor Dooley
2023-05-19 19:23     ` Conor Dooley
2023-05-22 11:49     ` Fabio Estevam [this message]
2023-05-22 11:49       ` Fabio Estevam
2023-05-22 12:07       ` Conor Dooley
2023-05-22 12:07         ` Conor Dooley
2023-05-19 12:52 ` [PATCH v4 3/4] ARM: dts: imx6sx: Add LDB support Fabio Estevam
2023-05-19 12:52   ` Fabio Estevam
2023-05-19 12:52 ` [PATCH v4 4/4] soc: imx: imx6sx-gpr: Introduce a GPR driver Fabio Estevam
2023-05-19 12:52   ` Fabio Estevam
2023-05-20 10:15 ` [PATCH v4 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Conor Dooley
2023-05-20 10:15   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5ec645a717b13cf9b0e11aa59ea5a81@denx.de \
    --to=festevam@denx.de \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.