All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads
@ 2026-09-07 12:24 Dario Binacchi
  2026-09-07 12:24 ` [Buildroot] [PATCH 2/2] package/pocketpy: bump to version 2.2.0 Dario Binacchi
  2026-09-13 16:34 ` [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Julien Olivain via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Dario Binacchi @ 2026-09-07 12:24 UTC (permalink / raw)
  To: buildroot; +Cc: Dario Binacchi

pocketpy enables thread support by default (PK_ENABLE_THREADS=ON) and
then requires Threads from cmake, which fails on toolchains without
thread support:

  CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find Threads (missing: Threads_FOUND)

Thread support is optional, so enable it only when the toolchain
provides threads.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/pocketpy/pocketpy.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/pocketpy/pocketpy.mk b/package/pocketpy/pocketpy.mk
index 23789dd62028..c1ae075d3897 100644
--- a/package/pocketpy/pocketpy.mk
+++ b/package/pocketpy/pocketpy.mk
@@ -12,6 +12,12 @@ POCKETPY_INSTALL_STAGING = YES
 
 POCKETPY_CONF_OPTS = -DPK_BUILD_SHARED_LIB=ON
 
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+POCKETPY_CONF_OPTS += -DPK_ENABLE_THREADS=ON
+else
+POCKETPY_CONF_OPTS += -DPK_ENABLE_THREADS=OFF
+endif
+
 define POCKETPY_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 0755 $(@D)/libpocketpy.so* $(TARGET_DIR)/usr/lib
 endef
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] package/pocketpy: bump to version 2.2.0
  2026-09-07 12:24 [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Dario Binacchi
@ 2026-09-07 12:24 ` Dario Binacchi
  2026-09-13 16:34 ` [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Julien Olivain via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Dario Binacchi @ 2026-09-07 12:24 UTC (permalink / raw)
  To: buildroot; +Cc: Dario Binacchi

Release notes:
https://github.com/pocketpy/pocketpy/releases/tag/v2.2.0

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/pocketpy/pocketpy.hash | 2 +-
 package/pocketpy/pocketpy.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/pocketpy/pocketpy.hash b/package/pocketpy/pocketpy.hash
index d6ba6e5da27c..0c36fc770021 100644
--- a/package/pocketpy/pocketpy.hash
+++ b/package/pocketpy/pocketpy.hash
@@ -1,3 +1,3 @@
 # locally computed
-sha256  2b840e0c87c36ae00100fe892301565d7d905e07e1ce1f69cb4b9fcd65bc82ef  pocketpy-2.1.8.tar.gz
+sha256  c67cb6a1422abe26114219d2e58441cbb3625bae6b25901d5b7f6f46b23ae8b3  pocketpy-2.2.0.tar.gz
 sha256  5ad14c41f26ed1b8c9a0039ae566bc7ce00277aec1634220eae5db2bb8fc54ef  LICENSE
diff --git a/package/pocketpy/pocketpy.mk b/package/pocketpy/pocketpy.mk
index c1ae075d3897..1150a47fc561 100644
--- a/package/pocketpy/pocketpy.mk
+++ b/package/pocketpy/pocketpy.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-POCKETPY_VERSION = 2.1.8
+POCKETPY_VERSION = 2.2.0
 POCKETPY_SITE = $(call github,pocketpy,pocketpy,v$(POCKETPY_VERSION))
 POCKETPY_LICENSE = MIT
 POCKETPY_LICENSE_FILES = LICENSE
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads
  2026-09-07 12:24 [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Dario Binacchi
  2026-09-07 12:24 ` [Buildroot] [PATCH 2/2] package/pocketpy: bump to version 2.2.0 Dario Binacchi
@ 2026-09-13 16:34 ` Julien Olivain via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Olivain via buildroot @ 2026-09-13 16:34 UTC (permalink / raw)
  To: Dario Binacchi; +Cc: buildroot

On 07/09/2026 14:24, Dario Binacchi wrote:
> pocketpy enables thread support by default (PK_ENABLE_THREADS=ON) and
> then requires Threads from cmake, which fails on toolchains without
> thread support:
> 
>   CMake Error at 
> /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 
> (message):
>     Could NOT find Threads (missing: Threads_FOUND)
> 
> Thread support is optional, so enable it only when the toolchain
> provides threads.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-13 16:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-07 12:24 [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Dario Binacchi
2026-09-07 12:24 ` [Buildroot] [PATCH 2/2] package/pocketpy: bump to version 2.2.0 Dario Binacchi
2026-09-13 16:34 ` [Buildroot] [PATCH 1/2] package/pocketpy: fix build without threads Julien Olivain via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.