From: Chao Yu <chao@kernel.org>
To: Matthew Wilcox <willy@infradead.org>, Kairui Song <kasong@tencent.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>, Chris Li <chrisl@kernel.org>,
Neil Brown <neilb@suse.de>, Minchan Kim <minchan@kernel.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Yosry Ahmed <yosryahmed@google.com>,
linux-mm@kvack.org, Barry Song <v-songbaohua@oppo.com>,
"Huang, Ying" <ying.huang@intel.com>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>
Subject: Re: [f2fs-dev] [PATCH v2 3/8] f2fs: drop usage of page_index
Date: Sun, 28 Apr 2024 11:17:37 +0800 [thread overview]
Message-ID: <e635105f-829d-457d-a2ff-4672ec7a42fe@kernel.org> (raw)
In-Reply-To: <Zig9JCrhky9JieRS@casper.infradead.org>
On 2024/4/24 6:58, Matthew Wilcox wrote:
> On Wed, Apr 24, 2024 at 01:03:34AM +0800, Kairui Song wrote:
>> @@ -4086,8 +4086,7 @@ void f2fs_clear_page_cache_dirty_tag(struct page *page)
>> unsigned long flags;
>>
>> xa_lock_irqsave(&mapping->i_pages, flags);
>> - __xa_clear_mark(&mapping->i_pages, page_index(page),
>> - PAGECACHE_TAG_DIRTY);
>> + __xa_clear_mark(&mapping->i_pages, page->index, PAGECACHE_TAG_DIRTY);
>> xa_unlock_irqrestore(&mapping->i_pages, flags);
>> }
>
> I just sent a patch which is going to conflict with this:
>
> https://lore.kernel.org/linux-mm/20240423225552.4113447-3-willy@infradead.org/
>
> Chao Yu, Jaegeuk Kim; what are your plans for converting f2fs to use
Hi Matthew,
I've converted .read_folio and .readahead of f2fs to use folio w/ below patchset,
and let me take a look how to support and enable large folio...
https://lore.kernel.org/linux-f2fs-devel/20240422062417.2421616-1-chao@kernel.org/
Thanks,
> folios? This is getting quite urgent.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Matthew Wilcox <willy@infradead.org>, Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
"Huang, Ying" <ying.huang@intel.com>,
Chris Li <chrisl@kernel.org>, Barry Song <v-songbaohua@oppo.com>,
Ryan Roberts <ryan.roberts@arm.com>, Neil Brown <neilb@suse.de>,
Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
David Hildenbrand <david@redhat.com>,
Yosry Ahmed <yosryahmed@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 3/8] f2fs: drop usage of page_index
Date: Sun, 28 Apr 2024 11:17:37 +0800 [thread overview]
Message-ID: <e635105f-829d-457d-a2ff-4672ec7a42fe@kernel.org> (raw)
In-Reply-To: <Zig9JCrhky9JieRS@casper.infradead.org>
On 2024/4/24 6:58, Matthew Wilcox wrote:
> On Wed, Apr 24, 2024 at 01:03:34AM +0800, Kairui Song wrote:
>> @@ -4086,8 +4086,7 @@ void f2fs_clear_page_cache_dirty_tag(struct page *page)
>> unsigned long flags;
>>
>> xa_lock_irqsave(&mapping->i_pages, flags);
>> - __xa_clear_mark(&mapping->i_pages, page_index(page),
>> - PAGECACHE_TAG_DIRTY);
>> + __xa_clear_mark(&mapping->i_pages, page->index, PAGECACHE_TAG_DIRTY);
>> xa_unlock_irqrestore(&mapping->i_pages, flags);
>> }
>
> I just sent a patch which is going to conflict with this:
>
> https://lore.kernel.org/linux-mm/20240423225552.4113447-3-willy@infradead.org/
>
> Chao Yu, Jaegeuk Kim; what are your plans for converting f2fs to use
Hi Matthew,
I've converted .read_folio and .readahead of f2fs to use folio w/ below patchset,
and let me take a look how to support and enable large folio...
https://lore.kernel.org/linux-f2fs-devel/20240422062417.2421616-1-chao@kernel.org/
Thanks,
> folios? This is getting quite urgent.
next prev parent reply other threads:[~2024-04-28 3:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 17:03 [PATCH v2 0/8] mm/swap: optimize swap cache search space Kairui Song
2024-04-23 17:03 ` [PATCH v2 1/8] NFS: remove nfs_page_lengthg and usage of page_index Kairui Song
2024-04-23 17:03 ` [PATCH v2 2/8] nilfs2: drop " Kairui Song
2024-04-23 18:48 ` Ryusuke Konishi
2024-04-24 1:57 ` Kairui Song
2024-04-23 17:03 ` [f2fs-dev] [PATCH v2 3/8] f2fs: " Kairui Song
2024-04-23 17:03 ` Kairui Song
2024-04-23 22:58 ` [f2fs-dev] " Matthew Wilcox
2024-04-23 22:58 ` Matthew Wilcox
2024-04-28 3:17 ` Chao Yu [this message]
2024-04-28 3:17 ` Chao Yu
2024-04-23 17:03 ` [PATCH v2 4/8] ceph: " Kairui Song
2024-04-24 0:03 ` Xiubo Li
2024-04-23 17:03 ` [PATCH v2 5/8] cifs: drop usage of page_file_offset Kairui Song
2024-04-23 17:03 ` [PATCH v2 6/8] mm/swap: get the swap file offset directly Kairui Song
2024-04-23 17:03 ` [PATCH v2 7/8] mm: drop page_index/page_file_offset and convert swap helpers to use folio Kairui Song
2024-04-24 2:17 ` Huang, Ying
2024-04-24 2:56 ` Kairui Song
2024-04-24 4:05 ` Matthew Wilcox
2024-04-24 6:45 ` Huang, Ying
2024-04-24 8:48 ` Kairui Song
2024-04-23 17:03 ` [PATCH v2 8/8] mm/swap: reduce swap cache search space Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e635105f-829d-457d-a2ff-4672ec7a42fe@kernel.org \
--to=chao@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jaegeuk@kernel.org \
--cc=kasong@tencent.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=neilb@suse.de \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.