From: Javier Martinez Canillas <javierm@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Chen-Yu Tsai <wens@kernel.org>
Subject: Re: [PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver
Date: Wed, 13 Apr 2022 13:03:59 +0200 [thread overview]
Message-ID: <e65378b2-eaba-e3b8-4bd7-0fb87f343d7b@redhat.com> (raw)
In-Reply-To: <Ylap8rTKbXp80Woc@smile.fi.intel.com>
Hello Andy,
On 4/13/22 12:46, Andy Shevchenko wrote:
> On Tue, Apr 12, 2022 at 06:27:28PM +0200, Javier Martinez Canillas wrote:
>> These are declared in the ssd130x-i2c transport driver but the information
>> is not I2C specific, and could be used by other SSD130x transport drivers.
>>
>> Move them to the ssd130x core driver and just set the OF device entries to
>> an ID that could be used to lookup the correct device info from an array.
>>
>> While being there, also move the SSD130X_DATA and SSD130X_COMMAND control
>> bytes. Since even though they are used by the I2C interface, they could
>> also be useful for other transport protocols such as SPI.
>
> ...
>
>> +EXPORT_SYMBOL_GPL(ssd130x_variants);
>
> What I meant is to use EXPORT_SYMBOL_NS_GPL() here. It might require a separate
> patch to move other exports to that namespace first.
>
Oh, I wasn't aware of the namespace aware variant of these. Thanks for
pointing it out! I'll change and use that one instead for v4.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Rob Herring <robh@kernel.org>,
dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
Chen-Yu Tsai <wens@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>
Subject: Re: [PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver
Date: Wed, 13 Apr 2022 13:03:59 +0200 [thread overview]
Message-ID: <e65378b2-eaba-e3b8-4bd7-0fb87f343d7b@redhat.com> (raw)
In-Reply-To: <Ylap8rTKbXp80Woc@smile.fi.intel.com>
Hello Andy,
On 4/13/22 12:46, Andy Shevchenko wrote:
> On Tue, Apr 12, 2022 at 06:27:28PM +0200, Javier Martinez Canillas wrote:
>> These are declared in the ssd130x-i2c transport driver but the information
>> is not I2C specific, and could be used by other SSD130x transport drivers.
>>
>> Move them to the ssd130x core driver and just set the OF device entries to
>> an ID that could be used to lookup the correct device info from an array.
>>
>> While being there, also move the SSD130X_DATA and SSD130X_COMMAND control
>> bytes. Since even though they are used by the I2C interface, they could
>> also be useful for other transport protocols such as SPI.
>
> ...
>
>> +EXPORT_SYMBOL_GPL(ssd130x_variants);
>
> What I meant is to use EXPORT_SYMBOL_NS_GPL() here. It might require a separate
> patch to move other exports to that namespace first.
>
Oh, I wasn't aware of the namespace aware variant of these. Thanks for
pointing it out! I'll change and use that one instead for v4.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-13 11:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 16:27 [PATCH v3 0/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-12 16:27 ` Javier Martinez Canillas
2022-04-12 16:27 ` [PATCH v3 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Javier Martinez Canillas
2022-04-12 16:27 ` Javier Martinez Canillas
2022-04-12 16:27 ` [PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Javier Martinez Canillas
2022-04-12 16:27 ` Javier Martinez Canillas
2022-04-13 8:04 ` Geert Uytterhoeven
2022-04-13 8:04 ` Geert Uytterhoeven
2022-04-13 9:44 ` Javier Martinez Canillas
2022-04-13 9:44 ` Javier Martinez Canillas
2022-04-13 10:38 ` Geert Uytterhoeven
2022-04-13 10:38 ` Geert Uytterhoeven
2022-04-12 16:27 ` [PATCH v3 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones Javier Martinez Canillas
2022-04-12 16:27 ` Javier Martinez Canillas
2022-04-12 16:27 ` [PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Javier Martinez Canillas
2022-04-12 16:27 ` Javier Martinez Canillas
2022-04-13 10:46 ` Andy Shevchenko
2022-04-13 10:46 ` Andy Shevchenko
2022-04-13 11:03 ` Javier Martinez Canillas [this message]
2022-04-13 11:03 ` Javier Martinez Canillas
2022-04-12 16:27 ` [PATCH v3 5/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-12 16:27 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e65378b2-eaba-e3b8-4bd7-0fb87f343d7b@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.