leds-is31fl319x

leds-is31fl319x

[Weber, Thomas]

Hello,
you are listed as module authors for the leds-is31fl319x driver.

Should the color property and the pattern property be functional in this module?

I added this to my device tree

is31fl@64 {
    compatible = "issi,is31fl3199";
    reg = <0x64>;
    #address-cells = <1>;
    #size-cells = <0>;
    pinctrl-names = "default";
    pinctrl-0 = <&pinctrl_is31_sdb>;
    shutdown-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;

    led@1 {
      reg = <1>;
      label = "IND_LED_WH_1";
      color = <LED_COLOR_ID_WHITE>;
      linux,default-trigger = "pattern";
      led-pattern = <0 1000 255 2000>;
    };

    led@2 {
      reg = <2>;
      label = "IND_LED_BU_1";
      color = <LED_COLOR_ID_BLUE>;
    };

But in the rootfs I get this:

root@vsm:/sys/class/leds/IND_LED_BU_1 cat color
white

root@vsm:/sys/class/leds/IND_LED_WH_1 cat trigger
[none] timer heartbeat cpu cpu0 cpu1 cpu2 cpu3 default-on panic mmc2 sbs-2-000b-charging-or-full sbs-2-000b-charging sbs-2-000b-full sbs-2-000b-charging-blink-full-solid rfkill-any rfkill-none bluetooth-power


What am I doing wrong?

Best regards
Thomas

Re: leds-is31fl319x

[H. Nikolaus Schaller]

Hi,

> Am 20.09.2024 um 16:48 schrieb Weber, Thomas <Thomas.Weber@corscience.com>:
> 
> Hello,
> you are listed as module authors for the leds-is31fl319x driver.

Well, it is many years ago that I contributed some code, so I don't
know if others have added or changed features in the meantime.

> 
> Should the color property and the pattern property be functional in this module?

What do you expect to be "functional"?

> 
> I added this to my device tree
> 
> is31fl@64 {
>    compatible = "issi,is31fl3199";
>    reg = <0x64>;
>    #address-cells = <1>;
>    #size-cells = <0>;
>    pinctrl-names = "default";
>    pinctrl-0 = <&pinctrl_is31_sdb>;
>    shutdown-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;
> 
>    led@1 {
>      reg = <1>;
>      label = "IND_LED_WH_1";
>      color = <LED_COLOR_ID_WHITE>;
>      linux,default-trigger = "pattern";
>      led-pattern = <0 1000 255 2000>;
>    };
> 
>    led@2 {
>      reg = <2>;
>      label = "IND_LED_BU_1";
>      color = <LED_COLOR_ID_BLUE>;
>    };
> 
> But in the rootfs I get this:
> 
> root@vsm:/sys/class/leds/IND_LED_BU_1 cat color
> white

Hm. This is not a feature of the driver but the leds core so
I don't know what happens here.

> 
> root@vsm:/sys/class/leds/IND_LED_WH_1 cat trigger
> [none] timer heartbeat cpu cpu0 cpu1 cpu2 cpu3 default-on panic mmc2 sbs-2-000b-charging-or-full sbs-2-000b-charging sbs-2-000b-full sbs-2-000b-charging-blink-full-solid rfkill-any rfkill-none bluetooth-power

It seems as if led-patterns are not handled or limited by a
driver but implemented in ledtrig-pattern.c which sets up a
timer to cycle through the patterns.

So both features are general features of the led subsystem
and not of the driver.

These features may not be included (e.g. CONFIG_LEDS_TRIGGER_PATTERN)
or available in your Linux version.

Hope this helps. BR,
Nikolaus

Re: leds-is31fl319x

[Jacek Anaszewski]

Hi Thomas,

On 9/20/24 16:48, Weber, Thomas wrote:
> Hello,
> you are listed as module authors for the leds-is31fl319x driver.
> 
> Should the color property and the pattern property be functional in this module?
> 
> I added this to my device tree
> 
> is31fl@64 {
>      compatible = "issi,is31fl3199";
>      reg = <0x64>;
>      #address-cells = <1>;
>      #size-cells = <0>;
>      pinctrl-names = "default";
>      pinctrl-0 = <&pinctrl_is31_sdb>;
>      shutdown-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;
> 
>      led@1 {
>        reg = <1>;
>        label = "IND_LED_WH_1";
>        color = <LED_COLOR_ID_WHITE>;
>        linux,default-trigger = "pattern";
>        led-pattern = <0 1000 255 2000>;
>      };
> 
>      led@2 {
>        reg = <2>;
>        label = "IND_LED_BU_1";
>        color = <LED_COLOR_ID_BLUE>;
>      };
> 
> But in the rootfs I get this:
> 
> root@vsm:/sys/class/leds/IND_LED_BU_1 cat color
> white

Are you working with mainline kernel? LED class does not create 'color'
sysfs file AFAICS, but uses that DT property to construct LED class
device name (and in LED class multicolor).

And anyway, this driver does not use
devm_led_classdev_register_ext(), which is required to parse color
property, so the LED class device name is created using what
is provided in 'label' DT property.

> root@vsm:/sys/class/leds/IND_LED_WH_1 cat trigger
> [none] timer heartbeat cpu cpu0 cpu1 cpu2 cpu3 default-on panic mmc2 sbs-2-000b-charging-or-full sbs-2-000b-charging sbs-2-000b-full sbs-2-000b-charging-blink-full-solid rfkill-any rfkill-none bluetooth-power
> 
> 
> What am I doing wrong?

You seem to have LEDS_TRIGGER_PATTERN turned off in kernel config.

> Best regards
> Thomas
> 

-- 
Best regards,
Jacek Anaszewski

AW: leds-is31fl319x

[Weber, Thomas]

Hello Nikolaus,

>These features may not be included (e.g. CONFIG_LEDS_TRIGGER_PATTERN)
>or available in your Linux version.
>
>Hope this helps. BR,
>Nikolaus

The CONFIG_LEDS_TRIGGER_PATTERN was off.

Thanks for your help,
Thomas