* [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
@ 2021-02-01 23:01 Anusha Srivatsa
2021-02-01 23:04 ` Chris Wilson
2021-02-01 23:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Add GuC and HuC support (rev2) Patchwork
0 siblings, 2 replies; 7+ messages in thread
From: Anusha Srivatsa @ 2021-02-01 23:01 UTC (permalink / raw)
To: intel-gfx
Add support to load GuC and HuC firmware for Dg1.
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index 984fa79e0fa7..0e63881674a4 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -48,6 +48,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
* firmware as TGL.
*/
#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \
+ fw_def(DG1, 0, guc_def(dg1, 49, 0, 1), huc_def(dg1, 7, 7, 1)) \
fw_def(ALDERLAKE_S, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(ROCKETLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(TIGERLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
2021-02-01 23:01 [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support Anusha Srivatsa
@ 2021-02-01 23:04 ` Chris Wilson
2021-02-01 23:19 ` Srivatsa, Anusha
2021-02-01 23:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Add GuC and HuC support (rev2) Patchwork
1 sibling, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2021-02-01 23:04 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx
Quoting Anusha Srivatsa (2021-02-01 23:01:33)
> Add support to load GuC and HuC firmware for Dg1.
Do you have the corresponding link for the linux-firmware.git? That is
useful for cross referencing that the target version does exist in the
public repository.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
2021-02-01 23:04 ` Chris Wilson
@ 2021-02-01 23:19 ` Srivatsa, Anusha
2021-02-01 23:22 ` Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Srivatsa, Anusha @ 2021-02-01 23:19 UTC (permalink / raw)
To: Chris Wilson, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Monday, February 1, 2021 3:05 PM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
>
> Quoting Anusha Srivatsa (2021-02-01 23:01:33)
> > Add support to load GuC and HuC firmware for Dg1.
>
> Do you have the corresponding link for the linux-firmware.git? That is
> useful for cross referencing that the target version does exist in the public
> repository.
I am waiting for CI runs before I can propagate it to linux-firmware.git.
Anusha
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
2021-02-01 23:19 ` Srivatsa, Anusha
@ 2021-02-01 23:22 ` Chris Wilson
2021-02-02 0:46 ` Srivatsa, Anusha
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2021-02-01 23:22 UTC (permalink / raw)
To: Srivatsa, Anusha, intel-gfx
Quoting Srivatsa, Anusha (2021-02-01 23:19:40)
>
>
> > -----Original Message-----
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> > Sent: Monday, February 1, 2021 3:05 PM
> > To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> > gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
> >
> > Quoting Anusha Srivatsa (2021-02-01 23:01:33)
> > > Add support to load GuC and HuC firmware for Dg1.
> >
> > Do you have the corresponding link for the linux-firmware.git? That is
> > useful for cross referencing that the target version does exist in the public
> > repository.
>
> I am waiting for CI runs before I can propagate it to linux-firmware.git.
From upstream CI? We don't have guc loading enabled for dg1, or much of
dg1 for that matter. Best we can do is compile check :(
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
2021-02-01 23:22 ` Chris Wilson
@ 2021-02-02 0:46 ` Srivatsa, Anusha
0 siblings, 0 replies; 7+ messages in thread
From: Srivatsa, Anusha @ 2021-02-02 0:46 UTC (permalink / raw)
To: Chris Wilson, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Monday, February 1, 2021 3:22 PM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
>
> Quoting Srivatsa, Anusha (2021-02-01 23:19:40)
> >
> >
> > > -----Original Message-----
> > > From: Chris Wilson <chris@chris-wilson.co.uk>
> > > Sent: Monday, February 1, 2021 3:05 PM
> > > To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> > > gfx@lists.freedesktop.org
> > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC
> > > support
> > >
> > > Quoting Anusha Srivatsa (2021-02-01 23:01:33)
> > > > Add support to load GuC and HuC firmware for Dg1.
> > >
> > > Do you have the corresponding link for the linux-firmware.git? That
> > > is useful for cross referencing that the target version does exist
> > > in the public repository.
> >
> > I am waiting for CI runs before I can propagate it to linux-firmware.git.
>
> From upstream CI? We don't have guc loading enabled for dg1, or much of
> dg1 for that matter. Best we can do is compile check :( -Chris
Totally missed that bit. I will go ahead with propagating PR to linux-firmware first. It might be sometime till we have DG1 working on CI.
Anusha
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Add GuC and HuC support (rev2)
2021-02-01 23:01 [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support Anusha Srivatsa
2021-02-01 23:04 ` Chris Wilson
@ 2021-02-01 23:53 ` Patchwork
1 sibling, 0 replies; 7+ messages in thread
From: Patchwork @ 2021-02-01 23:53 UTC (permalink / raw)
To: Srivatsa, Anusha; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 7778 bytes --]
== Series Details ==
Series: drm/i915/dg1: Add GuC and HuC support (rev2)
URL : https://patchwork.freedesktop.org/series/86482/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9713 -> Patchwork_19557
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19557 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19557, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19557:
### IGT changes ###
#### Possible regressions ####
* igt@gem_huc_copy@huc-copy:
- fi-tgl-y: [PASS][1] -> [SKIP][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-tgl-y/igt@gem_huc_copy@huc-copy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-tgl-y/igt@gem_huc_copy@huc-copy.html
Known issues
------------
Here are the changes found in Patchwork_19557 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#2411] / [i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
* igt@gem_huc_copy@huc-copy:
- fi-cfl-guc: [PASS][5] -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-cfl-guc/igt@gem_huc_copy@huc-copy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-cfl-guc/igt@gem_huc_copy@huc-copy.html
- fi-kbl-guc: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-kbl-guc/igt@gem_huc_copy@huc-copy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-kbl-guc/igt@gem_huc_copy@huc-copy.html
- fi-skl-guc: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-skl-guc/igt@gem_huc_copy@huc-copy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-skl-guc/igt@gem_huc_copy@huc-copy.html
- fi-apl-guc: [PASS][11] -> [SKIP][12] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-apl-guc/igt@gem_huc_copy@huc-copy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-apl-guc/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@hangcheck:
- fi-icl-y: [PASS][13] -> [INCOMPLETE][14] ([i915#2782] / [i915#926])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-icl-y/igt@i915_selftest@live@hangcheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-icl-y/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-apl-guc: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-apl-guc/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-apl-guc: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#533])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-apl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@primary_page_flip:
- fi-apl-guc: NOTRUN -> [SKIP][17] ([fdo#109271]) +26 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-apl-guc/igt@kms_psr@primary_page_flip.html
* igt@vgem_basic@setversion:
- fi-tgl-y: [PASS][18] -> [DMESG-WARN][19] ([i915#402]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-tgl-y/igt@vgem_basic@setversion.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-tgl-y/igt@vgem_basic@setversion.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic:
- fi-tgl-y: [DMESG-WARN][20] ([i915#402]) -> [PASS][21] +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-tgl-y/igt@gem_mmap_gtt@basic.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-tgl-y/igt@gem_mmap_gtt@basic.html
* igt@i915_hangman@error-state-basic:
- fi-apl-guc: [DMESG-WARN][22] ([i915#1610]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-apl-guc/igt@i915_hangman@error-state-basic.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-apl-guc/igt@i915_hangman@error-state-basic.html
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [DMESG-WARN][24] ([i915#203]) -> [PASS][25] +27 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [DMESG-WARN][26] ([i915#1037]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_engines:
- fi-cfl-8109u: [DMESG-WARN][28] -> [PASS][29] +4 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-cfl-8109u/igt@i915_selftest@live@gt_engines.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-cfl-8109u/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@sanitycheck:
- fi-kbl-7500u: [DMESG-WARN][30] ([i915#2605]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9713/fi-kbl-7500u/igt@i915_selftest@live@sanitycheck.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/fi-kbl-7500u/igt@i915_selftest@live@sanitycheck.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#926]: https://gitlab.freedesktop.org/drm/intel/issues/926
Participating hosts (45 -> 39)
------------------------------
Missing (6): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9713 -> Patchwork_19557
CI-20190529: 20190529
CI_DRM_9713: cc7b6cbff2a0a75ad4fe84d055ee1a762f0ce64b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5984: ccfc101419c1e233f87ca509781c5f8e09a2f3ae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19557: 9fda1194e6b2d779578348a0376731049c9d187f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9fda1194e6b2 drm/i915/dg1: Add GuC and HuC support
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19557/index.html
[-- Attachment #1.2: Type: text/html, Size: 9307 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support
@ 2021-01-30 19:40 Anusha Srivatsa
0 siblings, 0 replies; 7+ messages in thread
From: Anusha Srivatsa @ 2021-01-30 19:40 UTC (permalink / raw)
To: intel-gfx
Add support to load GuC and HuC firmware for Dg1.
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index 67b06fde1225..31e24c3a947e 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -47,6 +47,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
* Note that RKL uses the same firmware as TGL.
*/
#define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \
+ fw_def(DG1, 0, guc_def(dg1, 49, 0, 1), huc_def(dg1, 7, 7, 1)) \
fw_def(ROCKETLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(TIGERLAKE, 0, guc_def(tgl, 49, 0, 1), huc_def(tgl, 7, 5, 0)) \
fw_def(JASPERLAKE, 0, guc_def(ehl, 49, 0, 1), huc_def(ehl, 9, 0, 0)) \
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-02 0:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-01 23:01 [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support Anusha Srivatsa
2021-02-01 23:04 ` Chris Wilson
2021-02-01 23:19 ` Srivatsa, Anusha
2021-02-01 23:22 ` Chris Wilson
2021-02-02 0:46 ` Srivatsa, Anusha
2021-02-01 23:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg1: Add GuC and HuC support (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-01-30 19:40 [Intel-gfx] [PATCH] drm/i915/dg1: Add GuC and HuC support Anusha Srivatsa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.