All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_engines: Skip trying to read a non-existent TIMESTAMP
Date: Mon, 10 Jun 2019 12:04:43 +0100	[thread overview]
Message-ID: <e6e9d079-8da7-9cdd-cd72-e78501ea557c@linux.intel.com> (raw)
In-Reply-To: <20190610104654.20130-1-chris@chris-wilson.co.uk>


On 10/06/2019 11:46, Chris Wilson wrote:
> The per-engine TIMESTAMP (at least at the offset I know about) only came
> into being with gen6. So skip the test on older gen as the results are
> garbage.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110874
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_ctx_engines.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
> index 38ea34d21..3ecade417 100644
> --- a/tests/i915/gem_ctx_engines.c
> +++ b/tests/i915/gem_ctx_engines.c
> @@ -419,6 +419,8 @@ static void independent(int i915)
>   	int timeline = sw_sync_timeline_create();
>   	uint32_t last, *map;
>   
> +	igt_require(gen >= 6); /* No per-engine TIMESTAMP on older gen */
> +
>   	{
>   		struct drm_i915_gem_execbuffer2 execbuf = {
>   			.buffers_ptr = to_user_pointer(&results),
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] i915/gem_ctx_engines: Skip trying to read a non-existent TIMESTAMP
Date: Mon, 10 Jun 2019 12:04:43 +0100	[thread overview]
Message-ID: <e6e9d079-8da7-9cdd-cd72-e78501ea557c@linux.intel.com> (raw)
In-Reply-To: <20190610104654.20130-1-chris@chris-wilson.co.uk>


On 10/06/2019 11:46, Chris Wilson wrote:
> The per-engine TIMESTAMP (at least at the offset I know about) only came
> into being with gen6. So skip the test on older gen as the results are
> garbage.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110874
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_ctx_engines.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
> index 38ea34d21..3ecade417 100644
> --- a/tests/i915/gem_ctx_engines.c
> +++ b/tests/i915/gem_ctx_engines.c
> @@ -419,6 +419,8 @@ static void independent(int i915)
>   	int timeline = sw_sync_timeline_create();
>   	uint32_t last, *map;
>   
> +	igt_require(gen >= 6); /* No per-engine TIMESTAMP on older gen */
> +
>   	{
>   		struct drm_i915_gem_execbuffer2 execbuf = {
>   			.buffers_ptr = to_user_pointer(&results),
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-10 11:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 10:46 [igt-dev] [PATCH i-g-t] i915/gem_ctx_engines: Skip trying to read a non-existent TIMESTAMP Chris Wilson
2019-06-10 10:46 ` Chris Wilson
2019-06-10 11:04 ` Tvrtko Ursulin [this message]
2019-06-10 11:04   ` Tvrtko Ursulin
2019-06-10 12:03 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-11  0:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6e9d079-8da7-9cdd-cd72-e78501ea557c@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.