All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Qiu <william.qiu@starfivetech.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-mmc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/3] StarFive's SDIO/eMMC driver support
Date: Fri, 16 Dec 2022 17:26:57 +0800	[thread overview]
Message-ID: <e704e829-e67c-5458-0808-bc652c1e5620@starfivetech.com> (raw)
In-Reply-To: <CAPDyKFoosrm9CSi4s=YSxdg4xqv118wOFUAc5QRcOgtMCiX=DA@mail.gmail.com>



On 2022/12/16 17:22, Ulf Hansson wrote:
> On Fri, 16 Dec 2022 at 03:02, William Qiu <william.qiu@starfivetech.com> wrote:
>>
>>
>>
>> On 2022/12/7 21:17, William Qiu wrote:
>> > Hi,
>> >
>> > This patchset adds initial rudimentary support for the StarFive
>> > designware mobile storage host controller driver. And this driver will
>> > be used in StarFive's visionfive-v2 board. The main purpose of adding
>> > this driver is to accommodate the ultra-high speed mode of eMMC.
>> >
>> > The patch series is based on v6.1-rc5.
>> >
>> > -- William
>> >
>> > William Qiu (3):
>> >   dt-bindings: mmc: Add bindings for StarFive
>> >   mmc: starfive: Add sdio/emmc driver support
>> >   riscv: dts: starfive: Add mmc node
>> >
>> >  .../bindings/mmc/starfive,jh7110-sdio.yaml    |  71 +++++++
>> >  MAINTAINERS                                   |   6 +
>> >  .../jh7110-starfive-visionfive-v2.dts         |  25 +++
>> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  38 ++++
>> >  drivers/mmc/host/Kconfig                      |  10 +
>> >  drivers/mmc/host/Makefile                     |   1 +
>> >  drivers/mmc/host/dw_mmc-starfive.c            | 197 ++++++++++++++++++
>> >  7 files changed, 348 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-sdio.yaml
>> >  create mode 100644 drivers/mmc/host/dw_mmc-starfive.c
>> >
>> > --
>> > 2.34.1
>> >
>>
>> Hi Jaehoon/Ulf,
>>
>> Could you please help to review and provide comments on this patch series?
>> Thank you in advance.
> 
> Hi William,
> 
> Looks like you have received plenty of good comments already and there
> are a lot of things for you to update. That said, I think it makes
> better sense for me to look at the next version instead.
> 

Fine, I'll do that then.

Thanks
William Qiu

>>
>> Best regards,
>> William Qiu
> 
> Kind regards
> Uffe

WARNING: multiple messages have this Message-ID (diff)
From: William Qiu <william.qiu@starfivetech.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-mmc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/3] StarFive's SDIO/eMMC driver support
Date: Fri, 16 Dec 2022 17:26:57 +0800	[thread overview]
Message-ID: <e704e829-e67c-5458-0808-bc652c1e5620@starfivetech.com> (raw)
In-Reply-To: <CAPDyKFoosrm9CSi4s=YSxdg4xqv118wOFUAc5QRcOgtMCiX=DA@mail.gmail.com>



On 2022/12/16 17:22, Ulf Hansson wrote:
> On Fri, 16 Dec 2022 at 03:02, William Qiu <william.qiu@starfivetech.com> wrote:
>>
>>
>>
>> On 2022/12/7 21:17, William Qiu wrote:
>> > Hi,
>> >
>> > This patchset adds initial rudimentary support for the StarFive
>> > designware mobile storage host controller driver. And this driver will
>> > be used in StarFive's visionfive-v2 board. The main purpose of adding
>> > this driver is to accommodate the ultra-high speed mode of eMMC.
>> >
>> > The patch series is based on v6.1-rc5.
>> >
>> > -- William
>> >
>> > William Qiu (3):
>> >   dt-bindings: mmc: Add bindings for StarFive
>> >   mmc: starfive: Add sdio/emmc driver support
>> >   riscv: dts: starfive: Add mmc node
>> >
>> >  .../bindings/mmc/starfive,jh7110-sdio.yaml    |  71 +++++++
>> >  MAINTAINERS                                   |   6 +
>> >  .../jh7110-starfive-visionfive-v2.dts         |  25 +++
>> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      |  38 ++++
>> >  drivers/mmc/host/Kconfig                      |  10 +
>> >  drivers/mmc/host/Makefile                     |   1 +
>> >  drivers/mmc/host/dw_mmc-starfive.c            | 197 ++++++++++++++++++
>> >  7 files changed, 348 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-sdio.yaml
>> >  create mode 100644 drivers/mmc/host/dw_mmc-starfive.c
>> >
>> > --
>> > 2.34.1
>> >
>>
>> Hi Jaehoon/Ulf,
>>
>> Could you please help to review and provide comments on this patch series?
>> Thank you in advance.
> 
> Hi William,
> 
> Looks like you have received plenty of good comments already and there
> are a lot of things for you to update. That said, I think it makes
> better sense for me to look at the next version instead.
> 

Fine, I'll do that then.

Thanks
William Qiu

>>
>> Best regards,
>> William Qiu
> 
> Kind regards
> Uffe

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-12-16  9:27 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 13:17 [PATCH v1 0/3] StarFive's SDIO/eMMC driver support William Qiu
2022-12-07 13:17 ` William Qiu
2022-12-07 13:17 ` [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive William Qiu
2022-12-07 13:17   ` William Qiu
2022-12-07 14:19   ` Rob Herring
2022-12-07 14:19     ` Rob Herring
2022-12-07 14:46     ` Conor Dooley
2022-12-07 14:46       ` Conor Dooley
2022-12-08  8:38       ` William Qiu
2022-12-08  8:38         ` William Qiu
2022-12-08  8:34     ` William Qiu
2022-12-08  8:34       ` William Qiu
2022-12-07 15:13   ` Krzysztof Kozlowski
2022-12-07 15:13     ` Krzysztof Kozlowski
2022-12-08  8:44     ` William Qiu
2022-12-08  8:44       ` William Qiu
2022-12-08  9:01       ` Krzysztof Kozlowski
2022-12-08  9:01         ` Krzysztof Kozlowski
2022-12-08 10:02         ` William Qiu
2022-12-08 10:02           ` William Qiu
2022-12-08 21:13   ` Linus Walleij
2022-12-08 21:13     ` Linus Walleij
2022-12-09 11:18     ` William Qiu
2022-12-09 11:18       ` William Qiu
2022-12-07 13:17 ` [PATCH v1 2/3] mmc: starfive: Add sdio/emmc driver support William Qiu
2022-12-07 13:17   ` William Qiu
2022-12-08 21:09   ` Linus Walleij
2022-12-08 21:09     ` Linus Walleij
2022-12-09 11:26     ` William Qiu
2022-12-09 11:26       ` William Qiu
2023-02-02 11:09     ` William Qiu
2023-02-02 11:09       ` William Qiu
2023-02-02 12:51       ` Linus Walleij
2023-02-02 12:51         ` Linus Walleij
2022-12-13  2:24   ` Shawn Lin
2022-12-13  2:24     ` Shawn Lin
2022-12-13  7:21     ` William Qiu
2022-12-13  7:21       ` William Qiu
2022-12-13  7:33       ` Shawn Lin
2022-12-13  7:33         ` Shawn Lin
2022-12-13  7:38         ` William Qiu
2022-12-13  7:38           ` William Qiu
2022-12-07 13:17 ` [PATCH v1 3/3] riscv: dts: starfive: Add mmc node William Qiu
2022-12-07 13:17   ` William Qiu
2022-12-07 15:14   ` Krzysztof Kozlowski
2022-12-07 15:14     ` Krzysztof Kozlowski
2022-12-07 16:31     ` Conor Dooley
2022-12-07 16:31       ` Conor Dooley
2022-12-08  9:57       ` William Qiu
2022-12-08  9:57         ` William Qiu
2022-12-08  9:46     ` William Qiu
2022-12-08  9:46       ` William Qiu
2022-12-08 21:15   ` Linus Walleij
2022-12-08 21:15     ` Linus Walleij
2022-12-09 11:31     ` William Qiu
2022-12-09 11:31       ` William Qiu
2023-01-16 10:13     ` William Qiu
2023-01-16 10:13       ` William Qiu
2022-12-16  2:02 ` [PATCH v1 0/3] StarFive's SDIO/eMMC driver support William Qiu
2022-12-16  2:02   ` William Qiu
2022-12-16  9:22   ` Ulf Hansson
2022-12-16  9:22     ` Ulf Hansson
2022-12-16  9:26     ` William Qiu [this message]
2022-12-16  9:26       ` William Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e704e829-e67c-5458-0808-bc652c1e5620@starfivetech.com \
    --to=william.qiu@starfivetech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jh80.chung@samsung.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.