All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Wenjie Qi <qwjhust@gmail.com>, jaegeuk@kernel.org
Cc: chao@kernel.org, stable@kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com
Subject: Re: [PATCH v4 2/2] f2fs: protect critical_task_priority updates with s_umount
Date: Tue, 4 Aug 2026 10:56:00 +0800	[thread overview]
Message-ID: <e72b48a0-a90b-4c57-95f6-8df4bdfd2e0d@kernel.org> (raw)
In-Reply-To: <20260804014849.1942326-2-qiwenjie@xiaomi.com>

On 8/4/26 09:48, Wenjie Qi wrote:
> The sysfs store path already takes s_umount for GC thread control
> entries, and ckpt_thread_ioprio is covered as well.
> 
> critical_task_priority also updates checkpoint or GC kthread scheduling
> state, but it is not covered by that serialization. It can race with
> remount or teardown paths that are stopping those threads.
> 
> Protect critical_task_priority sysfs writes with s_umount too.
> 
> Fixes: 52190933c37a ("f2fs: sysfs: introduce critical_task_priority")
> Cc: stable@kernel.org
> Signed-off-by: Wenjie Qi <qiwenjie@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Wenjie Qi <qwjhust@gmail.com>, jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com,
	stable@kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: protect critical_task_priority updates with s_umount
Date: Tue, 4 Aug 2026 10:56:00 +0800	[thread overview]
Message-ID: <e72b48a0-a90b-4c57-95f6-8df4bdfd2e0d@kernel.org> (raw)
In-Reply-To: <20260804014849.1942326-2-qiwenjie@xiaomi.com>

On 8/4/26 09:48, Wenjie Qi wrote:
> The sysfs store path already takes s_umount for GC thread control
> entries, and ckpt_thread_ioprio is covered as well.
> 
> critical_task_priority also updates checkpoint or GC kthread scheduling
> state, but it is not covered by that serialization. It can race with
> remount or teardown paths that are stopping those threads.
> 
> Protect critical_task_priority sysfs writes with s_umount too.
> 
> Fixes: 52190933c37a ("f2fs: sysfs: introduce critical_task_priority")
> Cc: stable@kernel.org
> Signed-off-by: Wenjie Qi <qiwenjie@xiaomi.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2026-08-04  2:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  1:48 [PATCH v4 1/2] f2fs: avoid NULL checkpoint thread access in sysfs Wenjie Qi
2026-08-04  1:48 ` [f2fs-dev] " Wenjie Qi
2026-08-04  1:48 ` [PATCH v4 2/2] f2fs: protect critical_task_priority updates with s_umount Wenjie Qi
2026-08-04  1:48   ` [f2fs-dev] " Wenjie Qi
2026-08-04  2:56   ` Chao Yu [this message]
2026-08-04  2:56     ` Chao Yu via Linux-f2fs-devel
2026-08-04  2:55 ` [PATCH v4 1/2] f2fs: avoid NULL checkpoint thread access in sysfs Chao Yu
2026-08-04  2:55   ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-05 21:20 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-08-05 21:20   ` patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e72b48a0-a90b-4c57-95f6-8df4bdfd2e0d@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiwenjie@xiaomi.com \
    --cc=qwjhust@gmail.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.