All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"CK Hu (胡俊光)" <ck.hu@mediatek.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Rex-BC Chen (陳柏辰)" <Rex-BC.Chen@mediatek.com>
Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195
Date: Fri, 28 Apr 2023 06:45:32 +0000	[thread overview]
Message-ID: <e73d191f334804324dcaef882dfcb30b4e3e3964.camel@mediatek.com> (raw)
In-Reply-To: <17525028-80bb-cd03-fbc9-b8ff65378517@collabora.com>

Hi Angelo,


On Thu, 2023-04-27 at 17:15 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto:
> > Il 12/09/22 03:29, Jason-JH.Lin ha scritto:
> > > Since the gamma_set_common() function for previous SoC,
> > > such as  mt8173 and mt8183, is designed for 9bit-to-10bit
> > > conversion.
> > > mt8195 is using 10bit-to-12bit conversion, which is
> > > not compatible with the previous function.
> > > 
> > > Thus, need to update the function to fit the need of mt8195.
> > 
> > Hello,
> > can you please respin and fix this series on the latest linux-next?
> > 
> > Besides, please test it carefully: as far as I can see, GNOME Night
> > Light
> > (or others) are not working on MT8195 (color temperature/ccorr).
> > As for gamma itself, that's not working either; you can test it
> > with a tool
> > that will create a color profile by applying a new VCGT table,
> > please look
> > at [1] if you need tools.
> > 
> > We can confirm that color correction works on at least MT8192
> > (colord), so
> > it's MT8195 at fault.
> > 
> > [1]: 
> > https://urldefense.com/v3/__https://github.com/zb3/gnome-gamma-tool__;!!CTRNKA9wMg0ARbw!ib5vs_mqKWlyC8VbLNZbc4Fc0-e6dL5Z-OM5pLsVRnQOWAckR6ETV1mRYRkz-5rKB7fdYvY4LrYoHKDlv6jPSKzoC-245JTYaQ$
> > 
> 
> Nevermind. I've actually fixed this code and refactored it a bit as
> well.
> 
> I'll push my own version soon. No action required.
> 
> Regards,
> Angelo
> 

OK~
Thanks for your great help! :)

Regards,
Jason-JH.Lin

WARNING: multiple messages have this Message-ID (diff)
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"CK Hu (胡俊光)" <ck.hu@mediatek.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Rex-BC Chen (陳柏辰)" <Rex-BC.Chen@mediatek.com>
Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195
Date: Fri, 28 Apr 2023 06:45:32 +0000	[thread overview]
Message-ID: <e73d191f334804324dcaef882dfcb30b4e3e3964.camel@mediatek.com> (raw)
In-Reply-To: <17525028-80bb-cd03-fbc9-b8ff65378517@collabora.com>

Hi Angelo,


On Thu, 2023-04-27 at 17:15 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto:
> > Il 12/09/22 03:29, Jason-JH.Lin ha scritto:
> > > Since the gamma_set_common() function for previous SoC,
> > > such as  mt8173 and mt8183, is designed for 9bit-to-10bit
> > > conversion.
> > > mt8195 is using 10bit-to-12bit conversion, which is
> > > not compatible with the previous function.
> > > 
> > > Thus, need to update the function to fit the need of mt8195.
> > 
> > Hello,
> > can you please respin and fix this series on the latest linux-next?
> > 
> > Besides, please test it carefully: as far as I can see, GNOME Night
> > Light
> > (or others) are not working on MT8195 (color temperature/ccorr).
> > As for gamma itself, that's not working either; you can test it
> > with a tool
> > that will create a color profile by applying a new VCGT table,
> > please look
> > at [1] if you need tools.
> > 
> > We can confirm that color correction works on at least MT8192
> > (colord), so
> > it's MT8195 at fault.
> > 
> > [1]: 
> > https://urldefense.com/v3/__https://github.com/zb3/gnome-gamma-tool__;!!CTRNKA9wMg0ARbw!ib5vs_mqKWlyC8VbLNZbc4Fc0-e6dL5Z-OM5pLsVRnQOWAckR6ETV1mRYRkz-5rKB7fdYvY4LrYoHKDlv6jPSKzoC-245JTYaQ$
> > 
> 
> Nevermind. I've actually fixed this code and refactored it a bit as
> well.
> 
> I'll push my own version soon. No action required.
> 
> Regards,
> Angelo
> 

OK~
Thanks for your great help! :)

Regards,
Jason-JH.Lin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"Rex-BC Chen (陳柏辰)" <Rex-BC.Chen@mediatek.com>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195
Date: Fri, 28 Apr 2023 06:45:32 +0000	[thread overview]
Message-ID: <e73d191f334804324dcaef882dfcb30b4e3e3964.camel@mediatek.com> (raw)
In-Reply-To: <17525028-80bb-cd03-fbc9-b8ff65378517@collabora.com>

[-- Attachment #1: Type: text/html, Size: 3875 bytes --]

[-- Attachment #2: Type: text/plain, Size: 1680 bytes --]

Hi Angelo,


On Thu, 2023-04-27 at 17:15 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto:
> > Il 12/09/22 03:29, Jason-JH.Lin ha scritto:
> > > Since the gamma_set_common() function for previous SoC,
> > > such as  mt8173 and mt8183, is designed for 9bit-to-10bit
> > > conversion.
> > > mt8195 is using 10bit-to-12bit conversion, which is
> > > not compatible with the previous function.
> > > 
> > > Thus, need to update the function to fit the need of mt8195.
> > 
> > Hello,
> > can you please respin and fix this series on the latest linux-next?
> > 
> > Besides, please test it carefully: as far as I can see, GNOME Night
> > Light
> > (or others) are not working on MT8195 (color temperature/ccorr).
> > As for gamma itself, that's not working either; you can test it
> > with a tool
> > that will create a color profile by applying a new VCGT table,
> > please look
> > at [1] if you need tools.
> > 
> > We can confirm that color correction works on at least MT8192
> > (colord), so
> > it's MT8195 at fault.
> > 
> > [1]: 
> > https://urldefense.com/v3/__https://github.com/zb3/gnome-gamma-tool__;!!CTRNKA9wMg0ARbw!ib5vs_mqKWlyC8VbLNZbc4Fc0-e6dL5Z-OM5pLsVRnQOWAckR6ETV1mRYRkz-5rKB7fdYvY4LrYoHKDlv6jPSKzoC-245JTYaQ$
> > 
> 
> Nevermind. I've actually fixed this code and refactored it a bit as
> well.
> 
> I'll push my own version soon. No action required.
> 
> Regards,
> Angelo
> 

OK~
Thanks for your great help! :)

Regards,
Jason-JH.Lin

  reply	other threads:[~2023-04-28  6:46 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12  1:29 [PATCH RESEND v3 0/9] Add gamma lut support for mt8195 Jason-JH.Lin
2022-09-12  1:29 ` Jason-JH.Lin
2022-09-12  1:29 ` Jason-JH.Lin
2022-09-12  1:29 ` [PATCH RESEND v3 1/9] dt-bindings: mediatek: modify item formatting for gamma Jason-JH.Lin
2022-09-12  1:29   ` Jason-JH.Lin
2022-09-12  1:29   ` Jason-JH.Lin
2022-09-18  9:59   ` Krzysztof Kozlowski
2022-09-18  9:59     ` Krzysztof Kozlowski
2022-09-18  9:59     ` Krzysztof Kozlowski
2022-09-12  1:29 ` [PATCH RESEND v3 2/9] dt-bindings: mediatek: Add gamma compatible for mt8195 Jason-JH.Lin
2022-09-12  1:29   ` Jason-JH.Lin
2022-09-12  1:29   ` Jason-JH.Lin
2022-09-18  9:59   ` Krzysztof Kozlowski
2022-09-18  9:59     ` Krzysztof Kozlowski
2022-09-18  9:59     ` Krzysztof Kozlowski
2022-09-12  1:30 ` [PATCH RESEND v3 3/9] drm/mediatek: Adjust mtk_drm_gamma_set_common parameters Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  2:48   ` CK Hu
2022-09-12  2:48     ` CK Hu
2022-09-12  2:48     ` CK Hu
2022-09-14  1:10     ` Jason-JH Lin
2022-09-14  1:10       ` Jason-JH Lin
2022-09-14  1:10       ` Jason-JH Lin
2022-09-12  1:30 ` [PATCH RESEND v3 4/9] drm/mediatek: Add gamma support different lut_size for other SoC Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  3:14   ` CK Hu
2022-09-12  3:14     ` CK Hu
2022-09-12  3:14     ` CK Hu
2022-09-14  1:14     ` Jason-JH Lin
2022-09-14  1:14       ` Jason-JH Lin
2022-09-14  1:14       ` Jason-JH Lin
2022-09-12  1:30 ` [PATCH RESEND v3 5/9] drm/mediatek: Add gamma support different lut_bits " Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  3:40   ` CK Hu
2022-09-12  3:40     ` CK Hu
2022-09-12  3:40     ` CK Hu
2022-09-14  1:17     ` Jason-JH Lin
2022-09-14  1:17       ` Jason-JH Lin
2022-09-14  1:17       ` Jason-JH Lin
2022-09-12  1:30 ` [PATCH RESEND v3 6/9] drm/mediatek: Add gamma support different bank_size " Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  5:12   ` CK Hu
2022-09-12  5:12     ` CK Hu
2022-09-12  5:12     ` CK Hu
2022-09-14  1:28     ` Jason-JH Lin
2022-09-14  1:28       ` Jason-JH Lin
2022-09-14  1:28       ` Jason-JH Lin
2023-04-26 12:06   ` AngeloGioacchino Del Regno
2023-04-26 12:06     ` AngeloGioacchino Del Regno
2023-04-26 12:06     ` AngeloGioacchino Del Regno
2022-09-12  1:30 ` [PATCH RESEND v3 7/9] drm/mediatek: Add gamma lut support for mt8195 Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12 10:00   ` CK Hu
2022-09-12 10:00     ` CK Hu
2022-09-12 10:00     ` CK Hu
2022-09-14  1:48     ` Jason-JH Lin
2022-09-14  1:48       ` Jason-JH Lin
2022-09-14  1:48       ` Jason-JH Lin
2022-09-12  1:30 ` [PATCH RESEND v3 8/9] drm/mediatek: Add clear RELAY_MODE bit to set gamma Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  2:26   ` CK Hu
2022-09-12  2:26     ` CK Hu
2022-09-12  2:26     ` CK Hu
2022-09-14  1:26     ` Jason-JH Lin
2022-09-14  1:26       ` Jason-JH Lin
2022-09-14  1:26       ` Jason-JH Lin
2022-09-12  1:30 ` [PATCH RESEND v3 9/9] arm64: dts: Modify gamma compatible for mt8195 Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2022-09-12  1:30   ` Jason-JH.Lin
2023-04-26 11:43 ` [PATCH RESEND v3 0/9] Add gamma lut support " AngeloGioacchino Del Regno
2023-04-26 11:43   ` AngeloGioacchino Del Regno
2023-04-26 11:43   ` AngeloGioacchino Del Regno
2023-04-27 15:15   ` AngeloGioacchino Del Regno
2023-04-27 15:15     ` AngeloGioacchino Del Regno
2023-04-27 15:15     ` AngeloGioacchino Del Regno
2023-04-28  6:45     ` Jason-JH Lin (林睿祥) [this message]
2023-04-28  6:45       ` Jason-JH Lin (林睿祥)
2023-04-28  6:45       ` Jason-JH Lin (林睿祥)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e73d191f334804324dcaef882dfcb30b4e3e3964.camel@mediatek.com \
    --to=jason-jh.lin@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=Rex-BC.Chen@mediatek.com \
    --cc=Singo.Chang@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.