All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Kilroy <andrew.kilroy@arm.com>
To: John Garry <john.garry@huawei.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	acme@kernel.org
Cc: Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] perf vendor events: For the Neoverse N2
Date: Tue, 7 Dec 2021 12:13:16 +0000	[thread overview]
Message-ID: <e7aaacd8-7972-6ab9-ff0c-e286bf23993a@arm.com> (raw)
In-Reply-To: <2e1a7a96-4ec6-e1f2-5bd4-133480391053@huawei.com>



On 07/12/2021 09:57, John Garry wrote:
> On 03/12/2021 12:35, Andrew Kilroy wrote:
>> Updates the common and microarch json file to add counters
>> available in the Neoverse N2 chip, but should also apply to other ArmV8
>> and ArmV9 cpus.  Specified in ArmV8 architecture reference manual
>>
>>    https://developer.arm.com/documentation/ddi0487/gb/?lang=en
>>
>> Some of the counters added to armv8-common-and-microarch.json are
>> specified in the ArmV9 architecture reference manual supplement
>> (issue A.a):
>>
>>    https://developer.arm.com/documentation/ddi0608/aa
>>
>> The additional ArmV9 counters are
>>
>>    TRB_WRAP
>>    TRCEXTOUT0
>>    TRCEXTOUT1
>>    TRCEXTOUT2
>>    TRCEXTOUT3
>>    CTI_TRIGOUT4
>>    CTI_TRIGOUT5
>>    CTI_TRIGOUT6
>>    CTI_TRIGOUT7
>>
>> This patch also adds files in pmu-events/arch/arm64/arm/neoverse-n2 for
>> perf list to output the counter names in categories.
>>
>> A subsequent patch renames armv8-common-and-microarch.json and
>> armv8-recommended.json to reflect that counters for armv9 are being
>> added.
> 
> This commentary should be in a cover letter. Please do that.
> 
> And did you consider just adding a armv9-common-and-microarch.json and
> armv9-recommended.json instead of adding to and renaming the v8 version?
> I know that it creates scattered definitions, but we already have that in
> dividing the common and the recommended JSONs.
> 

I considered it, but I wasn't sure what was preferable.  I thought I'd 
get some feedback.  Do you consider the separation important?  Any 
particular reason?


> Thanks,
> John

Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Kilroy <andrew.kilroy@arm.com>
To: John Garry <john.garry@huawei.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	acme@kernel.org
Cc: Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] perf vendor events: For the Neoverse N2
Date: Tue, 7 Dec 2021 12:13:16 +0000	[thread overview]
Message-ID: <e7aaacd8-7972-6ab9-ff0c-e286bf23993a@arm.com> (raw)
In-Reply-To: <2e1a7a96-4ec6-e1f2-5bd4-133480391053@huawei.com>



On 07/12/2021 09:57, John Garry wrote:
> On 03/12/2021 12:35, Andrew Kilroy wrote:
>> Updates the common and microarch json file to add counters
>> available in the Neoverse N2 chip, but should also apply to other ArmV8
>> and ArmV9 cpus.  Specified in ArmV8 architecture reference manual
>>
>>    https://developer.arm.com/documentation/ddi0487/gb/?lang=en
>>
>> Some of the counters added to armv8-common-and-microarch.json are
>> specified in the ArmV9 architecture reference manual supplement
>> (issue A.a):
>>
>>    https://developer.arm.com/documentation/ddi0608/aa
>>
>> The additional ArmV9 counters are
>>
>>    TRB_WRAP
>>    TRCEXTOUT0
>>    TRCEXTOUT1
>>    TRCEXTOUT2
>>    TRCEXTOUT3
>>    CTI_TRIGOUT4
>>    CTI_TRIGOUT5
>>    CTI_TRIGOUT6
>>    CTI_TRIGOUT7
>>
>> This patch also adds files in pmu-events/arch/arm64/arm/neoverse-n2 for
>> perf list to output the counter names in categories.
>>
>> A subsequent patch renames armv8-common-and-microarch.json and
>> armv8-recommended.json to reflect that counters for armv9 are being
>> added.
> 
> This commentary should be in a cover letter. Please do that.
> 
> And did you consider just adding a armv9-common-and-microarch.json and
> armv9-recommended.json instead of adding to and renaming the v8 version?
> I know that it creates scattered definitions, but we already have that in
> dividing the common and the recommended JSONs.
> 

I considered it, but I wasn't sure what was preferable.  I thought I'd 
get some feedback.  Do you consider the separation important?  Any 
particular reason?


> Thanks,
> John

Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-07 12:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 12:35 [PATCH 1/3] perf vendor events: For the Neoverse N2 Andrew Kilroy
2021-12-03 12:35 ` Andrew Kilroy
2021-12-03 12:35 ` [PATCH 2/3] perf vendor events: Fix whitespace Andrew Kilroy
2021-12-03 12:35   ` Andrew Kilroy
2021-12-07  9:36   ` John Garry
2021-12-07  9:36     ` John Garry
2021-12-07 14:47     ` Arnaldo Carvalho de Melo
2021-12-07 14:47       ` Arnaldo Carvalho de Melo
2021-12-03 12:35 ` [PATCH 3/3] perf vendor events: Rename arm64 arch std event files Andrew Kilroy
2021-12-03 12:35   ` Andrew Kilroy
2021-12-07  9:57 ` [PATCH 1/3] perf vendor events: For the Neoverse N2 John Garry
2021-12-07  9:57   ` John Garry
2021-12-07 12:13   ` Andrew Kilroy [this message]
2021-12-07 12:13     ` Andrew Kilroy
2021-12-07 14:49     ` Arnaldo Carvalho de Melo
2021-12-07 14:49       ` Arnaldo Carvalho de Melo
2021-12-08 12:30     ` John Garry
2021-12-08 12:30       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7aaacd8-7972-6ab9-ff0c-e286bf23993a@arm.com \
    --to=andrew.kilroy@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.