From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Yangtao Li <frank.li@vivo.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to check quota inums
Date: Sun, 2 Apr 2023 11:16:31 +0800 [thread overview]
Message-ID: <e896c7ba-defe-6448-5bf2-e7c6c952970d@kernel.org> (raw)
In-Reply-To: <ZAZUHQz1GIpPG4jf@google.com>
On 2023/3/7 4:59, Jaegeuk Kim wrote:
> On 02/23, Yangtao Li wrote:
>> +static inline bool f2fs_check_quota_inum(int type, unsigned long qf_inum)
>> +{
>> + switch (type) {
>> + case USRQUOTA:
>> + return qf_inum == 4;
>> + case GRPQUOTA:
>> + return qf_inum == 5;
>> + case PRJQUOTA:
>> + return qf_inum == 6;
>
> I don't want to make this dependency of the inode numbers.
Actually, mkfs.f2fs allocates qf_inum dynamically, above sanity check
may fail mount()...
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Yangtao Li <frank.li@vivo.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to check quota inums
Date: Sun, 2 Apr 2023 11:16:31 +0800 [thread overview]
Message-ID: <e896c7ba-defe-6448-5bf2-e7c6c952970d@kernel.org> (raw)
In-Reply-To: <ZAZUHQz1GIpPG4jf@google.com>
On 2023/3/7 4:59, Jaegeuk Kim wrote:
> On 02/23, Yangtao Li wrote:
>> +static inline bool f2fs_check_quota_inum(int type, unsigned long qf_inum)
>> +{
>> + switch (type) {
>> + case USRQUOTA:
>> + return qf_inum == 4;
>> + case GRPQUOTA:
>> + return qf_inum == 5;
>> + case PRJQUOTA:
>> + return qf_inum == 6;
>
> I don't want to make this dependency of the inode numbers.
Actually, mkfs.f2fs allocates qf_inum dynamically, above sanity check
may fail mount()...
Thanks,
next prev parent reply other threads:[~2023-04-02 3:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 7:32 [f2fs-dev] [PATCH] f2fs: fix to check quota inums Yangtao Li via Linux-f2fs-devel
2023-02-23 7:32 ` Yangtao Li
2023-03-06 20:59 ` [f2fs-dev] " Jaegeuk Kim
2023-03-06 20:59 ` Jaegeuk Kim
2023-04-02 3:16 ` Chao Yu [this message]
2023-04-02 3:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e896c7ba-defe-6448-5bf2-e7c6c952970d@kernel.org \
--to=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.