All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@nabladev.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-usb@vger.kernel.org, fabrice.gasnier@foss.st.com,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v4 1/4] dt-bindings: usb: generic-ohci: Document ST STM32MP2 SoC compatibles
Date: Mon, 31 Aug 2026 15:02:50 +0200	[thread overview]
Message-ID: <e90c42ab-010a-4038-8973-1bfcb3948c4d@nabladev.com> (raw)
In-Reply-To: <20260831-judicious-incredible-aardvark-baa48a@quoll>

On 8/31/26 11:01 AM, Krzysztof Kozlowski wrote:
> On Fri, Aug 28, 2026 at 05:55:45PM +0200, Marek Vasut wrote:
>>     interrupts:
>> @@ -215,6 +220,22 @@ allOf:
>>           clocks:
>>             minItems: 1
>>             maxItems: 3
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            enum:
>> +              - st,stm32mp23-ohci
>> +              - st,stm32mp25-ohci
>> +    then:
>> +      properties:
>> +        clocs:
> 
> typo

Fixed, thanks.

>> +          minItems: 2
>> +          maxItems: 2
> 
> Instead these two list clocks with description
Like this?

diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml 
b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index 71537d268b075..7a8c3c2318153 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -229,9 +229,10 @@ allOf:
                - st,stm32mp25-ohci
      then:
        properties:
-        clocs:
-          minItems: 2
-          maxItems: 2
+        clocks:
+          items:
+            - description: PHY clock
+            - description: Bus clock

        required:
          - access-controllers


  reply	other threads:[~2026-08-31 14:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 15:55 [PATCH v4 0/4] arm64: dts: st: Add STM32MP2 USB support Marek Vasut
2026-08-28 15:55 ` [PATCH v4 1/4] dt-bindings: usb: generic-ohci: Document ST STM32MP2 SoC compatibles Marek Vasut
2026-08-31  9:01   ` Krzysztof Kozlowski
2026-08-31 13:02     ` Marek Vasut [this message]
2026-08-28 15:55 ` [PATCH v4 2/4] dt-bindings: usb: generic-ehci: " Marek Vasut
2026-08-28 15:55 ` [PATCH v4 3/4] arm64: dts: st: Add USB nodes on stm32mp231 Marek Vasut
2026-08-28 15:55 ` [PATCH v4 4/4] arm64: dts: st: Add USB nodes on stm32mp251 Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e90c42ab-010a-4038-8973-1bfcb3948c4d@nabladev.com \
    --to=marex@nabladev.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.