From: Alexander Lobakin <alobakin@dlink.ru>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Song Liu <songliubraving@fb.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Yoshiki Komachi <komachi.yoshiki@gmail.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Stanislav Fomichev <sdf@google.com>,
Matteo Croce <mcroce@redhat.com>,
Edward Cree <ecree@solarflare.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Sean Wang <sean.wang@mediatek.com>,
Jiri Pirko <jiri@mellanox.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Paul Blakey <paulb@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
Taehee Yoo <ap420073@gmail.com>
Subject: Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support
Date: Mon, 13 Jan 2020 12:25:20 +0300 [thread overview]
Message-ID: <e98ab4764c8a0a90c18bfd49305310fe@dlink.ru> (raw)
In-Reply-To: <20191230171216.GC13569@lunn.ch>
Andrew Lunn wrote 30.12.2019 20:12:
>> I mark this as RFC, and there are the key questions for maintainers,
>> developers, users etc.:
>> - Do we need GRO support for DSA at all?
>
>> - Does this series bring any performance improvements on the
>> affected systems?
>
> Hi Alexander
Hi,
> I think these are the two most important questions. Did you do any
> performance testing for the hardware you have?
Exactly, this are the top questions. I performed lots of tests on
hardware with which I'm working on and had a pretty good boosts
(I didn't mainlined my drivers yet unfortunately).
But this does not mean that GRO would be that nice for all kind of
devices *at all*. That's why I would like to see more test results
on different systems.
> I personally don't have any of the switches you have made
> modifications to, so i cannot test these patches. I might be able to
> add GRO to DSA and EDSA, where i can do some performance testing.
>
> Andrew
Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Lobakin <alobakin@dlink.ru>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Song Liu <songliubraving@fb.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Yoshiki Komachi <komachi.yoshiki@gmail.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Stanislav Fomichev <sdf@google.com>,
Matteo Croce <mcroce@redhat.com>,
Edward Cree <ecree@solarflare.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Sean Wang <sean.wang@mediatek.com>,
Jiri Pirko <jiri@mellanox.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Paul Blakey <paulb@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
Taehee Yoo <ap420073@gmail.com>
Subject: Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support
Date: Mon, 13 Jan 2020 12:25:20 +0300 [thread overview]
Message-ID: <e98ab4764c8a0a90c18bfd49305310fe@dlink.ru> (raw)
In-Reply-To: <20191230171216.GC13569@lunn.ch>
Andrew Lunn wrote 30.12.2019 20:12:
>> I mark this as RFC, and there are the key questions for maintainers,
>> developers, users etc.:
>> - Do we need GRO support for DSA at all?
>
>> - Does this series bring any performance improvements on the
>> affected systems?
>
> Hi Alexander
Hi,
> I think these are the two most important questions. Did you do any
> performance testing for the hardware you have?
Exactly, this are the top questions. I performed lots of tests on
hardware with which I'm working on and had a pretty good boosts
(I didn't mainlined my drivers yet unfortunately).
But this does not mean that GRO would be that nice for all kind of
devices *at all*. That's why I would like to see more test results
on different systems.
> I personally don't have any of the switches you have made
> modifications to, so i cannot test these patches. I might be able to
> add GRO to DSA and EDSA, where i can do some performance testing.
>
> Andrew
Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Lobakin <alobakin@dlink.ru>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Edward Cree <ecree@solarflare.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jiri Pirko <jiri@mellanox.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Taehee Yoo <ap420073@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Stanislav Fomichev <sdf@google.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Song Liu <songliubraving@fb.com>,
Matteo Croce <mcroce@redhat.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Paul Blakey <paulb@mellanox.com>,
Yoshiki Komachi <komachi.yoshiki@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support
Date: Mon, 13 Jan 2020 12:25:20 +0300 [thread overview]
Message-ID: <e98ab4764c8a0a90c18bfd49305310fe@dlink.ru> (raw)
In-Reply-To: <20191230171216.GC13569@lunn.ch>
Andrew Lunn wrote 30.12.2019 20:12:
>> I mark this as RFC, and there are the key questions for maintainers,
>> developers, users etc.:
>> - Do we need GRO support for DSA at all?
>
>> - Does this series bring any performance improvements on the
>> affected systems?
>
> Hi Alexander
Hi,
> I think these are the two most important questions. Did you do any
> performance testing for the hardware you have?
Exactly, this are the top questions. I performed lots of tests on
hardware with which I'm working on and had a pretty good boosts
(I didn't mainlined my drivers yet unfortunately).
But this does not mean that GRO would be that nice for all kind of
devices *at all*. That's why I would like to see more test results
on different systems.
> I personally don't have any of the switches you have made
> modifications to, so i cannot test these patches. I might be able to
> add GRO to DSA and EDSA, where i can do some performance testing.
>
> Andrew
Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
next prev parent reply other threads:[~2020-01-13 9:25 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 14:30 [PATCH RFC net-next 00/20] net: dsa: add GRO support Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 01/19] net: dsa: make .flow_dissect() callback returning void Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 18:11 ` Florian Fainelli
2019-12-30 18:11 ` Florian Fainelli
2019-12-30 18:11 ` Florian Fainelli
2019-12-30 14:30 ` [PATCH RFC net-next 02/19] net: dsa: add GRO support infrastructure Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 03/19] net: dsa: tag_ar9331: add .flow_dissect() callback Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 18:22 ` Florian Fainelli
2019-12-30 18:22 ` Florian Fainelli
2019-12-30 18:22 ` Florian Fainelli
2019-12-30 14:30 ` [PATCH RFC net-next 04/19] net: dsa: tag_ar9331: split out common tag accessors Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 17:18 ` Andrew Lunn
2019-12-30 17:18 ` Andrew Lunn
2019-12-30 17:18 ` Andrew Lunn
2019-12-30 14:30 ` [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 18:20 ` Florian Fainelli
2019-12-30 18:20 ` Florian Fainelli
2019-12-30 18:20 ` Florian Fainelli
2019-12-30 20:36 ` Andrew Lunn
2019-12-30 20:36 ` Andrew Lunn
2019-12-30 20:36 ` Andrew Lunn
2020-01-13 9:21 ` Alexander Lobakin
2020-01-13 9:21 ` Alexander Lobakin
2020-01-13 9:21 ` Alexander Lobakin
2020-01-13 9:42 ` Vladimir Oltean
2020-01-13 9:42 ` Vladimir Oltean
2020-01-13 9:42 ` Vladimir Oltean
2020-01-13 9:46 ` Alexander Lobakin
2020-01-13 9:46 ` Alexander Lobakin
2020-01-13 9:46 ` Alexander Lobakin
2020-01-13 10:28 ` Vladimir Oltean
2020-01-13 10:28 ` Vladimir Oltean
2020-01-13 10:28 ` Vladimir Oltean
2020-01-14 21:56 ` Florian Fainelli
2020-01-14 21:56 ` Florian Fainelli
2020-01-14 21:56 ` Florian Fainelli
2020-01-15 7:38 ` Alexander Lobakin
2020-01-15 7:38 ` Alexander Lobakin
2020-01-15 7:38 ` Alexander Lobakin
2020-01-15 11:29 ` Alexander Lobakin
2020-01-15 11:29 ` Alexander Lobakin
2020-01-15 11:29 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 06/19] net: dsa: tag_gswip: fix typo in tag name Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 17:22 ` Andrew Lunn
2019-12-30 17:22 ` Andrew Lunn
2019-12-30 17:22 ` Andrew Lunn
2020-01-14 21:57 ` Florian Fainelli
2020-01-14 21:57 ` Florian Fainelli
2020-01-14 21:57 ` Florian Fainelli
2020-01-15 7:24 ` Alexander Lobakin
2020-01-15 7:24 ` Alexander Lobakin
2020-01-15 7:24 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 07/19] net: dsa: tag_gswip: switch to bitfield helpers Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 08/19] net: dsa: tag_gswip: add .flow_dissect() callback Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 09/19] net: dsa: tag_gswip: split out common tag accessors Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 10/19] net: dsa: tag_gswip: add GRO callbacks Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 11/19] net: dsa: tag_lan9303: add .flow_dissect() callback Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 12/19] net: dsa: tag_lan9303: split out common tag accessors Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 13/19] net: dsa: tag_lan9303: add GRO callbacks Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 14/19] net: dsa: tag_mtk: split out common tag accessors Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 15/19] net: dsa: tag_mtk: add GRO callbacks Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 16/19] net: dsa: tag_qca: fix doubled Tx statistics Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 17:23 ` Andrew Lunn
2019-12-30 17:23 ` Andrew Lunn
2019-12-30 17:23 ` Andrew Lunn
2020-01-14 21:57 ` Florian Fainelli
2020-01-14 21:57 ` Florian Fainelli
2020-01-14 21:57 ` Florian Fainelli
2019-12-30 14:30 ` [PATCH RFC net-next 17/19] net: dsa: tag_qca: switch to bitfield helpers Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 18/19] net: dsa: tag_qca: split out common tag accessors Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 19/19] net: dsa: tag_qca: add GRO callbacks Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` [PATCH RFC net-next 20/20] net: core: add (unlikely) DSA support in napi_gro_frags() Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 14:30 ` Alexander Lobakin
2019-12-30 17:12 ` [PATCH RFC net-next 00/20] net: dsa: add GRO support Andrew Lunn
2019-12-30 17:12 ` Andrew Lunn
2019-12-30 17:12 ` Andrew Lunn
2020-01-13 9:25 ` Alexander Lobakin [this message]
2020-01-13 9:25 ` Alexander Lobakin
2020-01-13 9:25 ` Alexander Lobakin
2019-12-31 15:32 ` Vladimir Oltean
2019-12-31 15:32 ` Vladimir Oltean
2019-12-31 15:32 ` Vladimir Oltean
2020-01-13 9:30 ` Alexander Lobakin
2020-01-13 9:30 ` Alexander Lobakin
2020-01-13 9:30 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98ab4764c8a0a90c18bfd49305310fe@dlink.ru \
--to=alobakin@dlink.ru \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jakub.kicinski@netronome.com \
--cc=jakub@cloudflare.com \
--cc=jiri@mellanox.com \
--cc=komachi.yoshiki@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@mellanox.com \
--cc=sdf@google.com \
--cc=sean.wang@mediatek.com \
--cc=songliubraving@fb.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.