All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
	linux-arm-kernel@lists.infradead.org, soc@kernel.org,
	linux-serial@vger.kernel.org, sumit.garg@linaro.org
Cc: arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com,
	will@kernel.org, gregkh@linuxfoundation.org,
	jason.wessel@windriver.com, daniel.thompson@linaro.org,
	dianders@chromium.org, linux-kernel@vger.kernel.org,
	kgdb-bugreport@lists.sourceforge.net, peterz@infradead.org
Subject: Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver
Date: Wed, 11 May 2022 08:51:16 +0200	[thread overview]
Message-ID: <e9a112f8-a35b-1df4-0567-9fddf80c8e17@kernel.org> (raw)
In-Reply-To: <20220511062113.2645747-2-hasegawa-hitomi@fujitsu.com>

On 11. 05. 22, 8:21, Hitomi Hasegawa wrote:
> --- /dev/null
> +++ b/drivers/soc/fujitsu/a64fx-diag.c
> @@ -0,0 +1,155 @@
...
> +#define BMC_DIAG_INTERRUPT_STATUS_OFFSET (0x0044)
> +#define BMC_DIAG_INTERRUPT_ENABLE_OFFSET (0x0040)

And I noticed here, I would:
* remove unneeded parentheses
* drop the "_OFFSET" suffix
* just write 8bit values (0x40, 0x44), given they fit
* order them numerically, 0x40 goes first

thanks,
-- 
js
suse labs

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@kernel.org>
To: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
	linux-arm-kernel@lists.infradead.org, soc@kernel.org,
	linux-serial@vger.kernel.org, sumit.garg@linaro.org
Cc: arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com,
	will@kernel.org, gregkh@linuxfoundation.org,
	jason.wessel@windriver.com, daniel.thompson@linaro.org,
	dianders@chromium.org, linux-kernel@vger.kernel.org,
	kgdb-bugreport@lists.sourceforge.net, peterz@infradead.org
Subject: Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver
Date: Wed, 11 May 2022 08:51:16 +0200	[thread overview]
Message-ID: <e9a112f8-a35b-1df4-0567-9fddf80c8e17@kernel.org> (raw)
In-Reply-To: <20220511062113.2645747-2-hasegawa-hitomi@fujitsu.com>

On 11. 05. 22, 8:21, Hitomi Hasegawa wrote:
> --- /dev/null
> +++ b/drivers/soc/fujitsu/a64fx-diag.c
> @@ -0,0 +1,155 @@
...
> +#define BMC_DIAG_INTERRUPT_STATUS_OFFSET (0x0044)
> +#define BMC_DIAG_INTERRUPT_ENABLE_OFFSET (0x0040)

And I noticed here, I would:
* remove unneeded parentheses
* drop the "_OFFSET" suffix
* just write 8bit values (0x40, 0x44), given they fit
* order them numerically, 0x40 goes first

thanks,
-- 
js
suse labs

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-11  6:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  6:21 [PATCH v4 0/1] soc: fujitsu: Add A64FX diagnostic interrupt driver Hitomi Hasegawa
2022-05-11  6:21 ` Hitomi Hasegawa
2022-05-11  6:21 ` [PATCH v4 1/1] " Hitomi Hasegawa
2022-05-11  6:21   ` Hitomi Hasegawa
2022-05-11  6:47   ` Jiri Slaby
2022-05-11  6:47     ` Jiri Slaby
2022-05-17  9:53     ` hasegawa-hitomi
2022-05-17  9:53       ` hasegawa-hitomi
2022-05-11  6:50   ` Greg KH
2022-05-11  6:50     ` Greg KH
2022-05-13 10:13     ` Arnd Bergmann
2022-05-13 10:13       ` Arnd Bergmann
2022-05-17  9:54     ` hasegawa-hitomi
2022-05-17  9:54       ` hasegawa-hitomi
2022-05-11  6:51   ` Jiri Slaby [this message]
2022-05-11  6:51     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9a112f8-a35b-1df4-0567-9fddf80c8e17@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hasegawa-hitomi@fujitsu.com \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=peterz@infradead.org \
    --cc=soc@kernel.org \
    --cc=sumit.garg@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.