All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Stanislav Kinsburskii <skinsburskii@gmail.com>
Cc: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
	airlied@gmail.com, akhilesh@ee.iitb.ac.in, corbet@lwn.net,
	dakr@kernel.org, jgg@ziepe.ca, kees@kernel.org, leon@kernel.org,
	liam@infradead.org, lizhi.hou@amd.com, lyude@redhat.com,
	maarten.lankhorst@linux.intel.com, mamin506@gmail.com,
	mhocko@suse.com, mripard@kernel.org,
	nouveau@lists.freedesktop.org, ogabbay@kernel.org,
	oleg@redhat.com, rppt@kernel.org, shuah@kernel.org,
	simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com,
	tzimmermann@suse.de, vbabka@kernel.org,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 0/4] mm/hmm: Clarify notifier retry state and scope HMM timeouts
Date: Thu, 16 Jul 2026 10:59:56 +0200	[thread overview]
Message-ID: <e9d0ade4-cf87-4e8d-90ec-50ddb5249b24@kernel.org> (raw)
In-Reply-To: <20260715101432.99957d2d33203fafe4af2e1c@linux-foundation.org>

On 7/15/26 19:14, Andrew Morton wrote:
> On Wed, 15 Jul 2026 09:39:37 -0700 Stanislav Kinsburskii <skinsburskii@gmail.com> wrote:
> 
>>>
>>> Please don't do this, this is completely impossible to track for review :)
>>>
>>> mm review is currently very difficult based on volumes, it'll become impossible
>>> to manage if people sound fragments of series.
>>>
>>> Please just resend the whole thing at this point.
>>>
>>
>> Well, I followed the guidance provided by Andrew, and I believe he
>> applied all of the changes, including these, to the `mm` tree.
>>
>> Do you still want me to send v9 under these circumstances?
> 
> Sure, if that's what reviewers prefer.
> 
> This is a bit unfriendly to people who have already reviewed the code. 
> Which is one of the reasons why I respond to a new version with a
> single diff showing reviewers (and the author, and myself) what changed
> since the previous version.

As much as I dislike fixup patches, I tolerate them in reply to the existing series.

But having some random fixup series is just crazy, really.

-- 
Cheers,

David

WARNING: multiple messages have this Message-ID (diff)
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Stanislav Kinsburskii <skinsburskii@gmail.com>
Cc: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
	akhilesh@ee.iitb.ac.in, corbet@lwn.net, dakr@kernel.org,
	jgg@ziepe.ca, kees@kernel.org, leon@kernel.org,
	liam@infradead.org, lizhi.hou@amd.com,
	maarten.lankhorst@linux.intel.com, mamin506@gmail.com,
	mhocko@suse.com, mripard@kernel.org,
	nouveau@lists.freedesktop.org, ogabbay@kernel.org,
	oleg@redhat.com, rppt@kernel.org, shuah@kernel.org,
	simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com,
	vbabka@kernel.org, dri-devel@lists.freedesktop.org,
	linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 0/4] mm/hmm: Clarify notifier retry state and scope HMM timeouts
Date: Thu, 16 Jul 2026 10:59:56 +0200	[thread overview]
Message-ID: <e9d0ade4-cf87-4e8d-90ec-50ddb5249b24@kernel.org> (raw)
In-Reply-To: <20260715101432.99957d2d33203fafe4af2e1c@linux-foundation.org>

On 7/15/26 19:14, Andrew Morton wrote:
> On Wed, 15 Jul 2026 09:39:37 -0700 Stanislav Kinsburskii <skinsburskii@gmail.com> wrote:
> 
>>>
>>> Please don't do this, this is completely impossible to track for review :)
>>>
>>> mm review is currently very difficult based on volumes, it'll become impossible
>>> to manage if people sound fragments of series.
>>>
>>> Please just resend the whole thing at this point.
>>>
>>
>> Well, I followed the guidance provided by Andrew, and I believe he
>> applied all of the changes, including these, to the `mm` tree.
>>
>> Do you still want me to send v9 under these circumstances?
> 
> Sure, if that's what reviewers prefer.
> 
> This is a bit unfriendly to people who have already reviewed the code. 
> Which is one of the reasons why I respond to a new version with a
> single diff showing reviewers (and the author, and myself) what changed
> since the previous version.

As much as I dislike fixup patches, I tolerate them in reply to the existing series.

But having some random fixup series is just crazy, really.

-- 
Cheers,

David

  reply	other threads:[~2026-07-16  9:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 22:21 [PATCH v2 0/4] mm/hmm: Clarify notifier retry state and scope HMM timeouts Stanislav Kinsburskii
2026-07-14 22:21 ` [PATCH v2 1/4] fixup! mm/hmm: add hmm_range_fault_unlocked_timeout() for mmap lock-drop support Stanislav Kinsburskii
2026-07-14 22:34   ` sashiko-bot
2026-07-14 22:21 ` [PATCH v2 2/4] fixup! drm/nouveau: use hmm_range_fault_unlocked_timeout() for SVM faults Stanislav Kinsburskii
2026-07-14 22:21 ` [PATCH v2 3/4] fixup! accel/amdxdna: use hmm_range_fault_unlocked_timeout() for range population Stanislav Kinsburskii
2026-07-14 22:32   ` sashiko-bot
2026-07-14 22:21 ` [PATCH v2 4/4] fixup! drm/gpusvm: use hmm_range_fault_unlocked_timeout() for range faults Stanislav Kinsburskii
2026-07-14 22:59   ` sashiko-bot
2026-07-15 12:41 ` [PATCH v2 0/4] mm/hmm: Clarify notifier retry state and scope HMM timeouts David Hildenbrand (Arm)
2026-07-15 14:42   ` Stanislav Kinsburskii
2026-07-15 14:42     ` Stanislav Kinsburskii
2026-07-15 15:02     ` Jason Gunthorpe
2026-07-15 15:02       ` Jason Gunthorpe
2026-07-15 16:03       ` Lorenzo Stoakes (ARM)
2026-07-15 16:03         ` Lorenzo Stoakes (ARM)
2026-07-15 16:02     ` Lorenzo Stoakes (ARM)
2026-07-15 16:02       ` Lorenzo Stoakes (ARM)
2026-07-15 16:39       ` Stanislav Kinsburskii
2026-07-15 16:39         ` Stanislav Kinsburskii
2026-07-15 17:14         ` Andrew Morton
2026-07-15 17:14           ` Andrew Morton
2026-07-16  8:59           ` David Hildenbrand (Arm) [this message]
2026-07-16  8:59             ` David Hildenbrand (Arm)
2026-07-16  9:12             ` Lorenzo Stoakes (ARM)
2026-07-16  9:12               ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9d0ade4-cf87-4e8d-90ec-50ddb5249b24@kernel.org \
    --to=david@kernel.org \
    --cc=airlied@gmail.com \
    --cc=akhilesh@ee.iitb.ac.in \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jgg@ziepe.ca \
    --cc=kees@kernel.org \
    --cc=leon@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=ljs@kernel.org \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mamin506@gmail.com \
    --cc=mhocko@suse.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ogabbay@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=skinsburskii@gmail.com \
    --cc=surenb@google.com \
    --cc=tzimmermann@suse.de \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.