All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCHv2 8/9] ath10k: Add new api to support TID specific configuration
Date: Wed, 27 Feb 2019 18:13:29 +0530	[thread overview]
Message-ID: <eab54b79f171e76e1e1fe7784e98d8ce@codeaurora.org> (raw)
In-Reply-To: <20190226123058.yu5brtbu4euwbzxx@bars>

Hi Sergey,

>> This patch add ops for set_tid_config to support TID
>> specific configuration. STA information along with the
>> TID config change mask to notify driver that which configuration
>> needs to be applied for this current command.
>> If the STA info not available in the command then the
>> configuration will be applied for all connected stations
>> in the vif. TID specific noack configuration requires
>> aggregation disabled and rate for the data TID packets
>> should be basic rates. So, if the TID already configured
>> with noack policy then driver will ignore the aggregation
>> or TX rate related configuration for the same data TID.
>> In TX rate configuration should be applied with highest
>> preamble configuration(HT rates should not be applied
>> for the station which supports vht rates).
>> 
>> Vif specific TID configuration will be applied for all
>> the connected stations except for the station which
>> already applied with the same configuration for the TID
>> through station specific command. Newly connecting stations
>> will be applied with vif TID configuration which will be stored
>> in ieee80211_vif.
>> 
>> Testing:
>>         * Tested HW: QCA9888
>>         * Tested FW: 10.4-3.5.1-00052
>> 
>> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
>> ---
>>  drivers/net/wireless/ath/ath10k/core.h |   7 +
>>  drivers/net/wireless/ath/ath10k/mac.c  | 602 
>> ++++++++++++++++++++++++++++-----
>>  2 files changed, 529 insertions(+), 80 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/ath/ath10k/core.h 
>> b/drivers/net/wireless/ath/ath10k/core.h
>> index 27ec555..c25c426 100644
>> --- a/drivers/net/wireless/ath/ath10k/core.h
>> +++ b/drivers/net/wireless/ath/ath10k/core.h
>> @@ -82,6 +82,9 @@
>>  /* Default Airtime weight multipler (Tuned for multiclient 
>> performance) */
>>  #define ATH10K_AIRTIME_WEIGHT_MULTIPLIER  4
>> 
>> +#define ATH10K_MAX_RETRY_COUNT 30
>> +#define ATH10K_MAX_TIDS        8
> 
> Is there any reason why you don't use IEEE80211_TID_MAX here ?
> 
Thanks for pointing this one. Somehow I missed it. I will reuse this 
instead ATH10K_MAX_TIDS in the next patchset.

Thanks,
Tamizh.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: johannes@sipsolutions.net, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 8/9] ath10k: Add new api to support TID specific configuration
Date: Wed, 27 Feb 2019 18:13:29 +0530	[thread overview]
Message-ID: <eab54b79f171e76e1e1fe7784e98d8ce@codeaurora.org> (raw)
In-Reply-To: <20190226123058.yu5brtbu4euwbzxx@bars>

Hi Sergey,

>> This patch add ops for set_tid_config to support TID
>> specific configuration. STA information along with the
>> TID config change mask to notify driver that which configuration
>> needs to be applied for this current command.
>> If the STA info not available in the command then the
>> configuration will be applied for all connected stations
>> in the vif. TID specific noack configuration requires
>> aggregation disabled and rate for the data TID packets
>> should be basic rates. So, if the TID already configured
>> with noack policy then driver will ignore the aggregation
>> or TX rate related configuration for the same data TID.
>> In TX rate configuration should be applied with highest
>> preamble configuration(HT rates should not be applied
>> for the station which supports vht rates).
>> 
>> Vif specific TID configuration will be applied for all
>> the connected stations except for the station which
>> already applied with the same configuration for the TID
>> through station specific command. Newly connecting stations
>> will be applied with vif TID configuration which will be stored
>> in ieee80211_vif.
>> 
>> Testing:
>>         * Tested HW: QCA9888
>>         * Tested FW: 10.4-3.5.1-00052
>> 
>> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
>> ---
>>  drivers/net/wireless/ath/ath10k/core.h |   7 +
>>  drivers/net/wireless/ath/ath10k/mac.c  | 602 
>> ++++++++++++++++++++++++++++-----
>>  2 files changed, 529 insertions(+), 80 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/ath/ath10k/core.h 
>> b/drivers/net/wireless/ath/ath10k/core.h
>> index 27ec555..c25c426 100644
>> --- a/drivers/net/wireless/ath/ath10k/core.h
>> +++ b/drivers/net/wireless/ath/ath10k/core.h
>> @@ -82,6 +82,9 @@
>>  /* Default Airtime weight multipler (Tuned for multiclient 
>> performance) */
>>  #define ATH10K_AIRTIME_WEIGHT_MULTIPLIER  4
>> 
>> +#define ATH10K_MAX_RETRY_COUNT 30
>> +#define ATH10K_MAX_TIDS        8
> 
> Is there any reason why you don't use IEEE80211_TID_MAX here ?
> 
Thanks for pointing this one. Somehow I missed it. I will reuse this 
instead ATH10K_MAX_TIDS in the next patchset.

Thanks,
Tamizh.

  reply	other threads:[~2019-02-27 12:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  5:32 [PATCHv2 0/9] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2019-02-22  5:32 ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 1/9] nl80211: New netlink command " Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-26 12:29   ` Sergey Matyukevich
2019-02-26 12:29     ` Sergey Matyukevich
2019-02-27  6:03     ` Tamizh chelvam
2019-02-27  6:03       ` Tamizh chelvam
2019-02-27 10:01       ` Sergey Matyukevich
2019-02-27 10:01         ` Sergey Matyukevich
2019-02-22  5:32 ` [PATCHv2 2/9] nl80211: Add new netlink attribute for TID speicific retry count Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 6/9] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 7/9] ath10k: Add wmi command support for station specific TID config Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 8/9] ath10k: Add new api to support TID specific configuration Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam
2019-02-26 12:31   ` Sergey Matyukevich
2019-02-26 12:31     ` Sergey Matyukevich
2019-02-27 12:43     ` Tamizh chelvam [this message]
2019-02-27 12:43       ` Tamizh chelvam
2019-02-22  5:32 ` [PATCHv2 9/9] ath10k: Add extended TID configuration support Tamizh chelvam
2019-02-22  5:32   ` Tamizh chelvam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eab54b79f171e76e1e1fe7784e98d8ce@codeaurora.org \
    --to=tamizhr@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sergey.matyukevich.os@quantenna.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.