Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module

[subashab@codeaurora.org]

On 2020-03-04 16:24, Taehee Yoo wrote:
> This patchset is to cleanup rmnet module code.
> 
> 1. The first patch is to add module alias
> rmnet module can not be loaded automatically because there is no
> alias name.
> 
> 2. The second patch is to add extack error message code.
> When rmnet netlink command fails, it doesn't print any error message.
> So, users couldn't know the exact reason.
> In order to tell the exact reason to the user, the extack error message
> is used in this patch.
> 
> 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC.
> In the sleepable context, GFP_KERNEL can be used.
> So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC.
> 
> Change log:
>  - v1->v2: change error message in the second patch.
> 
> Taehee Yoo (3):
>   net: rmnet: add missing module alias
>   net: rmnet: print error message when command fails
>   net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC
> 
>  .../ethernet/qualcomm/rmnet/rmnet_config.c    | 36 ++++++++++++-------
>  .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c   | 11 +++---
>  .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h   |  3 +-
>  3 files changed, 32 insertions(+), 18 deletions(-)

For the series:

Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>