From: Krzysztof Kozlowski <krzk@kernel.org>
To: David Heidelberg <david@ixit.cz>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Dzmitry Sankouski <dsankouski@gmail.com>,
Jessica Zhang <jesszhan0024@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Petr Vorel <petr.vorel@gmail.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 06/11] drm/panel: s6e3ha8: Correct the polarity logic within
Date: Tue, 29 Sep 2026 14:26:42 +0200 [thread overview]
Message-ID: <eb8ace3d-3cea-4515-a0ba-bc4af3690c10@kernel.org> (raw)
In-Reply-To: <49805bcc-2456-4f7d-a08a-3ccb7223ea50@ixit.cz>
On 29/09/2026 14:12, David Heidelberg wrote:
>>>>
>>>> OK, I went way too fast, that's correct part. But splitting fix is still
>>>> just confusing. Backporting to stable is a different thing than fixing
>>>> issues.
>>>
>>> Sure, I already droped the previous commit changing it for stable.
>>>
>>> Btw. looking at gpiod_toggle_active_low(), would it make sense to do a series
>>> correcting panel reset logic? I see many panels keep "reset asserted" in the
>>> driver (but ofc not in the reality).
>>
>>
>> To my knowledge it is impossible task to do, without breaking something.
>
> I would do the partial change (only driver, not full DT).
>
> So we end up with drivers having the correct logic with extra 2-line DT quirk
> using gpiod_toggle_active_low() for given compatible.
>
> This could solve people implementing new panel on top of existing DDIC and allow
> them to use the right polarity for new compatible.
New compatibles you can change to the proper polarity - I do not object
this at all. I am referencing only existing DTS and existing bindings,
which you cannot change without having some sort of impact.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-29 12:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 14:01 [PATCH v2 00/11] Pixel 3 XL display panel support David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-24 14:01 ` [PATCH v2 01/11] dt-bindings: display: panel: s6e3ha8: Adjust to reflect the DDIC and panel used David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-29 7:39 ` Krzysztof Kozlowski
2026-09-24 14:01 ` [PATCH v2 02/11] dt-bindings: display: panel: samsung,s6e3ha8: Add AMB630QY01 panel David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-29 7:40 ` Krzysztof Kozlowski
2026-09-24 14:01 ` [PATCH v2 03/11] drm/panel: s6e3ha8: Really assert reset on the failure David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-24 20:00 ` Petr Vorel
2026-09-29 7:43 ` Krzysztof Kozlowski
2026-09-24 14:01 ` [PATCH v2 04/11] drm/panel: s6e3ha8: Introduce AMB577PX01 panel compatible David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-24 14:01 ` [PATCH v2 05/11] drm/panel: s6e3ha8: Prepare for supporting multiple panels David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-24 14:01 ` [PATCH v2 06/11] drm/panel: s6e3ha8: Correct the polarity logic within David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-29 7:45 ` Krzysztof Kozlowski
2026-09-29 9:41 ` David Heidelberg
2026-09-29 9:51 ` Krzysztof Kozlowski
2026-09-29 9:59 ` David Heidelberg
2026-09-29 10:36 ` Krzysztof Kozlowski
2026-09-29 12:12 ` David Heidelberg
2026-09-29 12:26 ` Krzysztof Kozlowski [this message]
2026-09-24 14:01 ` [PATCH v2 07/11] drm/panel: s6e3ha8: Assert reset GPIO in unprepare David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-24 14:01 ` [PATCH v2 08/11] drm/panel: s6e3ha8: add Samsung AMB630QY01 (Google Pixel 3 XL) panel David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-24 14:12 ` sashiko-bot
2026-09-24 14:01 ` [PATCH v2 09/11] arm64: dts: qcom: sdm845-samsung-starqltechn: Update panel compatible David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-29 7:46 ` Krzysztof Kozlowski
2026-09-24 14:01 ` [PATCH v2 10/11] arm64: dts: qcom: sdm845-google: Move panel pins into common David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
2026-09-30 10:39 ` Konrad Dybcio
2026-09-24 14:01 ` [PATCH v2 11/11] arm64: dts: qcom: sdm845-google-crosshatch: Add display panel David Heidelberg via B4 Relay
2026-09-24 14:01 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb8ace3d-3cea-4515-a0ba-bc4af3690c10@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsankouski@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=petr.vorel@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.