[djakov-icc:icc-fixes 5/5] include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used

[djakov-icc:icc-fixes 5/5] include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc.git icc-fixes
head:   65fceba30d6f1e7849048d0b292d3541695403f3
commit: 65fceba30d6f1e7849048d0b292d3541695403f3 [5/5] interconnect: avoid memory allocation when 'icc_bw_lock' is held
config: i386-buildonly-randconfig-001-20250627 (https://download.01.org/0day-ci/archive/20250628/202506280134.bxPIYES0-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250628/202506280134.bxPIYES0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506280134.bxPIYES0-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/soc/tegra/mc.h:12,
                    from drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c:10:
>> include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used [-Wunused-function]
     156 | static int icc_node_set_name(struct icc_node *node, const struct icc_provider *provider, const char *name)
         |            ^~~~~~~~~~~~~~~~~


vim +/icc_node_set_name +156 include/linux/interconnect-provider.h

   155	
 > 156	static int icc_node_set_name(struct icc_node *node, const struct icc_provider *provider, const char *name)
   157	{
   158		return -EOPNOTSUPP;
   159	}
   160	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [djakov-icc:icc-fixes 5/5] include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used

[Johan Hovold]

On Sat, Jun 28, 2025 at 01:56:21AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc.git icc-fixes
> head:   65fceba30d6f1e7849048d0b292d3541695403f3
> commit: 65fceba30d6f1e7849048d0b292d3541695403f3 [5/5] interconnect: avoid memory allocation when 'icc_bw_lock' is held
> config: i386-buildonly-randconfig-001-20250627 (https://download.01.org/0day-ci/archive/20250628/202506280134.bxPIYES0-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250628/202506280134.bxPIYES0-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506280134.bxPIYES0-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/soc/tegra/mc.h:12,
>                     from drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c:10:
> >> include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used [-Wunused-function]
>      156 | static int icc_node_set_name(struct icc_node *node, const struct icc_provider *provider, const char *name)
>          |            ^~~~~~~~~~~~~~~~~
> 
> 
> vim +/icc_node_set_name +156 include/linux/interconnect-provider.h
> 
>    155	
>  > 156	static int icc_node_set_name(struct icc_node *node, const struct icc_provider *provider, const char *name)

Bah, I forgot the inline keyword.

Georgi, can you fix up this commit in your branch, or do you want me to
send an incremental fix for this?

Johan

Re: [djakov-icc:icc-fixes 5/5] include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used

[Georgi Djakov]

On 27.06.25 21:24, Johan Hovold wrote:
> On Sat, Jun 28, 2025 at 01:56:21AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djakov/icc.git icc-fixes
>> head:   65fceba30d6f1e7849048d0b292d3541695403f3
>> commit: 65fceba30d6f1e7849048d0b292d3541695403f3 [5/5] interconnect: avoid memory allocation when 'icc_bw_lock' is held
>> config: i386-buildonly-randconfig-001-20250627 (https://download.01.org/0day-ci/archive/20250628/202506280134.bxPIYES0-lkp@intel.com/config)
>> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250628/202506280134.bxPIYES0-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202506280134.bxPIYES0-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>     In file included from include/soc/tegra/mc.h:12,
>>                      from drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.c:10:
>>>> include/linux/interconnect-provider.h:156:12: warning: 'icc_node_set_name' defined but not used [-Wunused-function]
>>       156 | static int icc_node_set_name(struct icc_node *node, const struct icc_provider *provider, const char *name)
>>           |            ^~~~~~~~~~~~~~~~~
>>
>>
>> vim +/icc_node_set_name +156 include/linux/interconnect-provider.h
>>
>>     155	
>>   > 156	static int icc_node_set_name(struct icc_node *node, const struct icc_provider *provider, const char *name)
> 
> Bah, I forgot the inline keyword.
> 
> Georgi, can you fix up this commit in your branch, or do you want me to
> send an incremental fix for this?

I'll fix it! Big thanks to you guys for working on this patch!

BR,
Georgi