From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Remi Pommarel <repk@triplefau.lt>, netdev@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next] net: bridge: Get SIOCGIFBR/SIOCSIFBR ioctl working in compat mode
Date: Mon, 27 Dec 2021 13:55:51 +0200 [thread overview]
Message-ID: <ec0cd540-e785-3a3a-311f-10f0d7bc7adc@nvidia.com> (raw)
In-Reply-To: <20211224114640.29679-1-repk@triplefau.lt>
On 24/12/2021 13:46, Remi Pommarel wrote:
> In compat mode SIOC{G,S}IFBR ioctls were only supporting
> BRCTL_GET_VERSION returning an artificially version to spur userland
> tool to use SIOCDEVPRIVATE instead. But some userland tools ignore that
> and use SIOC{G,S}IFBR unconditionally as seen with busybox's brctl.
>
> Example of non working 32-bit brctl with CONFIG_COMPAT=y:
> $ brctl show
> brctl: SIOCGIFBR: Invalid argument
>
> Example of fixed 32-bit brctl with CONFIG_COMPAT=y:
> $ brctl show
> bridge name bridge id STP enabled interfaces
> br0
>
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> Co-developed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> net/bridge/br_ioctl.c | 75 ++++++++++++++++++++++++++++---------------
> net/socket.c | 20 ++----------
> 2 files changed, 52 insertions(+), 43 deletions(-)
>
Looks good to me, thanks.
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@nvidia.com>
To: Remi Pommarel <repk@triplefau.lt>, <netdev@vger.kernel.org>
Cc: Roopa Prabhu <roopa@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
<bridge@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: bridge: Get SIOCGIFBR/SIOCSIFBR ioctl working in compat mode
Date: Mon, 27 Dec 2021 13:55:51 +0200 [thread overview]
Message-ID: <ec0cd540-e785-3a3a-311f-10f0d7bc7adc@nvidia.com> (raw)
In-Reply-To: <20211224114640.29679-1-repk@triplefau.lt>
On 24/12/2021 13:46, Remi Pommarel wrote:
> In compat mode SIOC{G,S}IFBR ioctls were only supporting
> BRCTL_GET_VERSION returning an artificially version to spur userland
> tool to use SIOCDEVPRIVATE instead. But some userland tools ignore that
> and use SIOC{G,S}IFBR unconditionally as seen with busybox's brctl.
>
> Example of non working 32-bit brctl with CONFIG_COMPAT=y:
> $ brctl show
> brctl: SIOCGIFBR: Invalid argument
>
> Example of fixed 32-bit brctl with CONFIG_COMPAT=y:
> $ brctl show
> bridge name bridge id STP enabled interfaces
> br0
>
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> Co-developed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> net/bridge/br_ioctl.c | 75 ++++++++++++++++++++++++++++---------------
> net/socket.c | 20 ++----------
> 2 files changed, 52 insertions(+), 43 deletions(-)
>
Looks good to me, thanks.
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
next prev parent reply other threads:[~2021-12-27 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 11:46 [Bridge] [PATCH net-next] net: bridge: Get SIOCGIFBR/SIOCSIFBR ioctl working in compat mode Remi Pommarel
2021-12-24 11:46 ` Remi Pommarel
2021-12-27 11:55 ` Nikolay Aleksandrov [this message]
2021-12-27 11:55 ` Nikolay Aleksandrov
2021-12-27 12:40 ` [Bridge] " patchwork-bot+netdevbpf
2021-12-27 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec0cd540-e785-3a3a-311f-10f0d7bc7adc@nvidia.com \
--to=nikolay@nvidia.com \
--cc=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=repk@triplefau.lt \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.