* [PATCH] Fix irq radix tree remapping typo
@ 2006-08-17 1:59 Benjamin Herrenschmidt
2006-08-17 18:01 ` Steve Fox
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-08-17 1:59 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev list, Manoj Iyer
The code for using the radix tree for reverse mapping of interrupts has
a typo that causes it to create incorrect mappings if the software and
hardware numbers happen to be different. This would, among others, cause
the IDE interrupt to fail on js20's. This fixes it.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Please apply to 2.6.18
Index: linux-work/arch/powerpc/kernel/irq.c
===================================================================
--- linux-work.orig/arch/powerpc/kernel/irq.c 2006-08-17 09:26:19.000000000 +1000
+++ linux-work/arch/powerpc/kernel/irq.c 2006-08-17 11:27:30.000000000 +1000
@@ -693,7 +693,7 @@ unsigned int irq_radix_revmap(struct irq
/* If not there, try to insert it */
virq = irq_find_mapping(host, hwirq);
if (virq != NO_IRQ)
- radix_tree_insert(tree, virq, &irq_map[virq]);
+ radix_tree_insert(tree, hwirq, &irq_map[virq]);
bail:
spin_unlock_irqrestore(&irq_big_lock, flags);
return virq;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix irq radix tree remapping typo
2006-08-17 1:59 [PATCH] Fix irq radix tree remapping typo Benjamin Herrenschmidt
@ 2006-08-17 18:01 ` Steve Fox
0 siblings, 0 replies; 2+ messages in thread
From: Steve Fox @ 2006-08-17 18:01 UTC (permalink / raw)
To: linuxppc-dev
On Thu, 17 Aug 2006 03:59:27 +0200, Benjamin Herrenschmidt wrote:
> The code for using the radix tree for reverse mapping of interrupts has
> a typo that causes it to create incorrect mappings if the software and
> hardware numbers happen to be different. This would, among others, cause
> the IDE interrupt to fail on js20's. This fixes it.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Please apply to 2.6.18
>
> Index: linux-work/arch/powerpc/kernel/irq.c
> ===================================================================
> --- linux-work.orig/arch/powerpc/kernel/irq.c 2006-08-17 09:26:19.000000000 +1000
> +++ linux-work/arch/powerpc/kernel/irq.c 2006-08-17 11:27:30.000000000 +1000
> @@ -693,7 +693,7 @@ unsigned int irq_radix_revmap(struct irq
> /* If not there, try to insert it */
> virq = irq_find_mapping(host, hwirq);
> if (virq != NO_IRQ)
> - radix_tree_insert(tree, virq, &irq_map[virq]);
> + radix_tree_insert(tree, hwirq, &irq_map[virq]);
> bail:
> spin_unlock_irqrestore(&irq_big_lock, flags);
> return virq;
This patch has fixed booting on the machine I originally reported the
issue with. Thanks much.
Acked-by: Steve Fox <drfickle@us.ibm.com>
--
Steve Fox
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-17 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-17 1:59 [PATCH] Fix irq radix tree remapping typo Benjamin Herrenschmidt
2006-08-17 18:01 ` Steve Fox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.