[Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies

[Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies

[Thomas Petazzoni via buildroot]

Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
bump version to 1.3.12") has introduced a gcc 7.x and atomic
dependency, but the Config.in comment dependencies are not correct:

+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+       depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC

Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
dependency in Buildroot, so it should be:

+comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+       depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7

so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
false.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/libxmlsec1/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libxmlsec1/Config.in b/package/libxmlsec1/Config.in
index 782e6ced7c..9270447510 100644
--- a/package/libxmlsec1/Config.in
+++ b/package/libxmlsec1/Config.in
@@ -14,4 +14,5 @@ config BR2_PACKAGE_LIBXMLSEC1
 	  https://github.com/lsh123/xmlsec
 
 comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
-	depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on BR2_TOOLCHAIN_HAS_ATOMIC
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libxmlsec1: fix Config.in comment dependencies

[Julien Olivain via buildroot]

On 09/08/2026 12:31, Thomas Petazzoni via buildroot wrote:
> Commit fef9cad1fe84b4366e705adb03470e12199ffd25 ("package/libxmlsec1:
> bump version to 1.3.12") has introduced a gcc 7.x and atomic
> dependency, but the Config.in comment dependencies are not correct:
> 
> +comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
> +       depends on  !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || 
> !BR2_TOOLCHAIN_HAS_ATOMIC
> 
> Indeed, we treat BR2_TOOLCHAIN_HAS_ATOMIC like an architecture
> dependency in Buildroot, so it should be:
> 
> +comment "libxmlsec1 needs a toolchain w/ gcc >= 7"
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC
> +       depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> 
> so that the comment does NOT show up when BR2_TOOLCHAIN_HAS_ATOMIC is
> false.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot