Re: [OE-core] [poky][PATCH] rootfs: add option to allow delayed postinsts on read-only rootfs

Re: [OE-core] [poky][PATCH] rootfs: add option to allow delayed postinsts on read-only rootfs

[Anton Kachalov]

[-- Attachment #1: Type: text/plain, Size: 2209 bytes --]

Ping on the patch

On Fri, 15 Jan 2021 at 16:43, Anton Kachalov via lists.openembedded.org
<rnouse=google.com@lists.openembedded.org> wrote:

> Example use case in OpenBMC: rootfs is squashfs and the system has either
> overlayfs for whole rootfs or for some parts (e.g. /etc).
>
> This option will allow to create migration one-shot postinsts using
> "pkg_postinst_ontarget_${PN}" routines defined in recipes to fix
> files under upper workdir in overlayfs.
>
> Signed-off-by: Anton D. Kachalov <rnouse@google.com>
> ---
>  meta/classes/image.bbclass | 2 +-
>  meta/lib/oe/rootfs.py      | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 045f4494c8..3239d5cf5e 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -33,7 +33,7 @@ INHIBIT_DEFAULT_DEPS = "1"
>  # IMAGE_FEATURES may contain any available package group
>  IMAGE_FEATURES ?= ""
>  IMAGE_FEATURES[type] = "list"
> -IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs
> stateless-rootfs empty-root-password allow-empty-password allow-root-login
> post-install-logging"
> +IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs
> read-only-rootfs-delayed-postinsts stateless-rootfs empty-root-password
> allow-empty-password allow-root-login post-install-logging"
>
>  # Generate companion debugfs?
>  IMAGE_GEN_DEBUGFS ?= "0"
> diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
> index 4b747dd0f4..249c685dcf 100644
> --- a/meta/lib/oe/rootfs.py
> +++ b/meta/lib/oe/rootfs.py
> @@ -217,6 +217,9 @@ class Rootfs(object, metaclass=ABCMeta):
>              self.progress_reporter.next_stage()
>
>          if bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs",
> +                         True, False, self.d) and \
> +           not bb.utils.contains("IMAGE_FEATURES",
> +                         "read-only-rootfs-delayed-postinsts",
>                           True, False, self.d):
>              delayed_postinsts = self._get_delayed_postinsts()
>              if delayed_postinsts is not None:
> --
> 2.30.0.284.gd98b1dd5eaa7-goog
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2818 bytes --]

Re: [OE-core] [poky][PATCH] rootfs: add option to allow delayed postinsts on read-only rootfs

[Richard Purdie]

On Tue, 2021-01-19 at 12:39 +0100, Anton Kachalov via lists.openembedded.org wrote:
> Ping on the patch

It merged a couple of days ago: 
http://git.yoctoproject.org/cgit.cgi/poky/commit/?h=master-next&id=49c4fdcb884057c0fc713925c8040e36fd26af8d 

?

Cheers,

Richard

Re: [OE-core] [poky][PATCH] rootfs: add option to allow delayed postinsts on read-only rootfs

[Anton Kachalov]

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hi, Richard.

Thanks! I've expected some kind of ack :)

On Tue, 19 Jan 2021 at 13:51, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2021-01-19 at 12:39 +0100, Anton Kachalov via
> lists.openembedded.org wrote:
> > Ping on the patch
>
> It merged a couple of days ago:
>
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?h=master-next&id=49c4fdcb884057c0fc713925c8040e36fd26af8d
>
> ?
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 1043 bytes --]

Re: [OE-core] [poky][PATCH] rootfs: add option to allow delayed postinsts on read-only rootfs

[Richard Purdie]

On Tue, 2021-01-19 at 14:48 +0100, Anton Kachalov wrote:
> Thanks! I've expected some kind of ack :)

That would add a lot of mailing list noise and work for me when its
relatively obvious looking at the git tree! :)

Cheers,

Richard