From: Stephen Boyd <sboyd@kernel.org>
To: "Bjorn Andersson" <andersson@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Dzmitry Sankouski" <dsankouski@gmail.com>,
"Jessica Zhang" <quic_jesszhan@quicinc.com>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
cros-qcom-dts-watchers@chromium.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Dzmitry Sankouski <dsankouski@gmail.com>
Subject: Re: [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring
Date: Fri, 13 Sep 2024 11:56:34 -0700 [thread overview]
Message-ID: <eced45837d63618e5383f5324adfc5c3.sboyd@kernel.org> (raw)
In-Reply-To: <20240913-starqltechn_integration_upstream-v4-2-2d2efd5c5877@gmail.com>
Quoting Dzmitry Sankouski (2024-09-13 08:07:45)
> clk-rcg2.c uses 2 variable names for pre divisor register value:
> pre_div and hid_div.
>
> Replace hid_div with pre_div. Update calc_rate docs to reflect, that
> pre_div is not pure divisor, but a register value, and requires conversion.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
Nak
hid stands for "half-integer divider" from what I recall. Feel free to
document that, but don't rename it.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: "Bjorn Andersson" <andersson@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Dzmitry Sankouski" <dsankouski@gmail.com>,
"Jessica Zhang" <quic_jesszhan@quicinc.com>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
cros-qcom-dts-wat@freedesktop.org, chers@chromium.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Dzmitry Sankouski <dsankouski@gmail.com>
Subject: Re: [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring
Date: Fri, 13 Sep 2024 11:56:34 -0700 [thread overview]
Message-ID: <eced45837d63618e5383f5324adfc5c3.sboyd@kernel.org> (raw)
In-Reply-To: <20240913-starqltechn_integration_upstream-v4-2-2d2efd5c5877@gmail.com>
Quoting Dzmitry Sankouski (2024-09-13 08:07:45)
> clk-rcg2.c uses 2 variable names for pre divisor register value:
> pre_div and hid_div.
>
> Replace hid_div with pre_div. Update calc_rate docs to reflect, that
> pre_div is not pure divisor, but a register value, and requires conversion.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
Nak
hid stands for "half-integer divider" from what I recall. Feel free to
document that, but don't rename it.
next prev parent reply other threads:[~2024-09-13 18:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 15:07 [PATCH v4 00/27] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 01/27] power: supply: add undervoltage health status property Dzmitry Sankouski
2024-09-14 8:38 ` Sebastian Reichel
2024-09-13 15:07 ` [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring Dzmitry Sankouski
2024-09-13 18:56 ` Stephen Boyd [this message]
2024-09-13 18:56 ` Stephen Boyd
2024-09-13 15:07 ` [PATCH v4 03/27] gcc-sdm845: Add general purpose clock ops Dzmitry Sankouski
2024-09-14 4:51 ` kernel test robot
2024-09-14 6:56 ` kernel test robot
2024-09-13 15:07 ` [PATCH v4 04/27] dt-bindings: panel: add Samsung s6e3ha8 Dzmitry Sankouski
2024-09-16 20:08 ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 05/27] dt-bindings: mfd: add maxim,max77705 Dzmitry Sankouski
2024-09-13 16:37 ` Rob Herring (Arm)
2024-09-13 21:55 ` Rob Herring
2024-09-13 15:07 ` [PATCH v4 06/27] dt-bindings: mfd: add samsung,s2dos05 Dzmitry Sankouski
2024-09-16 9:13 ` Krzysztof Kozlowski
2024-09-19 12:50 ` Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 07/27] drm/panel: Add support for S6E3HA8 panel driver Dzmitry Sankouski
2024-09-21 20:34 ` Dmitry Baryshkov
2024-09-13 15:07 ` [PATCH v4 08/27] mfd: max77693: remove unused declarations Dzmitry Sankouski
2024-09-16 9:09 ` Krzysztof Kozlowski
2024-09-18 12:53 ` Dzmitry Sankouski
2024-09-19 7:00 ` Krzysztof Kozlowski
2024-09-19 8:40 ` Dzmitry Sankouski
2024-09-19 10:07 ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 09/27] mfd: Add new driver for MAX77705 PMIC Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 10/27] input: max77693: add max77705 haptic support Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 11/27] power: supply: max77705: Add charger driver for Maxim 77705 Dzmitry Sankouski
2024-09-14 5:12 ` kernel test robot
2024-09-13 15:07 ` [PATCH v4 12/27] power: supply: max77705: Add fuel gauge " Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 13/27] leds: max77705: Add LEDs support Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 14/27] mfd: sec-core: add s2dos05 support Dzmitry Sankouski
2024-09-16 9:09 ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 15/27] regulator: add s2dos05 regulator support Dzmitry Sankouski
2024-09-16 9:21 ` Krzysztof Kozlowski
2024-09-19 14:28 ` Dzmitry Sankouski
2024-09-23 9:07 ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 16/27] arm64: dts: qcom: sdm845: enable gmu Dzmitry Sankouski
2024-09-13 19:02 ` Steev Klimaszewski
2024-09-13 15:08 ` [PATCH v4 17/27] arm64: dts: qcom: starqltechn: remove wifi Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 18/27] arm64: dts: qcom: starqltechn: fix usb regulator mistake Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 19/27] arm64: dts: qcom: starqltechn: refactor node order Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 20/27] arm64: dts: qcom: starqltechn: remove excess reserved gpios Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 21/27] arm64: dts: qcom: starqltechn: add gpio keys Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 22/27] arm64: dts: qcom: starqltechn: add max77705 PMIC Dzmitry Sankouski
2024-09-16 9:17 ` Krzysztof Kozlowski
2024-09-13 15:08 ` [PATCH v4 23/27] arm64: dts: qcom: starqltechn: add display PMIC Dzmitry Sankouski
2024-09-16 9:15 ` Krzysztof Kozlowski
2024-09-19 13:17 ` Dzmitry Sankouski
2024-09-19 14:00 ` Krzysztof Kozlowski
2024-09-13 15:08 ` [PATCH v4 24/27] arm64: dts: qcom: starqltechn: add touchscreen support Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 25/27] arm64: dts: qcom: starqltechn: add initial sound support Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 26/27] arm64: dts: qcom: starqltechn: add graphics support Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 27/27] arm64: dts: qcom: starqltechn: add modem support Dzmitry Sankouski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eced45837d63618e5383f5324adfc5c3.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsankouski@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=pavel@ucw.cz \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=simona.vetter@ffwll.ch \
--cc=simona@ffwll.ch \
--cc=sre@kernel.org \
--cc=tzimmermann@suse.de \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.