* [PATCH] crypto: omap-aes: Fix broken pm_runtime_and_get() usage
@ 2021-12-17 9:03 Heiner Kallweit
2021-12-24 3:26 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2021-12-17 9:03 UTC (permalink / raw)
To: Herbert Xu, David Miller; +Cc: Linux Crypto Mailing List
This fix is basically the same as 3d6b661330a7 ("crypto: stm32 -
Revert broken pm_runtime_resume_and_get changes"), just for the omap
driver. If the return value isn't used, then pm_runtime_get_sync()
has to be used for ensuring that the usage count is balanced.
Fixes: 1f34cc4a8da3 ("crypto: omap-aes - Fix PM reference leak on omap-aes.c")
Cc: stable@vger.kernel.org
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/crypto/omap-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 9b968ac4e..a196bb8b1 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1302,7 +1302,7 @@ static int omap_aes_suspend(struct device *dev)
static int omap_aes_resume(struct device *dev)
{
- pm_runtime_resume_and_get(dev);
+ pm_runtime_get_sync(dev);
return 0;
}
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: omap-aes: Fix broken pm_runtime_and_get() usage
2021-12-17 9:03 [PATCH] crypto: omap-aes: Fix broken pm_runtime_and_get() usage Heiner Kallweit
@ 2021-12-24 3:26 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2021-12-24 3:26 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: David Miller, Linux Crypto Mailing List
On Fri, Dec 17, 2021 at 10:03:30AM +0100, Heiner Kallweit wrote:
> This fix is basically the same as 3d6b661330a7 ("crypto: stm32 -
> Revert broken pm_runtime_resume_and_get changes"), just for the omap
> driver. If the return value isn't used, then pm_runtime_get_sync()
> has to be used for ensuring that the usage count is balanced.
>
> Fixes: 1f34cc4a8da3 ("crypto: omap-aes - Fix PM reference leak on omap-aes.c")
> Cc: stable@vger.kernel.org
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/crypto/omap-aes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-24 3:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 9:03 [PATCH] crypto: omap-aes: Fix broken pm_runtime_and_get() usage Heiner Kallweit
2021-12-24 3:26 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.