From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Liu Ying <victor.liu@nxp.com>
Cc: marex@denx.de, stefan@agner.ch, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
krzysztof.kozlowski@linaro.org, LW@karo-electronics.de
Subject: Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support
Date: Mon, 20 Feb 2023 13:18:59 +0100 [thread overview]
Message-ID: <ed28bbda-16b6-043b-5310-8ac0e8ebd900@prevas.dk> (raw)
In-Reply-To: <13207614.uLZWGnKmhe@steina-w>
On 17/02/2023 09.18, Alexander Stein wrote:
> Hi Liu,
>
> Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying:
>> Hi,
>>
>> This patch set aims to add i.MX93 LCDIF display controller support
>> in the existing LCDIF DRM driver. The LCDIF embedded in i.MX93 SoC
>> is essentially the same to those embedded in i.MX8mp SoC. Through
>> internal bridges, i.MX93 LCDIF may drive a MIPI DSI display or a LVDS
>> display or a parallel display.
>>
>> Patch 1/6 adds device tree binding support for i.MX93 LCDIF in the
>> existing fsl,lcdif.yaml.
>>
>> Patch 2/6 drops lcdif->bridge NULL pointer check as a cleanup patch.
>>
>> Patch 3/6~5/6 prepare for adding i.MX93 LCDIF support step by step.
>>
>> Patch 6/6 adds i.MX93 LCDIF compatible string as the last step of
>> adding i.MX93 LCDIF support.
>
> Thanks for the series. I could test this on my TQMa93xxLA/MBa93xxCA with a
> single LVDS display attached, so no DSI or parallel display. Hence I could not
> test the bus format and flags checks, but they look okay.
> So you can add
> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> to the whole series as well.
>
> One thing I noticed is that, sometimes it seems that before probing lcdif my
> system completely freezes. Adding some debug output it seems that's during
> powering up the IMX93_MEDIABLK_PD_LCDIF power domain there is some race
> condition. But adding more more detailed output made the problem go away.
> Did you notice something similar? It might be a red hering though.
Interesting. Sounds similar to what I encountered on several
imx8mp-based boards, both the NXP EVK and our custom design, running a
mainline U-Boot and downstream NXP kernel:
https://lore.kernel.org/u-boot/20220823133645.4046432-1-rasmus.villemoes@prevas.dk/
I never really found a real solution, but as the hack I ended up
applying in U-Boot does involve some clock settings, and you apparently
now figured out some connection to "overclocking", I do think these
issues are related.
Rasmus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Liu Ying <victor.liu@nxp.com>
Cc: marex@denx.de, stefan@agner.ch, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
krzysztof.kozlowski@linaro.org, LW@karo-electronics.de
Subject: Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support
Date: Mon, 20 Feb 2023 13:18:59 +0100 [thread overview]
Message-ID: <ed28bbda-16b6-043b-5310-8ac0e8ebd900@prevas.dk> (raw)
In-Reply-To: <13207614.uLZWGnKmhe@steina-w>
On 17/02/2023 09.18, Alexander Stein wrote:
> Hi Liu,
>
> Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying:
>> Hi,
>>
>> This patch set aims to add i.MX93 LCDIF display controller support
>> in the existing LCDIF DRM driver. The LCDIF embedded in i.MX93 SoC
>> is essentially the same to those embedded in i.MX8mp SoC. Through
>> internal bridges, i.MX93 LCDIF may drive a MIPI DSI display or a LVDS
>> display or a parallel display.
>>
>> Patch 1/6 adds device tree binding support for i.MX93 LCDIF in the
>> existing fsl,lcdif.yaml.
>>
>> Patch 2/6 drops lcdif->bridge NULL pointer check as a cleanup patch.
>>
>> Patch 3/6~5/6 prepare for adding i.MX93 LCDIF support step by step.
>>
>> Patch 6/6 adds i.MX93 LCDIF compatible string as the last step of
>> adding i.MX93 LCDIF support.
>
> Thanks for the series. I could test this on my TQMa93xxLA/MBa93xxCA with a
> single LVDS display attached, so no DSI or parallel display. Hence I could not
> test the bus format and flags checks, but they look okay.
> So you can add
> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> to the whole series as well.
>
> One thing I noticed is that, sometimes it seems that before probing lcdif my
> system completely freezes. Adding some debug output it seems that's during
> powering up the IMX93_MEDIABLK_PD_LCDIF power domain there is some race
> condition. But adding more more detailed output made the problem go away.
> Did you notice something similar? It might be a red hering though.
Interesting. Sounds similar to what I encountered on several
imx8mp-based boards, both the NXP EVK and our custom design, running a
mainline U-Boot and downstream NXP kernel:
https://lore.kernel.org/u-boot/20220823133645.4046432-1-rasmus.villemoes@prevas.dk/
I never really found a real solution, but as the hack I ended up
applying in U-Boot does involve some clock settings, and you apparently
now figured out some connection to "overclocking", I do think these
issues are related.
Rasmus
WARNING: multiple messages have this Message-ID (diff)
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Liu Ying <victor.liu@nxp.com>
Cc: marex@denx.de, shawnguo@kernel.org, s.hauer@pengutronix.de,
krzysztof.kozlowski@linaro.org, robh+dt@kernel.org,
linux-imx@nxp.com, krzysztof.kozlowski+dt@linaro.org,
kernel@pengutronix.de, LW@karo-electronics.de
Subject: Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support
Date: Mon, 20 Feb 2023 13:18:59 +0100 [thread overview]
Message-ID: <ed28bbda-16b6-043b-5310-8ac0e8ebd900@prevas.dk> (raw)
In-Reply-To: <13207614.uLZWGnKmhe@steina-w>
On 17/02/2023 09.18, Alexander Stein wrote:
> Hi Liu,
>
> Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying:
>> Hi,
>>
>> This patch set aims to add i.MX93 LCDIF display controller support
>> in the existing LCDIF DRM driver. The LCDIF embedded in i.MX93 SoC
>> is essentially the same to those embedded in i.MX8mp SoC. Through
>> internal bridges, i.MX93 LCDIF may drive a MIPI DSI display or a LVDS
>> display or a parallel display.
>>
>> Patch 1/6 adds device tree binding support for i.MX93 LCDIF in the
>> existing fsl,lcdif.yaml.
>>
>> Patch 2/6 drops lcdif->bridge NULL pointer check as a cleanup patch.
>>
>> Patch 3/6~5/6 prepare for adding i.MX93 LCDIF support step by step.
>>
>> Patch 6/6 adds i.MX93 LCDIF compatible string as the last step of
>> adding i.MX93 LCDIF support.
>
> Thanks for the series. I could test this on my TQMa93xxLA/MBa93xxCA with a
> single LVDS display attached, so no DSI or parallel display. Hence I could not
> test the bus format and flags checks, but they look okay.
> So you can add
> Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> to the whole series as well.
>
> One thing I noticed is that, sometimes it seems that before probing lcdif my
> system completely freezes. Adding some debug output it seems that's during
> powering up the IMX93_MEDIABLK_PD_LCDIF power domain there is some race
> condition. But adding more more detailed output made the problem go away.
> Did you notice something similar? It might be a red hering though.
Interesting. Sounds similar to what I encountered on several
imx8mp-based boards, both the NXP EVK and our custom design, running a
mainline U-Boot and downstream NXP kernel:
https://lore.kernel.org/u-boot/20220823133645.4046432-1-rasmus.villemoes@prevas.dk/
I never really found a real solution, but as the hack I ended up
applying in U-Boot does involve some clock settings, and you apparently
now figured out some connection to "overclocking", I do think these
issues are related.
Rasmus
next prev parent reply other threads:[~2023-02-20 12:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 6:54 [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` [PATCH v4 1/6] dt-bindings: " Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` [PATCH v4 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` [PATCH v4 3/6] drm: lcdif: Determine bus format and flags in ->atomic_check() Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 8:09 ` Alexander Stein
2023-02-17 8:09 ` Alexander Stein
2023-02-17 8:09 ` Alexander Stein
2023-02-17 6:54 ` [PATCH v4 4/6] drm: lcdif: Check consistent bus format and flags across first bridges Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 8:10 ` Alexander Stein
2023-02-17 8:10 ` Alexander Stein
2023-02-17 8:10 ` Alexander Stein
2023-02-17 6:54 ` [PATCH v4 5/6] drm: lcdif: Add multiple encoders and first bridges support Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 8:12 ` Alexander Stein
2023-02-17 8:12 ` Alexander Stein
2023-02-17 8:12 ` Alexander Stein
2023-02-17 6:54 ` [PATCH v4 6/6] drm: lcdif: Add i.MX93 LCDIF compatible string Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 6:54 ` Liu Ying
2023-02-17 8:18 ` [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support Alexander Stein
2023-02-17 8:18 ` Alexander Stein
2023-02-17 8:18 ` Alexander Stein
2023-02-17 8:59 ` Liu Ying
2023-02-17 8:59 ` Liu Ying
2023-02-17 8:59 ` Liu Ying
2023-02-20 8:55 ` Alexander Stein
2023-02-20 8:55 ` Alexander Stein
2023-02-20 8:55 ` Alexander Stein
2023-02-20 10:16 ` Alexander Stein
2023-02-20 10:16 ` Alexander Stein
2023-02-20 10:16 ` Alexander Stein
2023-02-20 12:46 ` Liu Ying
2023-02-20 12:46 ` Liu Ying
2023-02-20 12:46 ` Liu Ying
2023-02-20 12:18 ` Rasmus Villemoes [this message]
2023-02-20 12:18 ` Rasmus Villemoes
2023-02-20 12:18 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed28bbda-16b6-043b-5310-8ac0e8ebd900@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=LW@karo-electronics.de \
--cc=airlied@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.