From: Khem Raj <raj.khem@gmail.com>
To: Maxime BORGES <maxime.borges@strataggem.com>,
Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: Meta-OpenEmbedded Mailing listing
<openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory
Date: Tue, 5 Mar 2019 17:50:24 -0800 [thread overview]
Message-ID: <edac37cd-bc5c-fffd-e818-57369eed244a@gmail.com> (raw)
In-Reply-To: <7351b76e423f4e2897e99b536e8c0efd@strataggem.com>
Hi Maxime,
I think we need to understand it a bit better, eg. should we need to
change the mode for directories or just files. I Think it deserves a new
patch, I am going to apply Otavio's patch and then you can try if that
does not work then lets fix it by changing perms for files.
On 3/1/19 8:38 AM, Maxime BORGES wrote:
> For reference:
>
> https://github.com/openembedded/meta-openembedded/pull/92#issue-216348464
>
> ------------------------------------------------------------------------
> *De :* Khem Raj <raj.khem@gmail.com>
> *Envoyé :* vendredi 1 mars 2019 16:56:31
> *À :* Otavio Salvador; Maxime BORGES
> *Cc :* Burton, Ross; Otavio Salvador; Meta-OpenEmbedded Mailing listing
> *Objet :* Re: [oe] [meta-oe PATCH 1/2] python-idna: Avoid removing '+x'
> from `.egg-info/` directory
> Otavio
>
> Can you resend this patch series, its missing in patchwork, so
> hopefully, it will catch it this time.
>
> On Mon, Feb 25, 2019 at 11:05 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Mon, Feb 25, 2019 at 10:38 AM Otavio Salvador
>> <otavio.salvador@ossystems.com.br> wrote:
>> >
>> > On Mon, Feb 25, 2019 at 2:03 PM Burton, Ross <ross.burton@intel.com> wrote:
>> > >
>> > > The original patch doesn't explain what it's doing and is clearly
>> > > going to remove executable bits from directories, which clearly isn't
>> > > right.
>> > >
>> > > I'd say remove it, and *then* if it breaks again fix properly.
>> >
>> > I am with Ross here. It is a really ugly patch and if need, we need a
>> > comment on the code and a proper reason to add it back.
>> >
>>
>> +Maxime for information on the original patch
next prev parent reply other threads:[~2019-03-06 1:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 14:00 [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory Otavio Salvador
2019-02-25 14:00 ` [meta-oe PATCH 2/2] python-idna: Upgrade 2.7 -> 2.8 Otavio Salvador
2019-02-25 15:06 ` [meta-oe PATCH 1/2] python-idna: Avoid removing '+x' from `.egg-info/` directory Khem Raj
2019-02-25 17:03 ` Burton, Ross
2019-02-25 18:38 ` Otavio Salvador
2019-02-25 19:05 ` Khem Raj
2019-03-01 15:56 ` Khem Raj
2019-03-01 16:54 ` Otavio Salvador
2019-03-01 17:03 ` Tim Orling
2019-03-01 17:43 ` Khem Raj
[not found] ` <7351b76e423f4e2897e99b536e8c0efd@strataggem.com>
2019-03-06 1:50 ` Khem Raj [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-01 16:54 Otavio Salvador
2019-02-22 21:19 Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edac37cd-bc5c-fffd-e818-57369eed244a@gmail.com \
--to=raj.khem@gmail.com \
--cc=maxime.borges@strataggem.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.