From: "Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>,
Development mailing list for IGT GPU Tools
<igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] lib/igt_kms: Try all blend modes when resetting it
Date: Wed, 18 Nov 2026 12:59:45 +0200 [thread overview]
Message-ID: <edb1cff8-bc8d-4e7f-8994-caf9074ff644@gmail.com> (raw)
In-Reply-To: <20261117103356.303340-1-zhengxingda@iscas.ac.cn>
Hi, I requested the ci results for your change. Once see ci results I
can review.
/Juha-Pekka
On 17/11/2026 12.33, Icenowy Zheng wrote:
> Since Linux 7.3, the pixel blend mode property of planes would be
> present (and required when the plane supports formats w/ alpha) even
> when Pre-multiplied isn't supported, which leads to assertion failure in
> igt_plane_reset().
>
> Add logic to try all possible values for this property mimicking the
> logic of kernel deciding the default value.
>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> ---
> lib/igt_kms.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 915c6a8a2..789da08b3 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -2644,6 +2644,22 @@ static int get_drm_plane_type(int drm_fd, uint32_t plane_id)
> return DRM_PLANE_TYPE_OVERLAY;
> }
>
> +static void igt_plane_reset_blend_mode(igt_plane_t *plane)
> +{
> + bool result;
> +
> + result = igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
> + if (result)
> + return;
> +
> + result = igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
> + if (result)
> + return;
> +
> + result = igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
> + igt_assert(result);
> +}
> +
> static void igt_plane_reset(igt_plane_t *plane)
> {
> igt_display_t *display = plane->crtc->display;
> @@ -2679,7 +2695,7 @@ static void igt_plane_reset(igt_plane_t *plane)
> igt_plane_set_prop_value(plane, IGT_PLANE_ROTATION, IGT_ROTATION_0);
>
> if (igt_plane_has_prop(plane, IGT_PLANE_PIXEL_BLEND_MODE))
> - igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
> + igt_plane_reset_blend_mode(plane);
>
> if (igt_plane_has_prop(plane, IGT_PLANE_ALPHA))
> igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0xffff);
prev parent reply other threads:[~2026-11-18 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:33 [PATCH i-g-t] lib/igt_kms: Try all blend modes when resetting it Icenowy Zheng
2026-11-18 8:13 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2026-11-18 10:59 ` Juha-Pekka Heikkilä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edb1cff8-bc8d-4e7f-8994-caf9074ff644@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.