All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] lib/igt_kms: Try all blend modes when resetting it
@ 2026-11-17 10:33 Icenowy Zheng
  2026-11-18  8:13 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
  2026-11-18 10:59 ` [PATCH i-g-t] " Juha-Pekka Heikkilä
  0 siblings, 2 replies; 3+ messages in thread
From: Icenowy Zheng @ 2026-11-17 10:33 UTC (permalink / raw)
  To: Development mailing list for IGT GPU Tools; +Cc: Icenowy Zheng

Since Linux 7.3, the pixel blend mode property of planes would be
present (and required when the plane supports formats w/ alpha) even
when Pre-multiplied isn't supported, which leads to assertion failure in
igt_plane_reset().

Add logic to try all possible values for this property mimicking the
logic of kernel deciding the default value.

Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
 lib/igt_kms.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 915c6a8a2..789da08b3 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2644,6 +2644,22 @@ static int get_drm_plane_type(int drm_fd, uint32_t plane_id)
 	return DRM_PLANE_TYPE_OVERLAY;
 }
 
+static void igt_plane_reset_blend_mode(igt_plane_t *plane)
+{
+	bool result;
+
+	result = igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
+	if (result)
+		return;
+
+	result = igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Coverage");
+	if (result)
+		return;
+
+	result = igt_plane_try_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "None");
+	igt_assert(result);
+}
+
 static void igt_plane_reset(igt_plane_t *plane)
 {
 	igt_display_t *display = plane->crtc->display;
@@ -2679,7 +2695,7 @@ static void igt_plane_reset(igt_plane_t *plane)
 		igt_plane_set_prop_value(plane, IGT_PLANE_ROTATION, IGT_ROTATION_0);
 
 	if (igt_plane_has_prop(plane, IGT_PLANE_PIXEL_BLEND_MODE))
-		igt_plane_set_prop_enum(plane, IGT_PLANE_PIXEL_BLEND_MODE, "Pre-multiplied");
+		igt_plane_reset_blend_mode(plane);
 
 	if (igt_plane_has_prop(plane, IGT_PLANE_ALPHA))
 		igt_plane_set_prop_value(plane, IGT_PLANE_ALPHA, 0xffff);
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-18 11:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 10:33 [PATCH i-g-t] lib/igt_kms: Try all blend modes when resetting it Icenowy Zheng
2026-11-18  8:13 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2026-11-18 10:59 ` [PATCH i-g-t] " Juha-Pekka Heikkilä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.