[PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781

[PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781

[Shenghao Ding]

Rename dai_driver name to unify the name between TAS2563 and
TAS2781.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
 sound/soc/codecs/tas2781-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
index 8a57c045afdd..8f9574189e1f 100644
--- a/sound/soc/codecs/tas2781-i2c.c
+++ b/sound/soc/codecs/tas2781-i2c.c
@@ -673,7 +673,7 @@ static const struct snd_soc_dai_ops tasdevice_dai_ops = {
 
 static struct snd_soc_dai_driver tasdevice_dai_driver[] = {
 	{
-		.name = "tas2781_codec",
+		.name = "tasdev_codec",
 		.id = 0,
 		.playback = {
 			.stream_name = "Playback",
-- 
2.34.1

Re: [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781

[Andy Shevchenko]

On Tue, Aug 06, 2024 at 12:17:17PM +0800, Shenghao Ding wrote:
> Rename dai_driver name to unify the name between TAS2563 and
> TAS2781.

I am not sure this is a good change. Theoretically one with the platform that
has a certain codec may connect the other one. How that will be distinguished?

If there is no issue for such configurations, please mention this fact in the
commit message.

-- 
With Best Regards,
Andy Shevchenko

RE: [EXTERNAL] Re: [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781

[Ding, Shenghao]

Hi Andy
Answer inline
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sent: Tuesday, August 13, 2024 1:12 AM
To: Ding, Shenghao <shenghao-ding@ti.com>
Cc: broonie@kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; 13916275206@139.com; zhourui@huaqin.com; alsa-devel@alsa-project.org; Salazar, Ivan <i-salazar@ti.com>; linux-kernel@vger.kernel.org; Chadha, Jasjot Singh <j-chadha@ti.com>; liam.r.girdwood@intel.com; Yue, Jaden <jaden-yue@ti.com>; yung-chuan.liao@linux.intel.com; Rao, Dipa <dipa@ti.com>; yuhsuan@google.com; Lo, Henry <henry.lo@ti.com>; tiwai@suse.de; Xu, Baojun <baojun.xu@ti.com>; soyer@irl.hu; Baojun.Xu@fpt.com; judyhsiao@google.com; Navada Kanyana, Mukund <navada@ti.com>; cujomalainey@google.com; Kutty, Aanya <aanya@ti.com>; Mahmud, Nayeem <nayeem.mahmud@ti.com>; savyasanchi.shukla@netradyne.com; flaviopr@microsoft.com; Ji, Jesse <jesse-ji@ti.com>; darren.ye@mediatek.com; antheas.dk@gmail.com; Jerry2.Huang@lcfuturecenter.com
Subject: [EXTERNAL] Re: [PATCH] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781

On Tue, Aug 06, 2024 at 12: 17: 17PM +0800, Shenghao Ding wrote: > Rename dai_driver name to unify the name between TAS2563 and > TAS2781. I am not sure this is a good change. Theoretically one with the platform that has a certain codec
ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.

Do not click links or open attachments unless you recognize the source of this email and know the content is safe.

    Report Suspicious  <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uBdnVV-BGyfThcmOspiPk_6mgviDIpMpU9lNaStHOlAnmlORtYg0KTnMhfSSI5acx0kk2CbMnnsjoWU-o8U$>   ‌



ZjQcmQRYFpfptBannerEnd

On Tue, Aug 06, 2024 at 12:17:17PM +0800, Shenghao Ding wrote:

> Rename dai_driver name to unify the name between TAS2563 and

> TAS2781.



I am not sure this is a good change. Theoretically one with the platform that

has a certain codec may connect the other one. How that will be distinguished?

[DING] As you know, this driver code can support both tas2563 and tas2781.

But some tas2563 customers feel confused and uncomfortable, when they

found the dai_driver name is still tas2781. So, update the name for them



If there is no issue for such configurations, please mention this fact in the

commit message.

[DING] Accept

--

With Best Regards,

Andy Shevchenko