Re: [PATCH i-g-t v2 09/16] tests/kms_vblank: split outer test loop into two

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]


On 13-07-2026 02:25 pm, Michał Grzelak wrote:
> for_each_crtc_with_valid_output() iterates over every crtc with
> connected output. Split it into two loops. This is needed to handle
> cases per output.
>
> Signed-off-by: Michał Grzelak<michal.grzelak@intel.com>

LGTM:

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

> ---
>   tests/kms_vblank.c | 41 ++++++++++++++++++++++-------------------
>   1 file changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 7fb7de0a70..47b733af15 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -515,25 +515,28 @@ static void run_subtests(data_t *data)
>   
>   			igt_describe("Check if test run while hanging by introducing NOHANG flag.");
>   			igt_subtest_with_dynamic_f("%s-%s", f->name, m->name) {
> -				for_each_crtc_with_valid_output(&data->display,
> -								crtc,
> -								data->output) {
> -					data->crtc = crtc;
> -					if (!crtc_output_combo_valid(&data->display, crtc, data->output))
> -						continue;
> -
> -					if (!all_pipes && crtc->crtc_index != active_crtcs[0] &&
> -					    crtc->crtc_index != active_crtcs[last_crtc_index]) {
> -						igt_info("Skipping pipe %s\n",
> -							 igt_crtc_name(crtc));
> -						continue;
> -					}
> -
> -					igt_dynamic_f("pipe-%s-%s",
> -						      igt_crtc_name(crtc),
> -						      data->output->name) {
> -						data->flags = m->flags | NOHANG;
> -						run_test(data, f->func);
> +				for_each_connected_output(&data->display, data->output) {
> +					for_each_crtc(&data->display, crtc) {
> +						if(!igt_crtc_connector_valid(crtc, data->output))
> +							continue;
> +
> +						data->crtc = crtc;
> +						if (!crtc_output_combo_valid(&data->display, crtc, data->output))
> +							continue;
> +
> +						if (!all_pipes && crtc->crtc_index != active_crtcs[0] &&
> +						    crtc->crtc_index != active_crtcs[last_crtc_index]) {
> +							igt_info("Skipping pipe %s\n",
> +								 igt_crtc_name(crtc));
> +							continue;
> +						}
> +
> +						igt_dynamic_f("pipe-%s-%s",
> +							      igt_crtc_name(crtc),
> +							      data->output->name) {
> +							data->flags = m->flags | NOHANG;
> +							run_test(data, f->func);
> +						}
>   					}
>   				}
>   			}

[-- Attachment #2: Type: text/html, Size: 3137 bytes --]