From: Chris Wilson <chris@chris-wilson.co.uk>
To: Paulo Zanoni <przanoni@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI
Date: Fri, 23 Nov 2012 17:54:34 +0000 [thread overview]
Message-ID: <eeac1e$53rk3v@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <1353691840-9913-4-git-send-email-przanoni@gmail.com>
On Fri, 23 Nov 2012 15:30:40 -0200, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> In other words, move the check from inside the function to outside it.
Don't agree with this last step. You can make the function tidier with
an early return, but it is paramount that the high level sequence inside
intel_modeset_init_hw() be clear and comprehendable.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-23 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 17:30 [PATCH 1/4] drm/i915: intel_prepare_ddi_buffers should be static Paulo Zanoni
2012-11-23 17:30 ` [PATCH 2/4] drm/i915: remove Haswell code from ironlake_fdi_pll_enable Paulo Zanoni
2012-11-23 17:30 ` [PATCH 3/4] drm/i915: add HAS_DDI check Paulo Zanoni
2012-11-23 17:30 ` [PATCH 4/4] drm/i915: only call intel_prepare_ddi if HAS_DDI Paulo Zanoni
2012-11-23 17:54 ` Chris Wilson [this message]
2012-11-23 18:46 ` [PATCH] drm/i915: invert the log inside intel_prepare_ddi Paulo Zanoni
2012-11-29 13:39 ` [PATCH 1/4] drm/i915: intel_prepare_ddi_buffers should be static Imre Deak
2012-11-29 13:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eeac1e$53rk3v@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.