All of lore.kernel.org
 help / color / mirror / Atom feed
From: psodagud@codeaurora.org (Sodagudi Prasad)
To: linux-arm-kernel@lists.infradead.org
Subject: [Query]  doubt on parameters passed to dma_map_single_attrs() API
Date: Tue, 22 Mar 2016 15:53:02 +0530	[thread overview]
Message-ID: <eedb87e1131d74a77b49599648cc5aac@codeaurora.org> (raw)


Hi All,

Would like to check whether the dma_map_single_attrs() API, can accept 
ptr variable from high memory or not?
If we pass the memory pointer, which is pointing high memory does not 
work with virt_to_page API.

10 static inline dma_addr_t dma_map_single_attrs(struct device *dev, 
void *ptr,
  11                                               size_t size,
  12                                               enum 
dma_data_direction dir,
  13                                               struct dma_attrs 
*attrs)
  14 {
  15         const struct dma_map_ops *ops = get_dma_ops(dev);
  16         dma_addr_t addr;
  17
  18         kmemcheck_mark_initialized(ptr, size);
  19         BUG_ON(!valid_dma_direction(dir));
  20         addr = ops->map_page(dev, virt_to_page(ptr),
  21                              (unsigned long)ptr & ~PAGE_MASK, size,
  22                              dir, attrs);
<Prasad> using the virt_to_page for the high memory will end up with 
wrong address.
  23         debug_dma_map_page(dev, virt_to_page(ptr),
  24                            (unsigned long)ptr & ~PAGE_MASK, size,
  25                            dir, addr, true);
  26         return addr;
  27 }

The only restriction which is observed that, ptr should point to 
physically contiguous memory.

So can we pass high memory mapped address to dma_map_single API or not?

-Thanks, Prasad

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Sodagudi Prasad <psodagud@codeaurora.org>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk
Cc: shashim@codeaurora.org, sboyd@codeaurora.org, psodagud@codeaurora.org
Subject: [Query]  doubt on parameters passed to dma_map_single_attrs() API
Date: Tue, 22 Mar 2016 15:53:02 +0530	[thread overview]
Message-ID: <eedb87e1131d74a77b49599648cc5aac@codeaurora.org> (raw)


Hi All,

Would like to check whether the dma_map_single_attrs() API, can accept 
ptr variable from high memory or not?
If we pass the memory pointer, which is pointing high memory does not 
work with virt_to_page API.

10 static inline dma_addr_t dma_map_single_attrs(struct device *dev, 
void *ptr,
  11                                               size_t size,
  12                                               enum 
dma_data_direction dir,
  13                                               struct dma_attrs 
*attrs)
  14 {
  15         const struct dma_map_ops *ops = get_dma_ops(dev);
  16         dma_addr_t addr;
  17
  18         kmemcheck_mark_initialized(ptr, size);
  19         BUG_ON(!valid_dma_direction(dir));
  20         addr = ops->map_page(dev, virt_to_page(ptr),
  21                              (unsigned long)ptr & ~PAGE_MASK, size,
  22                              dir, attrs);
<Prasad> using the virt_to_page for the high memory will end up with 
wrong address.
  23         debug_dma_map_page(dev, virt_to_page(ptr),
  24                            (unsigned long)ptr & ~PAGE_MASK, size,
  25                            dir, addr, true);
  26         return addr;
  27 }

The only restriction which is observed that, ptr should point to 
physically contiguous memory.

So can we pass high memory mapped address to dma_map_single API or not?

-Thanks, Prasad

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
Linux Foundation Collaborative Project

             reply	other threads:[~2016-03-22 10:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 10:23 Sodagudi Prasad [this message]
2016-03-22 10:23 ` [Query] doubt on parameters passed to dma_map_single_attrs() API Sodagudi Prasad
2016-03-22 12:34 ` Russell King - ARM Linux
2016-03-22 12:34   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eedb87e1131d74a77b49599648cc5aac@codeaurora.org \
    --to=psodagud@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.