From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
Chuanhong Guo <gch981213@gmail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, benliang.zhao@mediatek.com,
bin.zhang@mediatek.com
Subject: Re: [PATCH v2 3/9] spi: mtk-snfi: Add optional nfi_hclk which needed for MT7986
Date: Mon, 5 Dec 2022 15:21:35 +0100 [thread overview]
Message-ID: <ef2e6859-56e1-bbf0-dbde-44ea3d7d2f3f@collabora.com> (raw)
In-Reply-To: <20221205065756.26875-4-xiangsheng.hou@mediatek.com>
Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
> Add optional nfi_hclk which needed for MT7986.
>
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Is there any operation for which you need NFI_HCLK enabled, but at the same time
PAD_CLK and/or NFI_CLK can be disabled?
If NFI_HCLK and NFI_CLK must always be ON at the same time, adding this clock to
spi-mtk-snfi.c is *not* an optimal way of doing things: you can, at this point,
set NFI_HCLK as parent of NFI_CLK in the MT7986 clock driver instead, without
making any addition to this driver at all.
Regards,
Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
Chuanhong Guo <gch981213@gmail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, benliang.zhao@mediatek.com,
bin.zhang@mediatek.com
Subject: Re: [PATCH v2 3/9] spi: mtk-snfi: Add optional nfi_hclk which needed for MT7986
Date: Mon, 5 Dec 2022 15:21:35 +0100 [thread overview]
Message-ID: <ef2e6859-56e1-bbf0-dbde-44ea3d7d2f3f@collabora.com> (raw)
In-Reply-To: <20221205065756.26875-4-xiangsheng.hou@mediatek.com>
Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
> Add optional nfi_hclk which needed for MT7986.
>
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Is there any operation for which you need NFI_HCLK enabled, but at the same time
PAD_CLK and/or NFI_CLK can be disabled?
If NFI_HCLK and NFI_CLK must always be ON at the same time, adding this clock to
spi-mtk-snfi.c is *not* an optimal way of doing things: you can, at this point,
set NFI_HCLK as parent of NFI_CLK in the MT7986 clock driver instead, without
making any addition to this driver at all.
Regards,
Angelo
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
Chuanhong Guo <gch981213@gmail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, benliang.zhao@mediatek.com,
bin.zhang@mediatek.com
Subject: Re: [PATCH v2 3/9] spi: mtk-snfi: Add optional nfi_hclk which needed for MT7986
Date: Mon, 5 Dec 2022 15:21:35 +0100 [thread overview]
Message-ID: <ef2e6859-56e1-bbf0-dbde-44ea3d7d2f3f@collabora.com> (raw)
In-Reply-To: <20221205065756.26875-4-xiangsheng.hou@mediatek.com>
Il 05/12/22 07:57, Xiangsheng Hou ha scritto:
> Add optional nfi_hclk which needed for MT7986.
>
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Is there any operation for which you need NFI_HCLK enabled, but at the same time
PAD_CLK and/or NFI_CLK can be disabled?
If NFI_HCLK and NFI_CLK must always be ON at the same time, adding this clock to
spi-mtk-snfi.c is *not* an optimal way of doing things: you can, at this point,
set NFI_HCLK as parent of NFI_CLK in the MT7986 clock driver instead, without
making any addition to this driver at all.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-05 14:22 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 6:57 [PATCH v2 0/9] Add MediaTek MT7986 SPI NAND and ECC support Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` [PATCH v2 1/9] spi: mtk-snfi: Add snfi support for MT7986 IC Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 6:57 ` [PATCH v2 2/9] spi: mtk-snfi: Change default page format to setup default setting Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` [PATCH v2 3/9] spi: mtk-snfi: Add optional nfi_hclk which needed for MT7986 Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno [this message]
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-07 1:42 ` Xiangsheng Hou (侯祥胜)
2022-12-07 1:42 ` Xiangsheng Hou (侯祥胜)
2022-12-07 1:42 ` Xiangsheng Hou (侯祥胜)
2022-12-07 10:08 ` AngeloGioacchino Del Regno
2022-12-07 10:08 ` AngeloGioacchino Del Regno
2022-12-07 10:08 ` AngeloGioacchino Del Regno
2022-12-05 6:57 ` [PATCH v2 4/9] mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 12:22 ` AngeloGioacchino Del Regno
2022-12-06 12:22 ` AngeloGioacchino Del Regno
2022-12-06 12:22 ` AngeloGioacchino Del Regno
2022-12-07 2:01 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:01 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:01 ` Xiangsheng Hou (侯祥胜)
2022-12-05 6:57 ` [PATCH v2 5/9] dt-bindings: spi: mtk-snfi: Add compatible for MT7986 Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:05 ` Krzysztof Kozlowski
2022-12-05 9:05 ` Krzysztof Kozlowski
2022-12-05 9:05 ` Krzysztof Kozlowski
2022-12-05 6:57 ` [PATCH v2 6/9] spi: mtk-snfi: Add snfi sample delay and read latency adjustment Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 6:57 ` [PATCH v2 7/9] dt-bindings: spi: mtk-snfi: Add read latch latency property Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:06 ` Krzysztof Kozlowski
2022-12-05 9:06 ` Krzysztof Kozlowski
2022-12-05 9:06 ` Krzysztof Kozlowski
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-05 14:21 ` AngeloGioacchino Del Regno
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:04 ` Xiangsheng Hou (侯祥胜)
2022-12-06 12:19 ` AngeloGioacchino Del Regno
2022-12-06 12:19 ` AngeloGioacchino Del Regno
2022-12-06 12:19 ` AngeloGioacchino Del Regno
2022-12-07 2:00 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:00 ` Xiangsheng Hou (侯祥胜)
2022-12-07 2:00 ` Xiangsheng Hou (侯祥胜)
2022-12-07 9:48 ` AngeloGioacchino Del Regno
2022-12-07 9:48 ` AngeloGioacchino Del Regno
2022-12-07 9:48 ` AngeloGioacchino Del Regno
2022-12-08 1:15 ` Xiangsheng Hou (侯祥胜)
2022-12-08 1:15 ` Xiangsheng Hou (侯祥胜)
2022-12-08 1:15 ` Xiangsheng Hou (侯祥胜)
2022-12-08 8:46 ` Krzysztof Kozlowski
2022-12-08 8:46 ` Krzysztof Kozlowski
2022-12-08 8:46 ` Krzysztof Kozlowski
2022-12-05 6:57 ` [PATCH v2 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:21 ` Krzysztof Kozlowski
2022-12-05 9:21 ` Krzysztof Kozlowski
2022-12-05 9:21 ` Krzysztof Kozlowski
2022-12-06 9:05 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:05 ` Xiangsheng Hou (侯祥胜)
2022-12-06 9:05 ` Xiangsheng Hou (侯祥胜)
2022-12-05 6:57 ` [PATCH v2 9/9] dt-bindings: mtd: ecc-mtk: Add compatible for MT7986 Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 6:57 ` Xiangsheng Hou
2022-12-05 9:22 ` Krzysztof Kozlowski
2022-12-05 9:22 ` Krzysztof Kozlowski
2022-12-05 9:22 ` Krzysztof Kozlowski
2022-12-06 16:04 ` (subset) [PATCH v2 0/9] Add MediaTek MT7986 SPI NAND and ECC support Mark Brown
2022-12-06 16:04 ` Mark Brown
2022-12-06 16:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef2e6859-56e1-bbf0-dbde-44ea3d7d2f3f@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=benliang.zhao@mediatek.com \
--cc=bin.zhang@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=xiangsheng.hou@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.