Re: [PATCH 1/2] drm/xe: Removed unused xe_ggtt_printk

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 14-06-2024 03:16, Rodrigo Vivi wrote:
> Apparently this was only useful when enabling ggtt support
> for the very first time and never used again.
> It is also not useful now that we have the ggtt_dump available
> through debugfs.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ggtt.c | 20 --------------------
>   drivers/gpu/drm/xe/xe_ggtt.h |  1 -
>   2 files changed, 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 8ff91fd1b7c8..2d5e802f862d 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -277,26 +277,6 @@ static void xe_ggtt_invalidate(struct xe_ggtt *ggtt)
>   	ggtt_invalidate_gt_tlb(ggtt->tile->media_gt);
>   }
>   
> -void xe_ggtt_printk(struct xe_ggtt *ggtt, const char *prefix)
> -{
> -	u16 pat_index = tile_to_xe(ggtt->tile)->pat.idx[XE_CACHE_WB];
> -	u64 addr, scratch_pte;
> -
> -	scratch_pte = ggtt->pt_ops->pte_encode_bo(ggtt->scratch, 0, pat_index);
> -
> -	printk("%sGlobal GTT:", prefix);
> -	for (addr = 0; addr < ggtt->size; addr += XE_PAGE_SIZE) {
> -		unsigned int i = addr / XE_PAGE_SIZE;
> -
> -		xe_tile_assert(ggtt->tile, addr <= U32_MAX);
> -		if (ggtt->gsm[i] == scratch_pte)
> -			continue;
> -
> -		printk("%s    ggtt[0x%08x] = 0x%016llx",
> -		       prefix, (u32)addr, ggtt->gsm[i]);
> -	}
> -}
> -
>   static void xe_ggtt_dump_node(struct xe_ggtt *ggtt,
>   			      const struct drm_mm_node *node, const char *description)
>   {
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
> index 4a41a1762358..ef86ad7a079b 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.h
> +++ b/drivers/gpu/drm/xe/xe_ggtt.h
> @@ -13,7 +13,6 @@ struct drm_printer;
>   void xe_ggtt_set_pte(struct xe_ggtt *ggtt, u64 addr, u64 pte);
>   int xe_ggtt_init_early(struct xe_ggtt *ggtt);
>   int xe_ggtt_init(struct xe_ggtt *ggtt);
> -void xe_ggtt_printk(struct xe_ggtt *ggtt, const char *prefix);

LGTM.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   int xe_ggtt_balloon(struct xe_ggtt *ggtt, u64 start, u64 size, struct drm_mm_node *node);
>   void xe_ggtt_deballoon(struct xe_ggtt *ggtt, struct drm_mm_node *node);