All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/xe: Removed unused xe_ggtt_printk
@ 2024-06-13 21:46 Rodrigo Vivi
  2024-06-13 21:47 ` [PATCH 2/2] drm/xe: Introduce GGTT documentation Rodrigo Vivi
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Rodrigo Vivi @ 2024-06-13 21:46 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi

Apparently this was only useful when enabling ggtt support
for the very first time and never used again.
It is also not useful now that we have the ggtt_dump available
through debugfs.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_ggtt.c | 20 --------------------
 drivers/gpu/drm/xe/xe_ggtt.h |  1 -
 2 files changed, 21 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 8ff91fd1b7c8..2d5e802f862d 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -277,26 +277,6 @@ static void xe_ggtt_invalidate(struct xe_ggtt *ggtt)
 	ggtt_invalidate_gt_tlb(ggtt->tile->media_gt);
 }
 
-void xe_ggtt_printk(struct xe_ggtt *ggtt, const char *prefix)
-{
-	u16 pat_index = tile_to_xe(ggtt->tile)->pat.idx[XE_CACHE_WB];
-	u64 addr, scratch_pte;
-
-	scratch_pte = ggtt->pt_ops->pte_encode_bo(ggtt->scratch, 0, pat_index);
-
-	printk("%sGlobal GTT:", prefix);
-	for (addr = 0; addr < ggtt->size; addr += XE_PAGE_SIZE) {
-		unsigned int i = addr / XE_PAGE_SIZE;
-
-		xe_tile_assert(ggtt->tile, addr <= U32_MAX);
-		if (ggtt->gsm[i] == scratch_pte)
-			continue;
-
-		printk("%s    ggtt[0x%08x] = 0x%016llx",
-		       prefix, (u32)addr, ggtt->gsm[i]);
-	}
-}
-
 static void xe_ggtt_dump_node(struct xe_ggtt *ggtt,
 			      const struct drm_mm_node *node, const char *description)
 {
diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
index 4a41a1762358..ef86ad7a079b 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.h
+++ b/drivers/gpu/drm/xe/xe_ggtt.h
@@ -13,7 +13,6 @@ struct drm_printer;
 void xe_ggtt_set_pte(struct xe_ggtt *ggtt, u64 addr, u64 pte);
 int xe_ggtt_init_early(struct xe_ggtt *ggtt);
 int xe_ggtt_init(struct xe_ggtt *ggtt);
-void xe_ggtt_printk(struct xe_ggtt *ggtt, const char *prefix);
 
 int xe_ggtt_balloon(struct xe_ggtt *ggtt, u64 start, u64 size, struct drm_mm_node *node);
 void xe_ggtt_deballoon(struct xe_ggtt *ggtt, struct drm_mm_node *node);
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-06-14 10:46 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-13 21:46 [PATCH 1/2] drm/xe: Removed unused xe_ggtt_printk Rodrigo Vivi
2024-06-13 21:47 ` [PATCH 2/2] drm/xe: Introduce GGTT documentation Rodrigo Vivi
2024-06-14  3:42   ` Ghimiray, Himal Prasad
2024-06-14 10:46   ` Michal Wajdeczko
2024-06-13 21:52 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Removed unused xe_ggtt_printk Patchwork
2024-06-13 21:52 ` ✓ CI.checkpatch: " Patchwork
2024-06-13 21:53 ` ✓ CI.KUnit: " Patchwork
2024-06-13 22:05 ` ✓ CI.Build: " Patchwork
2024-06-13 22:07 ` ✗ CI.Hooks: failure " Patchwork
2024-06-13 22:08 ` ✓ CI.checksparse: success " Patchwork
2024-06-13 22:30 ` ✓ CI.BAT: " Patchwork
2024-06-14  3:29 ` [PATCH 1/2] " Ghimiray, Himal Prasad

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.