[PATCH 0/2] platform/x86: touchscreen_dmi: Add info for 2 new models

[PATCH 0/2] platform/x86: touchscreen_dmi: Add info for 2 new models

[Hans de Goede]

Hi All,

This series adds touchscreen parameters for 2 new models to
touchscreen_dmi.c . The parameters for these 2 new models have been
found by using the new "i2c_touchscreen_props=..." kernel commandline
argument.

These 2 patches have been cherry-picked from:

https://github.com/android-generic/kernel_common/

which already as the "i2c_touchscreen_props=..." support merged.

Regards,

Hans


hmtheboy154 (2):
  platform/x86: touchscreen_dmi: Add info for GlobalSpace SolT IVW 11.6"
    tablet
  platform/x86: touchscreen_dmi: Add info for the EZpad 6s Pro

 drivers/platform/x86/touchscreen_dmi.c | 35 ++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

-- 
2.45.1

[PATCH 1/2] platform/x86: touchscreen_dmi: Add info for GlobalSpace SolT IVW 11.6" tablet

[Hans de Goede]

From: hmtheboy154 <buingoc67@gmail.com>

This is a tablet created by GlobalSpace Technologies Limited
which uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB of storage.

Link: https://web.archive.org/web/20171102141952/http://globalspace.in/11.6-device.html
Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index b021fb9e579e..6c03e7daadd4 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -900,6 +900,22 @@ static const struct ts_dmi_data schneider_sct101ctm_data = {
 	.properties	= schneider_sct101ctm_props,
 };
 
+static const struct property_entry globalspace_solt_ivw116_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-min-x", 7),
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 22),
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1723),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1077),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-globalspace-solt-ivw116.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data globalspace_solt_ivw116_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= globalspace_solt_ivw116_props,
+};
+
 static const struct property_entry techbite_arc_11_6_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-min-x", 5),
 	PROPERTY_ENTRY_U32("touchscreen-min-y", 7),
@@ -1627,6 +1643,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "SCT101CTM"),
 		},
 	},
+	{
+		/* GlobalSpace SoLT IVW 11.6" */
+		.driver_data = (void *)&globalspace_solt_ivw116_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Globalspace Tech Pvt Ltd"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SolTIVW"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "PN20170413488"),
+		},
+	},
 	{
 		/* Techbite Arc 11.6 */
 		.driver_data = (void *)&techbite_arc_11_6_data,
-- 
2.45.1

[PATCH 2/2] platform/x86: touchscreen_dmi: Add info for the EZpad 6s Pro

[Hans de Goede]

From: hmtheboy154 <buingoc67@gmail.com>

The "EZpad 6s Pro" uses the same touchscreen as the "EZpad 6 Pro B",
unlike the "Ezpad 6 Pro" which has its own touchscreen.

Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/touchscreen_dmi.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 6c03e7daadd4..2d9ca2292ea1 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -1404,6 +1404,17 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_BIOS_DATE, "04/24/2018"),
 		},
 	},
+	{
+		/* Jumper EZpad 6s Pro */
+		.driver_data = (void *)&jumper_ezpad_6_pro_b_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Jumper"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Ezpad"),
+			/* Above matches are too generic, add bios match */
+			DMI_MATCH(DMI_BIOS_VERSION, "E.WSA116_8.E1.042.bin"),
+			DMI_MATCH(DMI_BIOS_DATE, "01/08/2020"),
+		},
+	},
 	{
 		/* Jumper EZpad 6 m4 */
 		.driver_data = (void *)&jumper_ezpad_6_m4_data,
-- 
2.45.1

Re: [PATCH 1/2] platform/x86: touchscreen_dmi: Add info for GlobalSpace SolT IVW 11.6" tablet

[Ilpo Järvinen]

On Mon, 27 May 2024, Hans de Goede wrote:

> From: hmtheboy154 <buingoc67@gmail.com>
> 
> This is a tablet created by GlobalSpace Technologies Limited
> which uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB of storage.
> 
> Link: https://web.archive.org/web/20171102141952/http://globalspace.in/11.6-device.html
> Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index b021fb9e579e..6c03e7daadd4 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -900,6 +900,22 @@ static const struct ts_dmi_data schneider_sct101ctm_data = {
>  	.properties	= schneider_sct101ctm_props,
>  };
>  
> +static const struct property_entry globalspace_solt_ivw116_props[] = {
> +	PROPERTY_ENTRY_U32("touchscreen-min-x", 7),
> +	PROPERTY_ENTRY_U32("touchscreen-min-y", 22),
> +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1723),
> +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1077),
> +	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-globalspace-solt-ivw116.fw"),
> +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),

So you're planning to route these through fixes branch?

Just asking this because you've the other patch in flight which removes 
these max-fingers entries (I know it's not harmful to have an extra entry 
but just trying to synch on the intent).

-- 
 i.

Re: [PATCH 1/2] platform/x86: touchscreen_dmi: Add info for GlobalSpace SolT IVW 11.6" tablet

[Hans de Goede]

Hi Ilpo,

On 5/27/24 11:21 AM, Ilpo Järvinen wrote:
> On Mon, 27 May 2024, Hans de Goede wrote:
> 
>> From: hmtheboy154 <buingoc67@gmail.com>
>>
>> This is a tablet created by GlobalSpace Technologies Limited
>> which uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB of storage.
>>
>> Link: https://web.archive.org/web/20171102141952/http://globalspace.in/11.6-device.html
>> Signed-off-by: hmtheboy154 <buingoc67@gmail.com>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>  drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
>> index b021fb9e579e..6c03e7daadd4 100644
>> --- a/drivers/platform/x86/touchscreen_dmi.c
>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>> @@ -900,6 +900,22 @@ static const struct ts_dmi_data schneider_sct101ctm_data = {
>>  	.properties	= schneider_sct101ctm_props,
>>  };
>>  
>> +static const struct property_entry globalspace_solt_ivw116_props[] = {
>> +	PROPERTY_ENTRY_U32("touchscreen-min-x", 7),
>> +	PROPERTY_ENTRY_U32("touchscreen-min-y", 22),
>> +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1723),
>> +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1077),
>> +	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-globalspace-solt-ivw116.fw"),
>> +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> 
> So you're planning to route these through fixes branch?
> 
> Just asking this because you've the other patch in flight which removes 
> these max-fingers entries (I know it's not harmful to have an extra entry 
> but just trying to synch on the intent).

Yes I plan to merge these 2 through the fixes branch.

I'm still discussing how to merge the removal of the 10 finger entries with Dmitry,

I think it might be best to merge that through the fixes branch too (after
rebasing it to also remove the 10 finger entries these add).

Regards,

Hans

Re: [PATCH 0/2] platform/x86: touchscreen_dmi: Add info for 2 new models

[Hans de Goede]

Hi,

On 5/27/24 11:14 AM, Hans de Goede wrote:
> Hi All,
> 
> This series adds touchscreen parameters for 2 new models to
> touchscreen_dmi.c . The parameters for these 2 new models have been
> found by using the new "i2c_touchscreen_props=..." kernel commandline
> argument.
> 
> These 2 patches have been cherry-picked from:
> 
> https://github.com/android-generic/kernel_common/
> 
> which already as the "i2c_touchscreen_props=..." support merged.

Thank you for your patch series, I've applied this patch series
to my review-hans  branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

I will include this series in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans



> 
> Regards,
> 
> Hans
> 
> 
> hmtheboy154 (2):
>   platform/x86: touchscreen_dmi: Add info for GlobalSpace SolT IVW 11.6"
>     tablet
>   platform/x86: touchscreen_dmi: Add info for the EZpad 6s Pro
> 
>  drivers/platform/x86/touchscreen_dmi.c | 35 ++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>