From: Sivaprakash Murugesan <sivaprak@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org
Subject: Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible
Date: Sat, 20 Jun 2020 06:36:08 +0530 [thread overview]
Message-ID: <efef8d40-1c89-76b5-261e-8801e4dbdf51@codeaurora.org> (raw)
In-Reply-To: <159261339539.62212.17722723971033735363@swboyd.mtv.corp.google.com>
On 6/20/2020 6:06 AM, Stephen Boyd wrote:
> Quoting Sivaprakash Murugesan (2020-06-06 03:55:04)
>> cpus on ipq6018 are clocked by a53 pll, add device compatible for a53
>> pll found on ipq6018 devices.
>>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>> ---
>> [V7]
>> * Addressed minor review comment from Rob
>> .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
>> index 20d2638..3161fab 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
>> @@ -15,6 +15,7 @@ description:
>>
>> properties:
>> compatible:
>> + const: qcom,ipq6018-a53pll
>> const: qcom,msm8916-a53pll
>>
>> reg:
> I'm getting this error when running dt binding check:
>
> ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
> in "<unicode string>", line 18, column 5
> found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll")
> in "<unicode string>", line 19, column 5
This error started coming after updating the dt-schema version.
Guess I need to replace const with enum to get rid of this error.
will address this.
next prev parent reply other threads:[~2020-06-20 1:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 10:55 [PATCH V7 0/4] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-06-06 10:55 ` [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible Sivaprakash Murugesan
2020-06-15 17:59 ` Rob Herring
2020-06-20 0:36 ` Stephen Boyd
2020-06-20 1:06 ` Sivaprakash Murugesan [this message]
2020-06-06 10:55 ` [PATCH V7 2/4] clk: qcom: Add ipq apss pll driver Sivaprakash Murugesan
2020-06-06 10:55 ` [PATCH V7 3/4] clk: qcom: Add DT bindings for ipq6018 apss clock controller Sivaprakash Murugesan
2020-06-09 19:47 ` Rob Herring
2020-06-20 2:26 ` Stephen Boyd
2020-06-06 10:55 ` [PATCH V7 4/4] clk: qcom: Add " Sivaprakash Murugesan
2020-06-18 7:00 ` [PATCH V7 0/4] Add APSS clock controller support for IPQ6018 Sivaprakash Murugesan
2020-06-20 0:31 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efef8d40-1c89-76b5-261e-8801e4dbdf51@codeaurora.org \
--to=sivaprak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.