[PATCH] gitweb: Remove redundant "commit" link from shortlog

[PATCH] gitweb: Remove redundant "commit" link from shortlog

[Luben Tuikov]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Remove the redundant "commit" link from shortlog.
It can be had by simply clicking on the entry title
of the row.

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

[-- Attachment #2: 1908141687-p2.txt --]
[-- Type: text/plain, Size: 625 bytes --]

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 79c8052..f3f22c2 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2013,7 +2013,6 @@ sub git_shortlog_body {
 		                          href(action=>"commit", hash=>$commit), $ref);
 		print "</td>\n" .
 		      "<td class=\"link\">" .
-		      $cgi->a({-href => href(action=>"commit", hash=>$commit)}, "commit") . " | " .
 		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff") . " | " .
 		      $cgi->a({-href => href(action=>"tree", hash=>$commit, hash_base=>$commit)}, "tree");
 		print "</td>\n" .
-- 
1.4.2.1.g05f0f

Re: [PATCH] gitweb: Remove redundant "commit" link from shortlog

[Petr Baudis]

Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter
where Luben Tuikov <ltuikov@yahoo.com> said that...
> Remove the redundant "commit" link from shortlog.
> It can be had by simply clicking on the entry title
> of the row.
> 
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>

And what if the commit message is empty?

Witness at http://repo.or.cz/?p=test;a=summary

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

Re: [PATCH] gitweb: Remove redundant "commit" link from shortlog

[Jakub Narebski]

Petr Baudis wrote:

> Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter
> where Luben Tuikov <ltuikov@yahoo.com> said that...
>> Remove the redundant "commit" link from shortlog.
>> It can be had by simply clicking on the entry title
>> of the row.
>> 
>> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> And what if the commit message is empty?
> 
> Witness at http://repo.or.cz/?p=test;a=summary

By the way, commitdiff view in this case also looks strange.
I think that simplyfying the git_difftree_body went too far,
Luben.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

[PATCH] gitweb: Handle commits with empty commit messages more reasonably

[Petr Baudis]

Currently those look very weird, you can't get easily at the commit view
etc. This patch makes their title '(no commit message)'.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

 gitweb/gitweb.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ea159e9..56e5231 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1115,6 +1115,9 @@ sub parse_commit {
 			last;
 		}
 	}
+	if ($co{'title'} eq "") {
+		$co{'title'} = $co{'title_short'} = '(no commit message)';
+	}
 	# remove added spaces
 	foreach my $line (@commit_lines) {
 		$line =~ s/^    //;

Re: [PATCH] gitweb: Remove redundant "commit" link from shortlog

[Luben Tuikov]

--- Petr Baudis <pasky@suse.cz> wrote:
> Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter
> where Luben Tuikov <ltuikov@yahoo.com> said that...
> > Remove the redundant "commit" link from shortlog.
> > It can be had by simply clicking on the entry title
> > of the row.
> > 
> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> And what if the commit message is empty?
> 
> Witness at http://repo.or.cz/?p=test;a=summary

Clearly a pathological case.  Who or why would anyone do this?
I don't think we should worry about such pathological cases.

Commits without commit messages do not question GIT.  They
question the committer... (that's the morning chuckle)

    Luben


> 
> -- 
> 				Petr "Pasky" Baudis
> Stuff: http://pasky.or.cz/
> #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
> $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
> lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>