Bitbake-1.6 crashes on 'which'.

Bitbake-1.6 crashes on 'which'.

[Rob Kramer]

Heya,

I had to patch 1.6 as below, copied from trunk/bitbake.

Cheers,

    Rob

Index: lib/bb/shell.py
===================================================================
--- lib/bb/shell.py     (revision 618)
+++ lib/bb/shell.py     (working copy)
@@ -57,7 +57,7 @@
 except NameError:
     from sets import Set as set
 import sys, os, readline, socket, httplib, urllib, commands, popen2, copy,
shlex, Queue, fnmatch
-from bb import data, parse, build, fatal
+from bb import data, parse, build, fatal, providers as Providers

 __version__ = "0.5.3.1"
 __credits__ = """BitBake Shell Version %s (C) 2005 Michael 'Mickey' Lauer
<mickey@Vanille.de>
@@ -107,7 +107,7 @@
         preferred = data.getVar( "PREFERRED_PROVIDER_%s" % item,
cooker.configuration.data, 1 )
         if not preferred: preferred = item
         try:
-            lv, lf, pv, pf = bb.providers.findBestProvider(preferred,
cooker.configuration.data, cooker.status, cooker.build_cache_fail)
+            lv, lf, pv, pf = Providers.findBestProvider(preferred,
cooker.configuration.data, cooker.status, cooker.build_cache_fail)
         except KeyError:
             if item in cooker.status.providers:
                 pf = cooker.status.providers[item][0]
@@ -529,7 +529,7 @@
         if not preferred: preferred = item

         try:
-            lv, lf, pv, pf = bb.providers.findBestProvider(preferred,
cooker.configuration.data, cooker.status, cooker.build_cache_fail)
+            lv, lf, pv, pf = Providers.findBestProvider(preferred,
cooker.configuration.data, cooker.status, cooker.build_cache_fail)
         except KeyError:
             lv, lf, pv, pf = (None,)*4

Re: Bitbake-1.6 crashes on 'which'.

[Rob Kramer]

Rob Kramer wrote:

> I had to patch 1.6 as below, copied from trunk/bitbake.

Or not; this dies elsewhere. Am I supposed to use 1.6 branch in the first
place? I'll try trunk for now..

Cheers,

    Rob


BB>> edit glibc-initial
Traceback (most recent call last):
  File "/home/rob/oe/bitbake/bin/bitbake", line 1161, in ?
    main()
  File "/home/rob/oe/bitbake/bin/bitbake", line 1156, in main
    cooker.cook( BBConfiguration( options ), args[1:] )
  File "/home/rob/oe/bitbake/bin/bitbake", line 888, in cook
    self.interactiveMode()
  File "/home/rob/oe/bitbake/bin/bitbake", line 793, in interactiveMode
    shell.start( self )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 804, in start
    bbshell.main()
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 779, in main
    self.processCommand( tokens[0], tokens[1:] or "" )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 736, in processCommand
    result = function( self.commands, params )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 189, in edit
    bbfile = self._findProvider( name )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 110, in _findProvider
    lv, lf, pv, pf = Providers.findBestProvider(preferred,
cooker.configuration.data, cooker.status, cooker.build_cache_fail)
  File "/home/rob/oe/bitbake/lib/bb/providers.py", line 41, in
findBestProvider
    files = pkg_pn[pn]
TypeError: list indices must be integers

Re: Bitbake-1.6 crashes on 'which'.

[Holger Freyther]

Am 18.10.2006 um 09:02 schrieb Rob Kramer:

> Heya,
>
> I had to patch 1.6 as below, copied from trunk/bitbake.
>

Hey Richard,

any idea?

holger

Re: Bitbake-1.6 crashes on 'which'.

[Richard Purdie]

On Wed, 2006-10-18 at 15:19 +0800, Rob Kramer wrote:
> Rob Kramer wrote:
> 
> > I had to patch 1.6 as below, copied from trunk/bitbake.
> 
> Or not; this dies elsewhere. Am I supposed to use 1.6 branch in the first
> place? I'll try trunk for now..

The patch in 1.7 is for a different problem. I've just updated the 1.6
branch with the correct fix (add import bb to the top of shell.py).

Thanks for reporting it.

Cheers,

Richard

Re: Bitbake-1.6 crashes on 'which'.

[Rob Kramer]

Richard Purdie wrote:
> The patch in 1.7 is for a different problem. I've just updated the 1.6
> branch with the correct fix (add import bb to the top of shell.py).

Thanks for that, it works again now. I still got the crash below, but that
was after a bunch of reparse commands, which might have upset bitbake a bit
perhaps.

Cheers,

    Rob


BB>> which fontconfig-native
Traceback (most recent call last):
  File "/home/rob/oe/bitbake/bin/bitbake", line 1161, in ?
    main()
  File "/home/rob/oe/bitbake/bin/bitbake", line 1156, in main
    cooker.cook( BBConfiguration( options ), args[1:] )
  File "/home/rob/oe/bitbake/bin/bitbake", line 888, in cook
    self.interactiveMode()
  File "/home/rob/oe/bitbake/bin/bitbake", line 793, in interactiveMode
    shell.start( self )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 805, in start
    bbshell.main()
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 780, in main
    self.processCommand( tokens[0], tokens[1:] or "" )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 737, in processCommand
    result = function( self.commands, params )
  File "/home/rob/oe/bitbake/lib/bb/shell.py", line 533, in which
    lv, lf, pv, pf = bb.providers.findBestProvider(preferred,
cooker.configuration.data, cooker.status, cooker.build_cache_fail)
  File "/home/rob/oe/bitbake/lib/bb/providers.py", line 41, in
findBestProvider
    files = pkg_pn[pn]
TypeError: list indices must be integers

Re: Bitbake-1.6 crashes on 'which'.

[Richard Purdie]

On Sun, 2006-10-22 at 10:57 +0800, Rob Kramer wrote:
> Richard Purdie wrote:
> > The patch in 1.7 is for a different problem. I've just updated the 1.6
> > branch with the correct fix (add import bb to the top of shell.py).
> 
> Thanks for that, it works again now. I still got the crash below, but that
> was after a bunch of reparse commands, which might have upset bitbake a bit
> perhaps.

I can't seem to reproduce that. Can you give a sequence of commands
which result in the failure?

Mickey: I suspect this is some problem with the shell's internal state?

Thanks,

Richard

Re: Bitbake-1.6 crashes on 'which'.

[Michael 'Mickey' Lauer]

Am Sonntag, den 22.10.2006, 18:41 +0100 schrieb Richard Purdie:
> On Sun, 2006-10-22 at 10:57 +0800, Rob Kramer wrote:
> > Richard Purdie wrote:
> > > The patch in 1.7 is for a different problem. I've just updated the 1.6
> > > branch with the correct fix (add import bb to the top of shell.py).
> > 
> > Thanks for that, it works again now. I still got the crash below, but that
> > was after a bunch of reparse commands, which might have upset bitbake a bit
> > perhaps.
> 
> I can't seem to reproduce that. Can you give a sequence of commands
> which result in the failure?
> 
> Mickey: I suspect this is some problem with the shell's internal state?

I'm afraid so, yes. This will get better in the future with our
frontend/backend separation strategy...

-- 
Regards,

Michael 'Mickey' Lauer | FreeLancer | http://www.Vanille-Media.de

Re: Bitbake-1.6 crashes on 'which'.

[Rob Kramer]

Richard Purdie wrote:
> I can't seem to reproduce that. Can you give a sequence of commands
> which result in the failure?

Hmm, it seems to happen rare enough not to be a problem. I was trying to get
a new version of a package visible to a running bitbake by doing reparses,
but I think that doesn't work (i.e, it doesn't want to switch to the newest
version). After it crashed out and was restarted, it selected my new
version properly.

Cheers,

    Rob